6d8c8650cd
Two intertwined agent safety nets that share the same files:
1. --dry-run flag for offline preview of mutation commands
2. Risk: metadata + SetRisk helper for destructive command surfaces
Coverage (19 mutation commands with --dry-run):
kb.create/edit/delete agent.create/edit/delete
doc.create/upload/fetch/delete doc.delete_all (special variant)
session.delete chunk.delete profile.add/remove
auth.refresh/logout link unlink
api.{post,put,patch,delete} (api.get + --dry-run rejected, exit 2)
Envelope additions (omitempty in non-dry-run paths):
meta.dry_run: bool true when --dry-run was used
meta.plan: map {action, args} per the per-command taxonomy
Risk: metadata
--------------
cmdutil.SetRisk(cmd, action) stamps cobra.Annotations with
risk.level=destructive + risk.action=<action> on the 9 destructive
commands. The SetAgentHelp wrapper prepends a "Risk: <action>
(destructive)" line in the default text help path so agents see a clear
warning before parsing Usage. WEKNORA_AGENT_HELP=1 JSON path stays
unchanged — structured agent-help already carries warnings[].
Validation parity with the live path
------------------------------------
Every pure-local validation (flag presence, mutual exclusion, enum
bounds, URL/regex format, ResolveKBLocal for KB resolution that does not
require an SDK call) runs BEFORE the dry-run gate. This matches the
industry-standard "preview shows what live would do" contract:
--dry-run accepts exactly the same invocations the live path accepts and
rejects exactly the same invocations the live path rejects, modulo the
side-effecting work itself.
The side-effecting work (SDK calls, file writes, keyring writes, server-
side name → id resolution) is what --dry-run actually gates. Each
mutation file pairs its RunE validation block with a regression test
under *_dry_run_test.go / dryrun_validation_test.go so future refactors
don't reintroduce the gap.
Helper surface
--------------
- HandleDryRun(cmd, dryRun, plan) extracts the early-return so the
19 RunE call sites stay 3 lines each.
- EmitDryRun routes through FormatOptions.Emit, inheriting _notice /
TTY indent / --jq filtering for free.
- ResolveKBLocal mirrors ResolveKB but never calls the SDK; dry-run
paths use it so the plan reports the raw --kb value (UUID or name)
without a name → id lookup.
Streaming commands (chat, session ask, session continue-stream) are
deliberately excluded: a buffered plan makes no sense for an event
stream.
Lock semantics in the dry-run path:
- destructive + --dry-run: exit 0, no exit-10 confirmation prompt
- --dry-run + -y: byte-identical envelope to --dry-run alone
- --dry-run + --jq: filter applies to the preview envelope normally
161 lines
6.1 KiB
Go
161 lines
6.1 KiB
Go
// Package doc — fetch.go implements `weknora doc fetch <url>`.
|
|
package doc
|
|
|
|
import (
|
|
"cmp"
|
|
"context"
|
|
"errors"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// docFetchFields enumerates the fields surfaced for `--format json` discovery
|
|
// on `doc fetch`.
|
|
var docFetchFields = []string{
|
|
"id", "knowledge_base_id", "tag_id", "type", "title", "description",
|
|
"source", "channel", "parse_status", "summary_status", "enable_status",
|
|
"embedding_model_id", "file_name", "file_type", "file_size", "file_hash",
|
|
"file_path", "storage_size",
|
|
"created_at", "updated_at", "processed_at", "error_message",
|
|
}
|
|
|
|
// FetchOptions holds CLI flag values for `doc fetch`.
|
|
type FetchOptions struct {
|
|
URL string
|
|
Name string // --name: FileName hint for file-vs-crawl mode detection
|
|
Title string // --title: display title for the new entry
|
|
FileType string // --file-type: extension hint for extension-less URLs
|
|
TagID string // --tag-id: associate the new entry with a tag
|
|
Channel string // --channel: ingestion-channel tag (default "api")
|
|
EnableMultimodel *bool // tri-state: nil = server default
|
|
DryRun bool
|
|
}
|
|
|
|
// FetchService is the narrow SDK surface for `doc fetch`.
|
|
// *sdk.Client satisfies it.
|
|
type FetchService interface {
|
|
CreateKnowledgeFromURL(
|
|
ctx context.Context,
|
|
kbID string,
|
|
req sdk.CreateKnowledgeFromURLRequest,
|
|
) (*sdk.Knowledge, error)
|
|
}
|
|
|
|
// NewCmdFetch builds `weknora doc fetch <url>`.
|
|
func NewCmdFetch(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &FetchOptions{}
|
|
cmd := &cobra.Command{
|
|
Use: "fetch <url>",
|
|
Short: "Fetch a remote document into a knowledge base",
|
|
Long: `Server fetches the document at the given URL and ingests it into the resolved
|
|
knowledge base. KB resolution follows the standard 4-level chain:
|
|
--kb flag > WEKNORA_KB_ID env > .weknora/project.yaml > error.
|
|
|
|
When the URL has a known file extension (.pdf, .docx, .md, .txt) the server
|
|
automatically switches from web-page-crawl mode to file-download mode. Pass
|
|
--file-type or --name with a recognisable extension to force file-download mode
|
|
for extension-less URLs.
|
|
|
|
Server-side ingestion knobs:
|
|
|
|
--name <name> Override the recorded file name; also used as the
|
|
file-type hint when the extension is recognisable.
|
|
--title <title> Set the display title stored with the entry.
|
|
--file-type <ext> Explicit file-type hint (e.g. "pdf") for URLs
|
|
without an extension.
|
|
--tag-id <id> Associate the new entry with a tag.
|
|
--enable-multimodel Toggle multimodal extraction (image-in-PDF → text).
|
|
Unset ⇒ server default; pass true or false to override.
|
|
--channel <name> Override the ingestion-channel tag (default "api").`,
|
|
Example: ` weknora doc fetch https://example.com/whitepaper.pdf
|
|
weknora doc fetch https://example.com/no-ext --file-type pdf --title "Whitepaper"
|
|
weknora doc fetch https://example.com/article.html --name "Q3 Article" --tag-id tag_abc
|
|
weknora doc fetch https://example.com/report.pdf --kb my-kb --enable-multimodel`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
opts.URL = args[0]
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
// Pure-local validation runs before the dry-run gate so --dry-run
|
|
// rejects identically to the live path.
|
|
if c.Flags().Changed("enable-multimodel") {
|
|
raw, _ := c.Flags().GetString("enable-multimodel")
|
|
v, perr := parseTriBool(raw)
|
|
if perr != nil {
|
|
return perr
|
|
}
|
|
opts.EnableMultimodel = &v
|
|
}
|
|
if err := cmdutil.ValidateHTTPURL("<url>", opts.URL); err != nil {
|
|
return err
|
|
}
|
|
if opts.DryRun {
|
|
// Local-only KB resolution: plan reports the raw --kb value
|
|
// (UUID or name) without an SDK lookup.
|
|
kbID, err := f.ResolveKBLocal(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if handled, err := cmdutil.HandleDryRun(c, true, cmdutil.DryRunPlan{
|
|
Action: "doc.fetch",
|
|
Args: map[string]any{
|
|
"url": opts.URL,
|
|
"kb": kbID,
|
|
},
|
|
}); handled {
|
|
return err
|
|
}
|
|
}
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
kbID, err := f.ResolveKB(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runFetch(c.Context(), opts, fopts, cli, kbID)
|
|
},
|
|
}
|
|
cmdutil.AddKBFlag(cmd)
|
|
cmd.Flags().StringVar(&opts.Name, "name", "", "File name hint (also used as file-type hint when extension is recognisable)")
|
|
cmd.Flags().StringVar(&opts.Title, "title", "", "Display title for the new entry")
|
|
cmd.Flags().StringVar(&opts.FileType, "file-type", "", "File-type hint such as \"pdf\" when the URL has no extension")
|
|
cmd.Flags().StringVar(&opts.TagID, "tag-id", "", "Tag id to associate with the new entry")
|
|
cmd.Flags().StringVar(&opts.Channel, "channel", "", "Ingestion-channel tag recorded server-side (default \"api\")")
|
|
cmd.Flags().String("enable-multimodel", "", "Toggle multimodal extraction (true|false); unset ⇒ server default")
|
|
cmd.Flags().Lookup("enable-multimodel").NoOptDefVal = "true"
|
|
cmdutil.AddFormatFlag(cmd, docFetchFields...)
|
|
cmdutil.AddDryRunFlag(cmd, &opts.DryRun)
|
|
return cmd
|
|
}
|
|
|
|
// runFetch ingests a remote URL via SDK CreateKnowledgeFromURL.
|
|
func runFetch(ctx context.Context, opts *FetchOptions, fopts *cmdutil.FormatOptions, svc FetchService, kbID string) error {
|
|
req := sdk.CreateKnowledgeFromURLRequest{
|
|
URL: opts.URL,
|
|
FileName: opts.Name,
|
|
FileType: opts.FileType,
|
|
EnableMultimodel: opts.EnableMultimodel,
|
|
Title: opts.Title,
|
|
TagID: opts.TagID,
|
|
Channel: cmp.Or(opts.Channel, uploadChannel),
|
|
}
|
|
k, err := svc.CreateKnowledgeFromURL(ctx, kbID, req)
|
|
if err != nil {
|
|
if errors.Is(err, sdk.ErrDuplicateURL) {
|
|
return cmdutil.Wrapf(cmdutil.CodeResourceAlreadyExists, err,
|
|
"URL already ingested into this knowledge base")
|
|
}
|
|
return cmdutil.WrapHTTP(err, "fetch document from %s", opts.URL)
|
|
}
|
|
return renderUploadSuccess(k, fopts, "Ingested", opts.Name, opts.URL)
|
|
}
|