2f8681b48e
Roadmap items 3-5 (session) and 3-6/7/8 (kb manage).
cli/cmd/session/ (new package; sessioncmd to avoid shadowing stdlib):
- session list: paginated table (ID/TITLE/UPDATED). --page / --page-size
with 1..1000 validation. _meta.has_more from page*size < total.
- session view <id>: prints metadata; non-empty fields only. Server
timestamps arrive as strings; parsed best-effort as RFC3339.
- session delete <id>: high-risk-write; exit-10 confirmation in non-
TTY/--json paths; --dry-run emits envelope.risk + dry_run:true.
cli/cmd/kb (extended):
- kb edit <id> [--name N] [--description D]: at least one flag required;
*string options so unset fields stay unset in the PUT body. SDK
UpdateKnowledgeBaseRequest has no embedding_model field, so the
roadmap's --embedding-model dropped.
- kb pin <id> / kb unpin <id>: direct parity with gh issue pin /
gh issue unpin (verified against gh manual). Idempotent: GetKnowledgeBase
reads IsPinned, TogglePinKnowledgeBase fires only on state change.
SDK KnowledgeBase struct gained the IsPinned field (server already
returned it; SDK just hadn't modeled it — non-breaking additive).
- kb empty <id>: high-risk-write; exit-10 confirmation;
--dry-run. Returns deleted_count from the async clear response.
weknora-specific operation; no mainstream parallel.
Golden envelopes for kb_list and kb_view updated to include the new
is_pinned field — strict-additive change.
Cleanups surfaced by the post-commit reviewer round:
- ConfirmPrompter promoted to cli/internal/testutil/ (4-copy threshold
reached: context/remove, kb/delete, kb/empty, session/delete).
kb/delete_test.go's pre-existing local copy left untouched per the
upstream-respect convention.
- kb pin/unpin idempotent no-op path no longer emits a write-class
envelope. Added _meta.warnings "already {un}pinned — no server
call made" and dropped the risk classification on the no-op branch.
- doc list --page-size was unbounded while session list enforces
1..1000. Same validation added to doc list.
18 + 18 unit tests; e2e exit codes verified.
Roadmap: 3-5, 3-6, 3-7, 3-8.
243 lines
7.7 KiB
Go
243 lines
7.7 KiB
Go
package contextcmd
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/format"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/secrets"
|
|
"github.com/Tencent/WeKnora/cli/internal/testutil"
|
|
)
|
|
|
|
// seedStore returns a MemStore pre-loaded with sentinel values for every
|
|
// secret slot a context might reference. Tests assert deletion by checking
|
|
// `secrets.ErrNotFound` post-runRemove.
|
|
func seedStore(t *testing.T, name string, slots ...string) *secrets.MemStore {
|
|
t.Helper()
|
|
s := secrets.NewMemStore()
|
|
for _, slot := range slots {
|
|
if err := s.Set(name, slot, "sentinel-"+name+"-"+slot); err != nil {
|
|
t.Fatalf("seed %s/%s: %v", name, slot, err)
|
|
}
|
|
}
|
|
return s
|
|
}
|
|
|
|
func assertDeleted(t *testing.T, s *secrets.MemStore, name, slot string) {
|
|
t.Helper()
|
|
if _, err := s.Get(name, slot); !errors.Is(err, secrets.ErrNotFound) {
|
|
t.Errorf("expected %s/%s removed, got err=%v", name, slot, err)
|
|
}
|
|
}
|
|
|
|
func TestRemove_NonCurrent_NoPromptNeeded(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
out, _ := iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "production",
|
|
Contexts: map[string]config.Context{
|
|
"production": {Host: "https://prod.example.com", TokenRef: "mem://production/access"},
|
|
"staging": {Host: "https://staging.example.com", APIKeyRef: "mem://staging/api_key"},
|
|
},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
store := seedStore(t, "staging", "api_key")
|
|
p := &testutil.ConfirmPrompter{}
|
|
if err := runRemove(&RemoveOptions{}, "staging", store, p); err != nil {
|
|
t.Fatalf("runRemove: %v", err)
|
|
}
|
|
if p.Asked {
|
|
t.Errorf("non-current remove must not prompt")
|
|
}
|
|
|
|
got, _ := config.Load()
|
|
if _, exists := got.Contexts["staging"]; exists {
|
|
t.Errorf("staging should have been removed; Contexts=%v", got.Contexts)
|
|
}
|
|
if got.CurrentContext != "production" {
|
|
t.Errorf("CurrentContext must be unchanged, got %q", got.CurrentContext)
|
|
}
|
|
assertDeleted(t, store, "staging", "api_key")
|
|
if !strings.Contains(out.String(), "staging") {
|
|
t.Errorf("output should mention removed context, got %q", out.String())
|
|
}
|
|
}
|
|
|
|
func TestRemove_NotFound_WithDidYouMean(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{Contexts: map[string]config.Context{
|
|
"production": {Host: "https://prod"},
|
|
"staging": {Host: "https://staging"},
|
|
}}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
err := runRemove(&RemoveOptions{}, "prodution", secrets.NewMemStore(), &testutil.ConfirmPrompter{})
|
|
if err == nil {
|
|
t.Fatal("expected not-found error")
|
|
}
|
|
cm, ok := err.(*cmdutil.Error)
|
|
if !ok {
|
|
t.Fatalf("expected *cmdutil.Error, got %T", err)
|
|
}
|
|
if cm.Code != cmdutil.CodeLocalContextNotFound {
|
|
t.Errorf("code=%q, want %q", cm.Code, cmdutil.CodeLocalContextNotFound)
|
|
}
|
|
if !strings.Contains(cm.Hint, "production") {
|
|
t.Errorf("hint should suggest 'production', got %q", cm.Hint)
|
|
}
|
|
}
|
|
|
|
func TestRemove_Current_NonTTY_NoYes_RequiresConfirmation(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "production",
|
|
Contexts: map[string]config.Context{
|
|
"production": {Host: "https://prod", TokenRef: "mem://production/access"},
|
|
"staging": {Host: "https://staging"},
|
|
},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
store := seedStore(t, "production", "access")
|
|
err := runRemove(&RemoveOptions{}, "production", store, &testutil.ConfirmPrompter{})
|
|
if err == nil {
|
|
t.Fatal("expected confirmation-required error")
|
|
}
|
|
cm, ok := err.(*cmdutil.Error)
|
|
if !ok {
|
|
t.Fatalf("expected *cmdutil.Error, got %T", err)
|
|
}
|
|
if cm.Code != cmdutil.CodeInputConfirmationRequired {
|
|
t.Errorf("code=%q, want %q", cm.Code, cmdutil.CodeInputConfirmationRequired)
|
|
}
|
|
if cmdutil.ExitCode(err) != 10 {
|
|
t.Errorf("expected exit-10, got %d", cmdutil.ExitCode(err))
|
|
}
|
|
// Must not have mutated config or keyring.
|
|
if got, _ := config.Load(); got.CurrentContext != "production" {
|
|
t.Errorf("config mutated despite confirmation gate: CurrentContext=%q", got.CurrentContext)
|
|
}
|
|
if v, err := store.Get("production", "access"); err != nil || v == "" {
|
|
t.Errorf("keyring touched before confirmation, get=%q err=%v", v, err)
|
|
}
|
|
}
|
|
|
|
func TestRemove_Current_WithYes_ClearsCurrent(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
out, _ := iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "production",
|
|
Contexts: map[string]config.Context{
|
|
"production": {Host: "https://prod", TokenRef: "mem://production/access"},
|
|
"staging": {Host: "https://staging"},
|
|
},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
store := seedStore(t, "production", "access")
|
|
if err := runRemove(&RemoveOptions{Yes: true}, "production", store, &testutil.ConfirmPrompter{}); err != nil {
|
|
t.Fatalf("runRemove: %v", err)
|
|
}
|
|
got, _ := config.Load()
|
|
if _, exists := got.Contexts["production"]; exists {
|
|
t.Errorf("production should be removed")
|
|
}
|
|
if got.CurrentContext != "" {
|
|
t.Errorf("removing current must clear CurrentContext, got %q", got.CurrentContext)
|
|
}
|
|
assertDeleted(t, store, "production", "access")
|
|
if !strings.Contains(out.String(), "current context cleared") {
|
|
t.Errorf("output should warn about cleared current, got %q", out.String())
|
|
}
|
|
}
|
|
|
|
func TestRemove_Current_TTY_PromptNo(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
_, errBuf := iostreams.SetForTestWithTTY(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "production",
|
|
Contexts: map[string]config.Context{"production": {Host: "https://prod"}},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
p := &testutil.ConfirmPrompter{Answer: false}
|
|
err := runRemove(&RemoveOptions{}, "production", secrets.NewMemStore(), p)
|
|
if err == nil {
|
|
t.Fatal("expected user-aborted error")
|
|
}
|
|
cm, ok := err.(*cmdutil.Error)
|
|
if !ok {
|
|
t.Fatalf("expected *cmdutil.Error, got %T", err)
|
|
}
|
|
if cm.Code != cmdutil.CodeUserAborted {
|
|
t.Errorf("code=%q, want %q", cm.Code, cmdutil.CodeUserAborted)
|
|
}
|
|
if !p.Asked {
|
|
t.Errorf("prompt should have been asked on TTY")
|
|
}
|
|
if !strings.Contains(errBuf.String(), "Aborted") {
|
|
t.Errorf("stderr should contain Aborted, got %q", errBuf.String())
|
|
}
|
|
if got, _ := config.Load(); got.CurrentContext != "production" {
|
|
t.Errorf("aborted remove must not mutate config")
|
|
}
|
|
}
|
|
|
|
func TestRemove_DryRun(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
out, _ := iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "production",
|
|
Contexts: map[string]config.Context{"production": {Host: "https://prod", TokenRef: "mem://production/access"}},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
store := seedStore(t, "production", "access")
|
|
if err := runRemove(&RemoveOptions{DryRun: true, JSONOut: true}, "production", store, &testutil.ConfirmPrompter{}); err != nil {
|
|
t.Fatalf("runRemove dry-run: %v", err)
|
|
}
|
|
var env format.Envelope
|
|
if jerr := json.Unmarshal(out.Bytes(), &env); jerr != nil {
|
|
t.Fatalf("invalid envelope: %v\noutput=%q", jerr, out.String())
|
|
}
|
|
if !env.OK || !env.DryRun {
|
|
t.Errorf("envelope should be ok=true, dry_run=true, got %+v", env)
|
|
}
|
|
if env.Risk == nil || env.Risk.Level != format.RiskHighRiskWrite {
|
|
t.Errorf("dry-run on current context should report high-risk-write, got %+v", env.Risk)
|
|
}
|
|
// Nothing actually mutated.
|
|
if got, _ := config.Load(); got.CurrentContext != "production" {
|
|
t.Errorf("dry-run must not mutate config")
|
|
}
|
|
if v, err := store.Get("production", "access"); err != nil || v == "" {
|
|
t.Errorf("dry-run must not touch keyring; get=%q err=%v", v, err)
|
|
}
|
|
}
|