f2e8e3f56c
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
183 lines
6.5 KiB
Go
183 lines
6.5 KiB
Go
package search
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// chunksFields enumerates the fields surfaced for `--json` discovery on
|
|
// `search chunks`. Filter applies to each SearchResult object in the bare
|
|
// array.
|
|
var chunksFields = []string{
|
|
"id", "content", "knowledge_id", "chunk_index", "knowledge_title",
|
|
"start_at", "end_at", "seq", "score", "match_type", "chunk_type",
|
|
"image_info", "metadata", "knowledge_filename", "knowledge_source",
|
|
"knowledge_channel", "matched_content",
|
|
}
|
|
|
|
type ChunksOptions struct {
|
|
Query string
|
|
KB string // raw --kb (UUID or name)
|
|
KBID string // resolved id; populated before HybridSearch
|
|
Limit int
|
|
VectorThreshold float64
|
|
KeywordThreshold float64
|
|
NoVector bool
|
|
NoKeyword bool
|
|
}
|
|
|
|
// ChunksService is the narrow SDK surface used by runChunks. *sdk.Client
|
|
// satisfies it; tests inject fakes via Factory.Client.
|
|
type ChunksService interface {
|
|
HybridSearch(ctx context.Context, kbID string, params *sdk.SearchParams) ([]*sdk.SearchResult, error)
|
|
}
|
|
|
|
// NewCmdChunks builds `weknora search chunks "<query>" --kb <id-or-name>`.
|
|
// Uses a positional query argument with the KB selected via flag.
|
|
//
|
|
// The `--kb` flag accepts either a KB UUID (passed through unchanged) or a
|
|
// name (resolved via ListKnowledgeBases - see cmdutil.ResolveKBFlag).
|
|
func NewCmdChunks(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &ChunksOptions{}
|
|
cmd := &cobra.Command{
|
|
Use: `chunks "<query>"`,
|
|
Short: "Hybrid (vector + keyword) chunk retrieval against a knowledge base",
|
|
Example: ` weknora search chunks "what is RAG?" --kb engineering
|
|
weknora search chunks "embedding model" --kb kb_abc --limit 20
|
|
weknora search chunks "k8s" --kb engineering --no-keyword # vector-only`,
|
|
Long: `Hybrid (vector + keyword) retrieval against the knowledge base. Pass
|
|
--no-vector or --no-keyword to disable one channel; you cannot disable both.
|
|
--limit caps the returned slice client-side.`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
opts.Query = strings.TrimSpace(args[0])
|
|
if err := opts.validate(); err != nil {
|
|
return err
|
|
}
|
|
if opts.Limit < 1 || opts.Limit > 1000 {
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument, "--limit must be between 1 and 1000")
|
|
}
|
|
jopts, err := cmdutil.CheckJSONFlags(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
kbID, err := cmdutil.ResolveKBFlag(c.Context(), cli, opts.KB)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
opts.KBID = kbID
|
|
return runChunks(c.Context(), opts, jopts, cli)
|
|
},
|
|
}
|
|
bindChunksFlags(cmd, opts)
|
|
_ = cmd.MarkFlagRequired("kb")
|
|
return cmd
|
|
}
|
|
|
|
// bindChunksFlags registers the chunks flag surface in one place to keep
|
|
// the constructor readable; --kb is marked required by the caller.
|
|
func bindChunksFlags(cmd *cobra.Command, opts *ChunksOptions) {
|
|
cmd.Flags().StringVar(&opts.KB, "kb", "", "Knowledge base UUID or name")
|
|
cmd.Flags().IntVarP(&opts.Limit, "limit", "L", 8, "Maximum results to return (default 8 - tuned for RAG context window; list commands default to 30)")
|
|
cmd.Flags().Float64Var(&opts.VectorThreshold, "vector-threshold", 0, "Vector retrieval similarity floor (per-channel, pre-fusion); 0 = no filter")
|
|
cmd.Flags().Float64Var(&opts.KeywordThreshold, "keyword-threshold", 0, "Keyword retrieval score floor (per-channel, pre-fusion); 0 = no filter")
|
|
cmd.Flags().BoolVar(&opts.NoVector, "no-vector", false, "Disable the vector channel")
|
|
cmd.Flags().BoolVar(&opts.NoKeyword, "no-keyword", false, "Disable the keyword channel")
|
|
cmdutil.AddJSONFlags(cmd, chunksFields)
|
|
}
|
|
|
|
// validate checks the option set before any SDK call. Limit bounds are
|
|
// enforced separately in RunE (user-input boundary) so internal callers
|
|
// can pass Limit==0 for the "no client-side cap" path.
|
|
func (o *ChunksOptions) validate() error {
|
|
if o.Query == "" {
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument, "query argument cannot be empty")
|
|
}
|
|
if o.NoVector && o.NoKeyword {
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument, "--no-vector and --no-keyword cannot both be set")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func runChunks(ctx context.Context, opts *ChunksOptions, jopts *cmdutil.JSONOptions, svc ChunksService) error {
|
|
if err := opts.validate(); err != nil {
|
|
return err
|
|
}
|
|
if svc == nil {
|
|
return cmdutil.NewError(cmdutil.CodeServerError, "search chunks: no SDK client available")
|
|
}
|
|
|
|
params := &sdk.SearchParams{
|
|
QueryText: opts.Query,
|
|
MatchCount: opts.Limit,
|
|
VectorThreshold: opts.VectorThreshold,
|
|
KeywordThreshold: opts.KeywordThreshold,
|
|
DisableVectorMatch: opts.NoVector,
|
|
DisableKeywordsMatch: opts.NoKeyword,
|
|
}
|
|
results, err := svc.HybridSearch(ctx, opts.KBID, params)
|
|
if err != nil {
|
|
return cmdutil.WrapHTTP(err, "hybrid search")
|
|
}
|
|
// match_count is the server's *primary-match* cap - after that, the
|
|
// service appends parent / nearby / relation chunks as context
|
|
// enrichment, so the wire response can exceed Limit. Treat --limit as
|
|
// a hard return-count cap by trimming on the client. Recall isn't
|
|
// affected because the server's internal retrieval pool is already
|
|
// max(MatchCount*5, 50).
|
|
if opts.Limit > 0 && len(results) > opts.Limit {
|
|
results = results[:opts.Limit]
|
|
}
|
|
|
|
if jopts.Enabled() {
|
|
if results == nil {
|
|
results = []*sdk.SearchResult{}
|
|
}
|
|
return jopts.Emit(iostreams.IO.Out, results)
|
|
}
|
|
return renderChunkResults(results, opts.KBID)
|
|
}
|
|
|
|
// renderChunkResults prints a compact pretty list. Minimal stopgap - a
|
|
// richer tabular renderer can replace this later without breaking the
|
|
// JSON contract.
|
|
func renderChunkResults(results []*sdk.SearchResult, kbID string) error {
|
|
if len(results) == 0 {
|
|
fmt.Fprintln(iostreams.IO.Out, "(no results)")
|
|
return nil
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "%d result(s) from kb=%s:\n\n", len(results), kbID)
|
|
for i, r := range results {
|
|
fmt.Fprintf(iostreams.IO.Out, "[%d] score=%.3f", i+1, r.Score)
|
|
if r.KnowledgeID != "" {
|
|
fmt.Fprintf(iostreams.IO.Out, " doc=%s", r.KnowledgeID)
|
|
}
|
|
fmt.Fprintln(iostreams.IO.Out)
|
|
fmt.Fprintln(iostreams.IO.Out, indent(strings.TrimSpace(r.Content), " "))
|
|
fmt.Fprintln(iostreams.IO.Out)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func indent(s, prefix string) string {
|
|
if s == "" {
|
|
return ""
|
|
}
|
|
lines := strings.Split(s, "\n")
|
|
for i, l := range lines {
|
|
lines[i] = prefix + l
|
|
}
|
|
return strings.Join(lines, "\n")
|
|
}
|