Add knowledge base duplicate flow
This commit is contained in:
@@ -241,6 +241,17 @@ type CopyKnowledgeBaseResponse struct {
|
||||
Message string `json:"message"`
|
||||
}
|
||||
|
||||
type DuplicateKnowledgeBaseRequest struct {
|
||||
TargetID string `json:"target_id,omitempty"`
|
||||
}
|
||||
|
||||
type DuplicateKnowledgeBaseResponse struct {
|
||||
SourceID string `json:"source_id"`
|
||||
TargetID string `json:"target_id"`
|
||||
Message string `json:"message"`
|
||||
KnowledgeBase KnowledgeBase `json:"knowledge_base"`
|
||||
}
|
||||
|
||||
// KBCloneProgress represents the progress of a knowledge base clone task
|
||||
type KBCloneProgress struct {
|
||||
TaskID string `json:"task_id"`
|
||||
@@ -462,6 +473,31 @@ func (c *Client) CopyKnowledgeBase(ctx context.Context, request *CopyKnowledgeBa
|
||||
return &response.Data, nil
|
||||
}
|
||||
|
||||
// DuplicateKnowledgeBase creates a settings-only duplicate and returns the new knowledge base info.
|
||||
func (c *Client) DuplicateKnowledgeBase(
|
||||
ctx context.Context,
|
||||
knowledgeBaseID string,
|
||||
request *DuplicateKnowledgeBaseRequest,
|
||||
) (*DuplicateKnowledgeBaseResponse, error) {
|
||||
path := fmt.Sprintf("/api/v1/knowledge-bases/%s/duplicate", knowledgeBaseID)
|
||||
|
||||
resp, err := c.doRequest(ctx, http.MethodPost, path, request, nil)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
var response struct {
|
||||
Success bool `json:"success"`
|
||||
Data DuplicateKnowledgeBaseResponse `json:"data"`
|
||||
}
|
||||
|
||||
if err := parseResponse(resp, &response); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
return &response.Data, nil
|
||||
}
|
||||
|
||||
// GetKBCloneProgress gets the progress of a knowledge base clone task
|
||||
func (c *Client) GetKBCloneProgress(ctx context.Context, taskID string) (*KBCloneProgress, error) {
|
||||
path := fmt.Sprintf("/api/v1/knowledge-bases/copy/progress/%s", taskID)
|
||||
|
||||
@@ -135,6 +135,10 @@ export function copyKnowledgeBase(data: { source_id: string; target_id?: string
|
||||
return post(`/api/v1/knowledge-bases/copy`, data);
|
||||
}
|
||||
|
||||
export function duplicateKnowledgeBase(id: string, data: { target_id?: string } = {}) {
|
||||
return post(`/api/v1/knowledge-bases/${id}/duplicate`, data);
|
||||
}
|
||||
|
||||
// 获取可移动目标知识库列表(同类型、同Embedding模型)
|
||||
export function listMoveTargets(sourceKbId: string) {
|
||||
return get(`/api/v1/knowledge-bases/${sourceKbId}/move-targets`);
|
||||
@@ -490,4 +494,4 @@ export function batchReparseKnowledge(kbId: string, ids: string[], processConfig
|
||||
ids,
|
||||
process_config: processConfig,
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -2262,6 +2262,7 @@ export default {
|
||||
},
|
||||
menu: {
|
||||
viewDetails: 'View Details',
|
||||
duplicate: 'Duplicate',
|
||||
},
|
||||
pin: {
|
||||
pin: 'Pin to Top',
|
||||
@@ -2282,6 +2283,8 @@ export default {
|
||||
messages: {
|
||||
deleted: 'Knowledge base deleted',
|
||||
deleteFailed: 'Failed to delete knowledge base',
|
||||
duplicateSuccess: 'Knowledge base duplicate created (content not included)',
|
||||
duplicateFailed: 'Failed to create knowledge base duplicate',
|
||||
file: 'File',
|
||||
knowledgeBase: 'Knowledge Base',
|
||||
noResult: 'No results',
|
||||
|
||||
@@ -3165,6 +3165,7 @@ export default {
|
||||
},
|
||||
menu: {
|
||||
viewDetails: "세부 사항을 확인하세요",
|
||||
duplicate: "복제",
|
||||
},
|
||||
pin: {
|
||||
pin: "상단 고정",
|
||||
@@ -3215,6 +3216,8 @@ export default {
|
||||
messages: {
|
||||
deleted: "삭제됨",
|
||||
deleteFailed: "삭제 실패",
|
||||
duplicateSuccess: "지식베이스 복제본이 생성되었습니다(콘텐츠 제외)",
|
||||
duplicateFailed: "지식베이스 복제본 생성 실패",
|
||||
file: "파일",
|
||||
knowledgeBase: "지식베이스",
|
||||
noResult: "결과 없음",
|
||||
|
||||
@@ -2652,6 +2652,8 @@ export default {
|
||||
messages: {
|
||||
deleted: 'База знаний удалена',
|
||||
deleteFailed: 'Не удалось удалить базу знаний',
|
||||
duplicateSuccess: 'Дубликат базы знаний создан (без содержимого)',
|
||||
duplicateFailed: 'Не удалось создать дубликат базы знаний',
|
||||
file: '文件',
|
||||
knowledgeBase: '知识库',
|
||||
noResult: '无结果'
|
||||
@@ -2694,7 +2696,8 @@ export default {
|
||||
},
|
||||
emptyShared: 'No collaborative knowledge bases yet. Join a shared space to access knowledge bases from others.',
|
||||
menu: {
|
||||
viewDetails: 'View Details'
|
||||
viewDetails: 'View Details',
|
||||
duplicate: 'Duplicate'
|
||||
},
|
||||
detail: {
|
||||
title: 'Shared Knowledge Base',
|
||||
|
||||
@@ -3184,6 +3184,7 @@ export default {
|
||||
},
|
||||
menu: {
|
||||
viewDetails: "查看详情",
|
||||
duplicate: "创建副本",
|
||||
},
|
||||
pin: {
|
||||
pin: "置顶",
|
||||
@@ -3234,6 +3235,8 @@ export default {
|
||||
messages: {
|
||||
deleted: "已删除",
|
||||
deleteFailed: "删除失败",
|
||||
duplicateSuccess: "知识库副本已创建(不包含知识内容)",
|
||||
duplicateFailed: "创建知识库副本失败",
|
||||
file: "文件",
|
||||
knowledgeBase: "知识库",
|
||||
noResult: "无结果",
|
||||
|
||||
@@ -219,6 +219,11 @@
|
||||
<t-icon class="menu-icon" :name="kb.is_pinned ? 'pin-filled' : 'pin'" />
|
||||
<span>{{ kb.is_pinned ? $t('knowledgeList.pin.unpin') : $t('knowledgeList.pin.pin') }}</span>
|
||||
</div>
|
||||
<div v-if="canDuplicateKBCard(kb)" class="popup-menu-item"
|
||||
@click.stop="handleDuplicateById(kb.id)">
|
||||
<t-icon class="menu-icon" name="file-copy" />
|
||||
<span>{{ $t('knowledgeList.menu.duplicate') }}</span>
|
||||
</div>
|
||||
<template v-if="canManageKBCard(kb)">
|
||||
<div class="popup-menu-item" @click.stop="handleSettingsById(kb.id)">
|
||||
<t-icon class="menu-icon" name="setting" />
|
||||
@@ -448,6 +453,10 @@
|
||||
<t-icon class="menu-icon" :name="kb.is_pinned ? 'pin-filled' : 'pin'" />
|
||||
<span>{{ kb.is_pinned ? $t('knowledgeList.pin.unpin') : $t('knowledgeList.pin.pin') }}</span>
|
||||
</div>
|
||||
<div v-if="canDuplicateKBCard(kb)" class="popup-menu-item" @click.stop="handleDuplicate(kb)">
|
||||
<t-icon class="menu-icon" name="file-copy" />
|
||||
<span>{{ $t('knowledgeList.menu.duplicate') }}</span>
|
||||
</div>
|
||||
<template v-if="canManageKBCard(kb)">
|
||||
<div class="popup-menu-item" @click.stop="handleSettings(kb)">
|
||||
<t-icon class="menu-icon" name="setting" />
|
||||
@@ -774,7 +783,7 @@
|
||||
import { onMounted, onUnmounted, ref, computed, watch, nextTick } from 'vue'
|
||||
import { useRouter, useRoute } from 'vue-router'
|
||||
import { MessagePlugin, Icon as TIcon } from 'tdesign-vue-next'
|
||||
import { deleteKnowledgeBase, togglePinKnowledgeBase } from '@/api/knowledge-base'
|
||||
import { deleteKnowledgeBase, duplicateKnowledgeBase, togglePinKnowledgeBase } from '@/api/knowledge-base'
|
||||
import { useChatResourcesStore } from '@/stores/chatResources'
|
||||
import { formatStringDate } from '@/utils/index'
|
||||
import { useUIStore } from '@/stores/ui'
|
||||
@@ -1348,6 +1357,10 @@ function canManageKBCard(kb: KB): boolean {
|
||||
return authStore.hasRole('admin')
|
||||
}
|
||||
|
||||
function canDuplicateKBCard(kb: any): boolean {
|
||||
return authStore.hasRole('contributor') && kb.isMine !== false
|
||||
}
|
||||
|
||||
// isMyKb 仅用于卡片右下角徽章在「我创建」与「同租户其他成员创建」之间切换。
|
||||
// 与 canManageKBCard 不同:管理权限有 admin 兜底,徽章纯粹按创建者匹配。
|
||||
// creator_id 为空(PR 5 RBAC 迁移之前的老 KB)一律按 tenant 处理——避免把
|
||||
@@ -1420,6 +1433,33 @@ const handleTogglePinById = async (id: string) => {
|
||||
}
|
||||
}
|
||||
|
||||
const handleDuplicate = async (kb: KB) => {
|
||||
kb.showMore = false
|
||||
await duplicateKB(kb.id)
|
||||
}
|
||||
|
||||
const handleDuplicateById = async (id: string) => {
|
||||
await duplicateKB(id)
|
||||
}
|
||||
|
||||
const duplicateKB = async (id: string) => {
|
||||
try {
|
||||
const res: any = await duplicateKnowledgeBase(id)
|
||||
if (res?.success) {
|
||||
const newKbId = res.data?.target_id || res.data?.knowledge_base?.id
|
||||
MessagePlugin.success(t('knowledgeList.messages.duplicateSuccess'))
|
||||
await fetchList(true)
|
||||
if (newKbId) {
|
||||
triggerHighlightFlash(newKbId)
|
||||
}
|
||||
} else {
|
||||
MessagePlugin.error(res?.message || t('knowledgeList.messages.duplicateFailed'))
|
||||
}
|
||||
} catch (e: any) {
|
||||
MessagePlugin.error(e?.message || t('knowledgeList.messages.duplicateFailed'))
|
||||
}
|
||||
}
|
||||
|
||||
const handleShare = (kb: KB) => {
|
||||
// 手动关闭弹窗
|
||||
kb.showMore = false
|
||||
|
||||
@@ -83,6 +83,14 @@ func (s *stubKnowledgeBaseService) CopyKnowledgeBase(
|
||||
return nil, nil, nil
|
||||
}
|
||||
|
||||
func (s *stubKnowledgeBaseService) DuplicateKnowledgeBase(
|
||||
context.Context,
|
||||
string,
|
||||
string,
|
||||
) (*types.KnowledgeBase, error) {
|
||||
return nil, nil
|
||||
}
|
||||
|
||||
func (s *stubKnowledgeBaseService) GetRepository() interfaces.KnowledgeBaseRepository {
|
||||
return nil
|
||||
}
|
||||
|
||||
@@ -103,6 +103,9 @@ func (s *processSyncKBService) ResolveEmbeddingModelKeys(context.Context, []*typ
|
||||
func (s *processSyncKBService) CopyKnowledgeBase(context.Context, string, string) (*types.KnowledgeBase, *types.KnowledgeBase, error) {
|
||||
return nil, nil, nil
|
||||
}
|
||||
func (s *processSyncKBService) DuplicateKnowledgeBase(context.Context, string, string) (*types.KnowledgeBase, error) {
|
||||
return nil, nil
|
||||
}
|
||||
func (s *processSyncKBService) GetRepository() interfaces.KnowledgeBaseRepository { return nil }
|
||||
func (s *processSyncKBService) ProcessKBDelete(context.Context, *asynq.Task) error {
|
||||
return nil
|
||||
|
||||
@@ -1028,3 +1028,120 @@ func (s *knowledgeBaseService) CopyKnowledgeBase(ctx context.Context,
|
||||
}
|
||||
return sourceKB, targetKB, nil
|
||||
}
|
||||
|
||||
// DuplicateKnowledgeBase creates a new KB from the source KB's settings only.
|
||||
// Runtime/content state is deliberately reset so this path never copies
|
||||
// knowledge entries, chunks, FAQ content, wiki pages, indexes, shares or pins.
|
||||
func (s *knowledgeBaseService) DuplicateKnowledgeBase(
|
||||
ctx context.Context,
|
||||
srcKB string,
|
||||
targetID string,
|
||||
) (*types.KnowledgeBase, error) {
|
||||
srcKB = strings.TrimSpace(srcKB)
|
||||
targetID = strings.TrimSpace(targetID)
|
||||
if srcKB == "" {
|
||||
return nil, apperrors.NewBadRequestError("source knowledge base ID cannot be empty")
|
||||
}
|
||||
|
||||
tenantID := types.MustTenantIDFromContext(ctx)
|
||||
sourceKB, err := s.repo.GetKnowledgeBaseByIDAndTenant(ctx, srcKB, tenantID)
|
||||
if err != nil {
|
||||
logger.Errorf(ctx, "Get source knowledge base failed: %v", err)
|
||||
return nil, err
|
||||
}
|
||||
sourceKB.EnsureDefaults()
|
||||
|
||||
targetKB, err := cloneKnowledgeBaseConfiguration(sourceKB)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
if targetID != "" {
|
||||
targetKB.ID = targetID
|
||||
} else {
|
||||
targetKB.ID = uuid.New().String()
|
||||
}
|
||||
targetKB.TenantID = tenantID
|
||||
targetKB.Name = s.buildDuplicateKnowledgeBaseName(ctx, tenantID, sourceKB.Name)
|
||||
targetKB.CreatorID = ""
|
||||
if uid, ok := types.UserIDFromContext(ctx); ok && !types.IsSyntheticUserID(uid) {
|
||||
targetKB.CreatorID = uid
|
||||
}
|
||||
now := time.Now()
|
||||
targetKB.CreatedAt = now
|
||||
targetKB.UpdatedAt = now
|
||||
targetKB.DeletedAt.Valid = false
|
||||
targetKB.DeletedAt.Time = time.Time{}
|
||||
targetKB.IsTemporary = false
|
||||
targetKB.IsPinned = false
|
||||
targetKB.PinnedAt = nil
|
||||
targetKB.KnowledgeCount = 0
|
||||
targetKB.ChunkCount = 0
|
||||
targetKB.IsProcessing = false
|
||||
targetKB.ProcessingCount = 0
|
||||
targetKB.ShareCount = 0
|
||||
targetKB.CreatorName = ""
|
||||
targetKB.EnsureDefaults()
|
||||
targetKB.Normalize()
|
||||
|
||||
if targetKB.HasVectorStore() {
|
||||
if err := s.validateVectorStoreBinding(ctx, tenantID, *targetKB.VectorStoreID); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
}
|
||||
|
||||
if err := s.repo.CreateKnowledgeBase(ctx, targetKB); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return targetKB, nil
|
||||
}
|
||||
|
||||
func (s *knowledgeBaseService) buildDuplicateKnowledgeBaseName(
|
||||
ctx context.Context,
|
||||
tenantID uint64,
|
||||
sourceName string,
|
||||
) string {
|
||||
baseName := strings.TrimSpace(sourceName)
|
||||
if baseName == "" {
|
||||
baseName = "知识库"
|
||||
}
|
||||
|
||||
kbs, err := s.repo.ListKnowledgeBasesByTenantID(ctx, tenantID)
|
||||
if err != nil {
|
||||
logger.Warnf(ctx, "List tenant knowledge bases failed while building duplicate name: %v", err)
|
||||
return baseName + " 副本"
|
||||
}
|
||||
|
||||
existing := make(map[string]struct{}, len(kbs))
|
||||
for _, kb := range kbs {
|
||||
if kb == nil {
|
||||
continue
|
||||
}
|
||||
existing[kb.Name] = struct{}{}
|
||||
}
|
||||
|
||||
candidate := baseName + " 副本"
|
||||
if _, ok := existing[candidate]; !ok {
|
||||
return candidate
|
||||
}
|
||||
for i := 2; ; i++ {
|
||||
candidate = fmt.Sprintf("%s 副本 %d", baseName, i)
|
||||
if _, ok := existing[candidate]; !ok {
|
||||
return candidate
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func cloneKnowledgeBaseConfiguration(sourceKB *types.KnowledgeBase) (*types.KnowledgeBase, error) {
|
||||
if sourceKB == nil {
|
||||
return nil, apperrors.NewBadRequestError("source knowledge base cannot be empty")
|
||||
}
|
||||
data, err := json.Marshal(sourceKB)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
var targetKB types.KnowledgeBase
|
||||
if err := json.Unmarshal(data, &targetKB); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return &targetKB, nil
|
||||
}
|
||||
|
||||
@@ -95,8 +95,14 @@ func (r *fakeKBRepo) GetKnowledgeBaseByIDs(_ context.Context, _ []string) ([]*ty
|
||||
func (r *fakeKBRepo) ListKnowledgeBases(_ context.Context) ([]*types.KnowledgeBase, error) {
|
||||
return nil, nil
|
||||
}
|
||||
func (r *fakeKBRepo) ListKnowledgeBasesByTenantID(_ context.Context, _ uint64) ([]*types.KnowledgeBase, error) {
|
||||
return nil, nil
|
||||
func (r *fakeKBRepo) ListKnowledgeBasesByTenantID(_ context.Context, tenantID uint64) ([]*types.KnowledgeBase, error) {
|
||||
rows := make([]*types.KnowledgeBase, 0, len(r.rows))
|
||||
for _, kb := range r.rows {
|
||||
if kb != nil && kb.TenantID == tenantID {
|
||||
rows = append(rows, kb)
|
||||
}
|
||||
}
|
||||
return rows, nil
|
||||
}
|
||||
func (r *fakeKBRepo) UpdateKnowledgeBase(_ context.Context, _ *types.KnowledgeBase) error {
|
||||
return nil
|
||||
@@ -365,3 +371,112 @@ func TestCopyKnowledgeBase_Defenses(t *testing.T) {
|
||||
assert.Contains(t, err.Error(), "different vector stores")
|
||||
})
|
||||
}
|
||||
|
||||
func TestDuplicateKnowledgeBase_CreatesSettingsOnlyDuplicate(t *testing.T) {
|
||||
repo := newFakeKBRepo()
|
||||
source := &types.KnowledgeBase{
|
||||
ID: "src",
|
||||
Name: "Source KB",
|
||||
Type: types.KnowledgeBaseTypeDocument,
|
||||
Description: "source description",
|
||||
TenantID: 1,
|
||||
CreatorID: "source-owner",
|
||||
IsTemporary: true,
|
||||
ChunkingConfig: types.ChunkingConfig{
|
||||
ChunkSize: 800,
|
||||
ChunkOverlap: 80,
|
||||
Separators: []string{"\n\n", "."},
|
||||
ParserEngineRules: []types.ParserEngineRule{{
|
||||
FileTypes: []string{"pdf"},
|
||||
Engine: "docreader",
|
||||
}},
|
||||
},
|
||||
ImageProcessingConfig: types.ImageProcessingConfig{ModelID: "vlm-image"},
|
||||
EmbeddingModelID: "embed-1",
|
||||
SummaryModelID: "summary-1",
|
||||
VLMConfig: types.VLMConfig{Enabled: true, ModelID: "vlm-1"},
|
||||
ASRConfig: types.ASRConfig{Enabled: true, ModelID: "asr-1", Language: "zh"},
|
||||
StorageProviderConfig: &types.StorageProviderConfig{Provider: "local"},
|
||||
ExtractConfig: &types.ExtractConfig{
|
||||
Enabled: true,
|
||||
Text: "extract entities",
|
||||
Tags: []string{"product"},
|
||||
Nodes: []*types.GraphNode{{Name: "Product"}},
|
||||
},
|
||||
QuestionGenerationConfig: &types.QuestionGenerationConfig{Enabled: true, QuestionCount: 5},
|
||||
WikiConfig: &types.WikiConfig{SynthesisModelID: "wiki-llm", MaxPagesPerIngest: 12},
|
||||
IndexingStrategy: types.IndexingStrategy{
|
||||
VectorEnabled: true,
|
||||
KeywordEnabled: true,
|
||||
WikiEnabled: true,
|
||||
GraphEnabled: true,
|
||||
},
|
||||
IsPinned: true,
|
||||
KnowledgeCount: 9,
|
||||
ChunkCount: 27,
|
||||
IsProcessing: true,
|
||||
ProcessingCount: 2,
|
||||
ShareCount: 3,
|
||||
CreatorName: "Source Owner",
|
||||
}
|
||||
repo.rows["src"] = source
|
||||
svc := newPR3KBService(repo, &fakeRegistry{}, &fakeOwnership{})
|
||||
ctx := context.WithValue(ctxWithTenant(1), types.UserIDContextKey, "copy-user")
|
||||
|
||||
target, err := svc.DuplicateKnowledgeBase(ctx, "src", "copy-id")
|
||||
require.NoError(t, err)
|
||||
|
||||
require.Equal(t, "copy-id", target.ID)
|
||||
assert.Equal(t, uint64(1), target.TenantID)
|
||||
assert.Equal(t, "copy-user", target.CreatorID)
|
||||
assert.Equal(t, "Source KB 副本", target.Name)
|
||||
assert.Equal(t, source.Description, target.Description)
|
||||
assert.Equal(t, source.ChunkingConfig, target.ChunkingConfig)
|
||||
assert.Equal(t, source.ImageProcessingConfig, target.ImageProcessingConfig)
|
||||
assert.Equal(t, source.EmbeddingModelID, target.EmbeddingModelID)
|
||||
assert.Equal(t, source.SummaryModelID, target.SummaryModelID)
|
||||
assert.Equal(t, source.VLMConfig, target.VLMConfig)
|
||||
assert.Equal(t, source.ASRConfig, target.ASRConfig)
|
||||
require.NotNil(t, target.StorageProviderConfig)
|
||||
assert.Equal(t, "local", target.StorageProviderConfig.Provider)
|
||||
require.NotNil(t, target.ExtractConfig)
|
||||
assert.Equal(t, source.ExtractConfig.Text, target.ExtractConfig.Text)
|
||||
require.NotNil(t, target.QuestionGenerationConfig)
|
||||
assert.Equal(t, 5, target.QuestionGenerationConfig.QuestionCount)
|
||||
require.NotNil(t, target.WikiConfig)
|
||||
assert.Equal(t, "wiki-llm", target.WikiConfig.SynthesisModelID)
|
||||
assert.Equal(t, source.IndexingStrategy, target.IndexingStrategy)
|
||||
|
||||
assert.False(t, target.IsTemporary)
|
||||
assert.False(t, target.IsPinned)
|
||||
assert.Nil(t, target.PinnedAt)
|
||||
assert.Zero(t, target.KnowledgeCount)
|
||||
assert.Zero(t, target.ChunkCount)
|
||||
assert.False(t, target.IsProcessing)
|
||||
assert.Zero(t, target.ProcessingCount)
|
||||
assert.Zero(t, target.ShareCount)
|
||||
assert.Empty(t, target.CreatorName)
|
||||
require.Same(t, target, repo.rows["copy-id"])
|
||||
}
|
||||
|
||||
func TestDuplicateKnowledgeBase_UsesDistinctNameWhenDuplicateExists(t *testing.T) {
|
||||
repo := newFakeKBRepo()
|
||||
repo.rows["src"] = &types.KnowledgeBase{
|
||||
ID: "src",
|
||||
Name: "Source KB",
|
||||
Type: types.KnowledgeBaseTypeDocument,
|
||||
TenantID: 1,
|
||||
}
|
||||
repo.rows["existing-copy"] = &types.KnowledgeBase{
|
||||
ID: "existing-copy",
|
||||
Name: "Source KB 副本",
|
||||
Type: types.KnowledgeBaseTypeDocument,
|
||||
TenantID: 1,
|
||||
}
|
||||
svc := newPR3KBService(repo, &fakeRegistry{}, &fakeOwnership{})
|
||||
|
||||
target, err := svc.DuplicateKnowledgeBase(ctxWithTenant(1), "src", "copy-id")
|
||||
require.NoError(t, err)
|
||||
|
||||
assert.Equal(t, "Source KB 副本 2", target.Name)
|
||||
}
|
||||
|
||||
@@ -936,6 +936,17 @@ type CopyKnowledgeBaseResponse struct {
|
||||
Message string `json:"message"`
|
||||
}
|
||||
|
||||
type DuplicateKnowledgeBaseRequest struct {
|
||||
TargetID string `json:"target_id"`
|
||||
}
|
||||
|
||||
type DuplicateKnowledgeBaseResponse struct {
|
||||
SourceID string `json:"source_id"`
|
||||
TargetID string `json:"target_id"`
|
||||
Message string `json:"message"`
|
||||
KnowledgeBase interface{} `json:"knowledge_base"`
|
||||
}
|
||||
|
||||
// CopyKnowledgeBase godoc
|
||||
// @Summary 复制知识库
|
||||
// @Description 将一个知识库的内容复制到另一个知识库(异步任务)
|
||||
@@ -1114,6 +1125,80 @@ func (h *KnowledgeBaseHandler) CopyKnowledgeBase(c *gin.Context) {
|
||||
})
|
||||
}
|
||||
|
||||
// DuplicateKnowledgeBase godoc
|
||||
// @Summary 创建知识库副本
|
||||
// @Description 创建一个只包含设置的新知识库副本,不复制知识、FAQ 内容、分块、索引、Wiki 页面、分享或置顶状态
|
||||
// @Tags 知识库
|
||||
// @Accept json
|
||||
// @Produce json
|
||||
// @Param id path string true "源知识库 ID"
|
||||
// @Param request body DuplicateKnowledgeBaseRequest false "创建副本请求"
|
||||
// @Success 201 {object} map[string]interface{} "创建后的知识库副本"
|
||||
// @Failure 400 {object} errors.AppError "请求参数错误"
|
||||
// @Security Bearer
|
||||
// @Router /knowledge-bases/{id}/duplicate [post]
|
||||
func (h *KnowledgeBaseHandler) DuplicateKnowledgeBase(c *gin.Context) {
|
||||
ctx := c.Request.Context()
|
||||
sourceID := c.Param("id")
|
||||
if sourceID == "" {
|
||||
c.Error(apperrors.NewBadRequestError("Knowledge base ID cannot be empty"))
|
||||
return
|
||||
}
|
||||
var req DuplicateKnowledgeBaseRequest
|
||||
if c.Request.Body != nil && c.Request.ContentLength != 0 {
|
||||
if err := c.ShouldBindJSON(&req); err != nil {
|
||||
c.Error(apperrors.NewBadRequestError("Invalid request parameters").WithDetails(err.Error()))
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
callerTenantID := c.GetUint64(types.TenantIDContextKey.String())
|
||||
sourceKB, err := h.service.GetKnowledgeBaseByID(ctx, sourceID)
|
||||
if err != nil {
|
||||
if stderrors.Is(err, repository.ErrKnowledgeBaseNotFound) {
|
||||
c.Error(errors.NewNotFoundError("Source knowledge base not found"))
|
||||
return
|
||||
}
|
||||
logger.ErrorWithFields(ctx, err, nil)
|
||||
c.Error(errors.NewInternalServerError(err.Error()))
|
||||
return
|
||||
}
|
||||
if sourceKB.TenantID != callerTenantID {
|
||||
logger.Warnf(ctx,
|
||||
"Knowledge base duplicate rejected: source belongs to another tenant, source_id: %s, caller_tenant: %d, kb_tenant: %d",
|
||||
secutils.SanitizeForLog(sourceID), callerTenantID, sourceKB.TenantID)
|
||||
c.Error(errors.NewForbiddenError("No permission to duplicate this knowledge base"))
|
||||
return
|
||||
}
|
||||
|
||||
targetKB, err := h.service.DuplicateKnowledgeBase(ctx, sourceID, req.TargetID)
|
||||
if err != nil {
|
||||
if appErr, ok := apperrors.IsAppError(err); ok {
|
||||
c.Error(appErr)
|
||||
return
|
||||
}
|
||||
if stderrors.Is(err, repository.ErrKnowledgeBaseNotFound) {
|
||||
c.Error(errors.NewNotFoundError("Source knowledge base not found"))
|
||||
return
|
||||
}
|
||||
logger.ErrorWithFields(ctx, err, nil)
|
||||
c.Error(errors.NewInternalServerError(err.Error()))
|
||||
return
|
||||
}
|
||||
|
||||
logger.Infof(ctx, "Knowledge base duplicate created, source: %s, target: %s",
|
||||
secutils.SanitizeForLog(sourceID), secutils.SanitizeForLog(targetKB.ID))
|
||||
c.JSON(http.StatusCreated, gin.H{
|
||||
"success": true,
|
||||
"data": DuplicateKnowledgeBaseResponse{
|
||||
SourceID: sourceID,
|
||||
TargetID: targetKB.ID,
|
||||
Message: "Knowledge base duplicate created",
|
||||
KnowledgeBase: buildKBResponse(targetKB, h.resolveKBStoreView(ctx, targetKB, callerTenantID), nil),
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
// GetKBCloneProgress godoc
|
||||
// @Summary 获取知识库复制进度
|
||||
// @Description 获取知识库复制任务的进度
|
||||
|
||||
@@ -9,50 +9,32 @@ import (
|
||||
|
||||
"github.com/gin-gonic/gin"
|
||||
|
||||
apperrors "github.com/Tencent/WeKnora/internal/errors"
|
||||
"github.com/Tencent/WeKnora/internal/middleware"
|
||||
"github.com/Tencent/WeKnora/internal/types"
|
||||
"github.com/Tencent/WeKnora/internal/types/interfaces"
|
||||
)
|
||||
|
||||
// handler.CopyKnowledgeBase pre-flight tests.
|
||||
//
|
||||
// The async clone worker (service.CopyKnowledgeBase) re-applies the same
|
||||
// embedding-model and store-binding defenses as defense in depth, but the
|
||||
// handler-level pre-flight is the one that surfaces 400 to the API caller
|
||||
// synchronously instead of inside Asynq progress polling. These tests pin
|
||||
// the synchronous behavior so a future refactor that drops the pre-flight
|
||||
// fails loudly here rather than silently degrading UX.
|
||||
|
||||
// stubKBCopyService provides only the two methods the Copy handler reaches
|
||||
// for (GetKnowledgeBaseByID twice). Other interface methods stay nil so any
|
||||
// accidental new call panics rather than silently succeeding.
|
||||
// stubKBCopyService provides only the methods the duplicate handler reaches.
|
||||
// Other interface methods stay embedded so accidental new calls panic in tests.
|
||||
type stubKBCopyService struct {
|
||||
interfaces.KnowledgeBaseService
|
||||
byID func(ctx context.Context, id string) (*types.KnowledgeBase, error)
|
||||
byID func(ctx context.Context, id string) (*types.KnowledgeBase, error)
|
||||
duplicate func(ctx context.Context, sourceID, targetID string) (*types.KnowledgeBase, error)
|
||||
}
|
||||
|
||||
func (s *stubKBCopyService) GetKnowledgeBaseByID(ctx context.Context, id string) (*types.KnowledgeBase, error) {
|
||||
return s.byID(ctx, id)
|
||||
}
|
||||
|
||||
// stubEnqueuer records whether Enqueue was invoked. The whole point of the
|
||||
// pre-flight is to short-circuit *before* enqueue, so the test fails if
|
||||
// enqueue ran for a mismatched clone.
|
||||
type stubEnqueuer struct {
|
||||
calls int
|
||||
func (s *stubKBCopyService) DuplicateKnowledgeBase(
|
||||
ctx context.Context,
|
||||
sourceID string,
|
||||
targetID string,
|
||||
) (*types.KnowledgeBase, error) {
|
||||
return s.duplicate(ctx, sourceID, targetID)
|
||||
}
|
||||
|
||||
func (s *stubEnqueuer) Enqueue(_ interface{}, _ ...interface{}) (*stubEnqueueInfo, error) {
|
||||
s.calls++
|
||||
return &stubEnqueueInfo{ID: "x"}, nil
|
||||
}
|
||||
|
||||
// stubEnqueueInfo is a stand-in for asynq.TaskInfo so the test does not need
|
||||
// to construct one.
|
||||
type stubEnqueueInfo struct{ ID string }
|
||||
|
||||
func newCopyPreflightRouter(svc interfaces.KnowledgeBaseService) (*gin.Engine, *stubEnqueuer) {
|
||||
func newDuplicateRouter(svc interfaces.KnowledgeBaseService) *gin.Engine {
|
||||
gin.SetMode(gin.TestMode)
|
||||
r := gin.New()
|
||||
r.Use(middleware.ErrorHandler())
|
||||
@@ -61,120 +43,75 @@ func newCopyPreflightRouter(svc interfaces.KnowledgeBaseService) (*gin.Engine, *
|
||||
c.Set(types.UserIDContextKey.String(), "u-test")
|
||||
c.Next()
|
||||
})
|
||||
enq := &stubEnqueuer{}
|
||||
// The real handler reaches into h.asynqClient.Enqueue with the asynq
|
||||
// task type. We do not exercise the enqueue path in these tests — every
|
||||
// case here either short-circuits at pre-flight or returns 4xx earlier.
|
||||
// Leaving asynqClient nil would panic if enqueue ran, which is exactly
|
||||
// the regression we want to catch.
|
||||
h := &KnowledgeBaseHandler{service: svc}
|
||||
r.POST("/knowledge-bases/copy", h.CopyKnowledgeBase)
|
||||
return r, enq
|
||||
r.POST("/knowledge-bases/:id/duplicate", h.DuplicateKnowledgeBase)
|
||||
return r
|
||||
}
|
||||
|
||||
func storeIDPtr(s string) *string { return &s }
|
||||
|
||||
func TestCopyHandlerPreflight_DifferentEmbeddingModel(t *testing.T) {
|
||||
func TestDuplicateHandler_ReturnsCreatedKnowledgeBase(t *testing.T) {
|
||||
var gotSourceID, gotTargetID string
|
||||
svc := &stubKBCopyService{
|
||||
byID: func(_ context.Context, id string) (*types.KnowledgeBase, error) {
|
||||
switch id {
|
||||
case "src":
|
||||
return &types.KnowledgeBase{
|
||||
ID: "src", TenantID: 1, EmbeddingModelID: "embed-A",
|
||||
}, nil
|
||||
case "dst":
|
||||
return &types.KnowledgeBase{
|
||||
ID: "dst", TenantID: 1, EmbeddingModelID: "embed-B",
|
||||
}, nil
|
||||
if id != "src" {
|
||||
t.Fatalf("handler should only load the source KB, got id=%s", id)
|
||||
}
|
||||
return nil, nil
|
||||
return &types.KnowledgeBase{ID: "src", TenantID: 1, Name: "Source"}, nil
|
||||
},
|
||||
duplicate: func(_ context.Context, sourceID, targetID string) (*types.KnowledgeBase, error) {
|
||||
gotSourceID, gotTargetID = sourceID, targetID
|
||||
return &types.KnowledgeBase{
|
||||
ID: "copy-id",
|
||||
TenantID: 1,
|
||||
Name: "Source",
|
||||
CreatorID: "u-test",
|
||||
}, nil
|
||||
},
|
||||
}
|
||||
r, _ := newCopyPreflightRouter(svc)
|
||||
r := newDuplicateRouter(svc)
|
||||
|
||||
w := httptest.NewRecorder()
|
||||
req := httptest.NewRequest(http.MethodPost, "/knowledge-bases/copy",
|
||||
strings.NewReader(`{"source_id":"src","target_id":"dst"}`))
|
||||
req := httptest.NewRequest(http.MethodPost, "/knowledge-bases/src/duplicate",
|
||||
strings.NewReader(`{"target_id":"copy-id"}`))
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
r.ServeHTTP(w, req)
|
||||
|
||||
if w.Code != http.StatusBadRequest {
|
||||
t.Fatalf("expected 400 for embedding-model mismatch, got %d body=%s", w.Code, w.Body.String())
|
||||
if w.Code != http.StatusCreated {
|
||||
t.Fatalf("expected 201 for duplicate, got %d body=%s", w.Code, w.Body.String())
|
||||
}
|
||||
if !strings.Contains(w.Body.String(), "different embedding models") {
|
||||
t.Fatalf("expected embedding-model error message, got %s", w.Body.String())
|
||||
if gotSourceID != "src" || gotTargetID != "copy-id" {
|
||||
t.Fatalf("duplicate service called with source=%q target=%q", gotSourceID, gotTargetID)
|
||||
}
|
||||
body := w.Body.String()
|
||||
for _, want := range []string{`"source_id":"src"`, `"target_id":"copy-id"`, `"knowledge_base"`} {
|
||||
if !strings.Contains(body, want) {
|
||||
t.Fatalf("response missing %s: %s", want, body)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestCopyHandlerPreflight_DifferentVectorStore(t *testing.T) {
|
||||
func TestDuplicateHandler_RejectsCrossTenantSource(t *testing.T) {
|
||||
calledDuplicate := false
|
||||
svc := &stubKBCopyService{
|
||||
byID: func(_ context.Context, id string) (*types.KnowledgeBase, error) {
|
||||
switch id {
|
||||
case "src":
|
||||
return &types.KnowledgeBase{
|
||||
ID: "src", TenantID: 1, EmbeddingModelID: "embed-A",
|
||||
VectorStoreID: storeIDPtr("store-A"),
|
||||
}, nil
|
||||
case "dst":
|
||||
return &types.KnowledgeBase{
|
||||
ID: "dst", TenantID: 1, EmbeddingModelID: "embed-A",
|
||||
VectorStoreID: storeIDPtr("store-B"),
|
||||
}, nil
|
||||
}
|
||||
return &types.KnowledgeBase{ID: id, TenantID: 2, Name: "Shared"}, nil
|
||||
},
|
||||
duplicate: func(_ context.Context, _, _ string) (*types.KnowledgeBase, error) {
|
||||
calledDuplicate = true
|
||||
return nil, nil
|
||||
},
|
||||
}
|
||||
r, _ := newCopyPreflightRouter(svc)
|
||||
r := newDuplicateRouter(svc)
|
||||
|
||||
w := httptest.NewRecorder()
|
||||
req := httptest.NewRequest(http.MethodPost, "/knowledge-bases/copy",
|
||||
strings.NewReader(`{"source_id":"src","target_id":"dst"}`))
|
||||
req := httptest.NewRequest(http.MethodPost, "/knowledge-bases/src/duplicate",
|
||||
strings.NewReader(`{}`))
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
r.ServeHTTP(w, req)
|
||||
|
||||
if w.Code != http.StatusBadRequest {
|
||||
t.Fatalf("expected 400 for store mismatch, got %d body=%s", w.Code, w.Body.String())
|
||||
if w.Code != http.StatusForbidden {
|
||||
t.Fatalf("expected 403 for cross-tenant source, got %d body=%s", w.Code, w.Body.String())
|
||||
}
|
||||
if !strings.Contains(w.Body.String(), "different vector stores") {
|
||||
t.Fatalf("expected store-mismatch error message, got %s", w.Body.String())
|
||||
}
|
||||
if strings.Contains(w.Body.String(), "Phase 4") {
|
||||
t.Fatalf("error message must not leak internal roadmap labels: %s", w.Body.String())
|
||||
if calledDuplicate {
|
||||
t.Fatal("duplicate service must not be called when source KB is outside the caller tenant")
|
||||
}
|
||||
}
|
||||
|
||||
func TestCopyHandlerPreflight_OneSideNilStore(t *testing.T) {
|
||||
svc := &stubKBCopyService{
|
||||
byID: func(_ context.Context, id string) (*types.KnowledgeBase, error) {
|
||||
switch id {
|
||||
case "src":
|
||||
return &types.KnowledgeBase{
|
||||
ID: "src", TenantID: 1, EmbeddingModelID: "embed-A",
|
||||
VectorStoreID: nil,
|
||||
}, nil
|
||||
case "dst":
|
||||
return &types.KnowledgeBase{
|
||||
ID: "dst", TenantID: 1, EmbeddingModelID: "embed-A",
|
||||
VectorStoreID: storeIDPtr("store-A"),
|
||||
}, nil
|
||||
}
|
||||
return nil, nil
|
||||
},
|
||||
}
|
||||
r, _ := newCopyPreflightRouter(svc)
|
||||
|
||||
w := httptest.NewRecorder()
|
||||
req := httptest.NewRequest(http.MethodPost, "/knowledge-bases/copy",
|
||||
strings.NewReader(`{"source_id":"src","target_id":"dst"}`))
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
r.ServeHTTP(w, req)
|
||||
|
||||
if w.Code != http.StatusBadRequest {
|
||||
t.Fatalf("expected 400 when one side is env-store and the other is DB-store, got %d body=%s",
|
||||
w.Code, w.Body.String())
|
||||
}
|
||||
}
|
||||
|
||||
// compile-time guard against accidentally dropping the apperrors import
|
||||
// from the file — if the pre-flight refactor goes away, this fails too.
|
||||
var _ = apperrors.NewBadRequestError
|
||||
|
||||
@@ -428,6 +428,8 @@ func RegisterKnowledgeBaseRoutes(r *gin.RouterGroup, handler *handler.KnowledgeB
|
||||
kb.GET("/:id/hybrid-search", g.Viewer(), g.KBAccessRead("id"), handler.HybridSearch)
|
||||
// 拷贝知识库 — Contributor+ (副本归调用者所有;不需要原 KB 的所有权)
|
||||
kbgrp.POST("/copy", g.Contributor(), handler.CopyKnowledgeBase)
|
||||
// 创建知识库副本 — Contributor+ 且对源 KB 有 read 权限;只创建新的 KB 设置记录,不复制内容/索引/分享。
|
||||
kbgrp.POST("/:id/duplicate", g.Contributor(), g.KBAccessRead("id"), handler.DuplicateKnowledgeBase)
|
||||
// 获取知识库复制进度 — Viewer+
|
||||
kb.GET("/copy/progress/:task_id", g.Viewer(), handler.GetKBCloneProgress)
|
||||
// 获取可移动目标知识库列表 — Viewer+ 且对 KB 有 read 权限
|
||||
|
||||
@@ -179,7 +179,7 @@ func TestKnowledgeBaseManagementRoutesDeclareManageKBsCapability(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestKnowledgeBaseCreateAndCopyRemainDefaultDenyForAPIKeys(t *testing.T) {
|
||||
func TestKnowledgeBaseCreateAndCopyRoutesRemainDefaultDenyForAPIKeys(t *testing.T) {
|
||||
gin.SetMode(gin.TestMode)
|
||||
g := &rbacGuards{}
|
||||
v1 := gin.New().Group("/api/v1")
|
||||
@@ -192,6 +192,7 @@ func TestKnowledgeBaseCreateAndCopyRemainDefaultDenyForAPIKeys(t *testing.T) {
|
||||
}{
|
||||
{http.MethodPost, "/api/v1/knowledge-bases"},
|
||||
{http.MethodPost, "/api/v1/knowledge-bases/copy"},
|
||||
{http.MethodPost, "/api/v1/knowledge-bases/:id/duplicate"},
|
||||
}
|
||||
|
||||
for _, tc := range cases {
|
||||
|
||||
@@ -116,6 +116,12 @@ type KnowledgeBaseService interface {
|
||||
// - Possible errors such as not existing, insufficient permissions, etc.
|
||||
CopyKnowledgeBase(ctx context.Context, src string, dst string) (*types.KnowledgeBase, *types.KnowledgeBase, error)
|
||||
|
||||
// DuplicateKnowledgeBase creates a new settings-only knowledge base duplicate.
|
||||
// It does not copy knowledge entries, chunks, FAQ rows, wiki pages, indexes,
|
||||
// data sources, shares, pins, or task state. targetID is optional; when empty
|
||||
// a new UUID is generated.
|
||||
DuplicateKnowledgeBase(ctx context.Context, src string, targetID string) (*types.KnowledgeBase, error)
|
||||
|
||||
// GetRepository gets the knowledge base repository
|
||||
// Parameters:
|
||||
// - ctx: Context with authentication and request information
|
||||
|
||||
Reference in New Issue
Block a user