fix(memory): dedupe episode write on duplicate streaming Done

AgentFinalAnswer may carry Done:true more than once (e.g. finish chunk
plus EOF). Guard AddEpisode with sync.Once so memory persists once per
turn, consistent with qa.go completion handling.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Andy Yang
2026-05-03 22:31:10 +08:00
committed by lyingbug
parent 48aeafcc3f
commit 3d94a476bf
@@ -3,6 +3,7 @@ package chatpipeline
import (
"context"
"fmt"
"sync"
"github.com/Tencent/WeKnora/internal/event"
"github.com/Tencent/WeKnora/internal/logger"
@@ -118,6 +119,7 @@ func (p *MemoryPlugin) handleStorage(
// If streaming, subscribe to events
if chatManage.EventBus != nil {
var fullResponse string
var storeOnce sync.Once
userID := chatManage.UserID
sessionID := chatManage.SessionID
bgCtx := context.WithoutCancel(ctx)
@@ -129,15 +131,19 @@ func (p *MemoryPlugin) handleStorage(
}
fullResponse += data.Content
if data.Done {
messages := []types.Message{
{Role: "user", Content: chatManage.Query},
{Role: "assistant", Content: fullResponse},
}
go func() {
if err := p.memoryService.AddEpisode(bgCtx, userID, sessionID, messages); err != nil {
logger.Errorf(bgCtx, "failed to add episode: %v", err)
// Stream layer may emit Done:true twice (e.g. finish_reason chunk + EOF sentinel).
// qa.go dedupes with completionHandled; keep memory writes consistent with one episode only.
storeOnce.Do(func() {
messages := []types.Message{
{Role: "user", Content: chatManage.Query},
{Role: "assistant", Content: fullResponse},
}
}()
go func() {
if err := p.memoryService.AddEpisode(bgCtx, userID, sessionID, messages); err != nil {
logger.Errorf(bgCtx, "failed to add episode: %v", err)
}
}()
})
}
return nil
})