feat: Implement deadlock retry mechanism for chunk creation

Added a new utility function, WithDeadlockRetry, to handle MySQL deadlock errors during chunk creation. This function retries the operation up to three times with exponential backoff. Updated the CreateChunks method to utilize this new function, ensuring robust handling of concurrent write scenarios and preventing potential deadlocks. Additionally, improved documentation for CreateChunks to clarify the use of Omit for avoiding auto-increment column issues.
This commit is contained in:
wizardchen
2026-04-07 17:02:29 +08:00
parent 749e8a0a19
commit 33da010605
2 changed files with 51 additions and 1 deletions
+6 -1
View File
@@ -24,7 +24,12 @@ func NewChunkRepository(db *gorm.DB) interfaces.ChunkRepository {
return &chunkRepository{db: db}
}
// CreateChunks creates multiple chunks in batches
// CreateChunks creates multiple chunks in batches.
// Uses Omit("SeqID") so GORM won't include the auto-increment column in the
// INSERT, which avoids MySQL generating ON DUPLICATE KEY UPDATE and the
// resulting gap-lock deadlocks under concurrent writes.
// A deadlock retry wrapper is kept as defense-in-depth for any remaining
// edge cases on secondary unique indexes.
func (r *chunkRepository) CreateChunks(ctx context.Context, chunks []*types.Chunk) error {
for _, chunk := range chunks {
chunk.Content = common.CleanInvalidUTF8(chunk.Content)
+45
View File
@@ -0,0 +1,45 @@
package common
import (
"context"
"strings"
"time"
"github.com/Tencent/WeKnora/internal/logger"
)
const defaultMaxDeadlockRetries = 3
// WithDeadlockRetry retries fn when MySQL returns Error 1213 (deadlock).
// Retries up to 3 times with exponential backoff (50ms, 100ms, 200ms).
// Safe for all DB drivers — non-deadlock errors are returned immediately.
func WithDeadlockRetry(ctx context.Context, fn func() error) error {
var err error
for attempt := 0; attempt <= defaultMaxDeadlockRetries; attempt++ {
err = fn()
if err == nil || !IsDeadlockError(err) {
return err
}
if attempt < defaultMaxDeadlockRetries {
wait := time.Duration(50<<attempt) * time.Millisecond
logger.Warnf(ctx, "[DeadlockRetry] attempt %d/%d failed with deadlock, retrying in %v: %v",
attempt+1, defaultMaxDeadlockRetries, wait, err)
select {
case <-ctx.Done():
return ctx.Err()
case <-time.After(wait):
}
}
}
return err
}
// IsDeadlockError checks whether err is a MySQL deadlock (Error 1213).
func IsDeadlockError(err error) bool {
if err == nil {
return false
}
msg := err.Error()
return strings.Contains(msg, "Error 1213") ||
strings.Contains(msg, "Deadlock found when trying to get lock")
}