5e1482e349
build / build (push) Successful in 1m40s
根因:生产可恢复性只有 PRODUCTION_BACKUP_RESTORE_VERIFIED 这个手填 env 开关, 页面没有任何入口去真跑一次恢复;CLI(librarydrill)又不是 worker 能复用的实现, 所以"已验证"既证明不了跑过、也证明不了跑的是当前目标。 改动: - 共享实现 internal/libraryverify(维护隔离→捕获→基线校验→canary→恢复→复核→关窗口), cmd/librarydrill 改为薄封装,CLI 与 worker 只允许一份执行体。 - verify 成为独立业务作业:kind + VerifyStages(capture/verify/canary/restore/finalize), 与 sync/restore/baseline 共用同一把写互斥;迁移 79 加 kind 约束、重建部分唯一索引、 新建 library_restore_verifications(按 target_id 绑定,换库/索引/桶旧证据自动失效, 同 target+scope+job 幂等)。 - worker:admitLibraryJob + runOwnedLibraryAttempt 之后调用共享实现,阶段实时写 library_job_stages,结束后写真实终态;通过写 passed 证据,失败写 failed+原因(不伪成功); 中断接管按同一作业 id 收掉维护窗口。 - API:POST/GET /api/v1/library/verifications(管理员;闸口关闭/维护中拒绝;返回完整 整库目标、最近证据、失败原因),OpenAPI 同步。 - 闸口:同步/恢复/续作的证据判断改为读当前目标证据;历史 env 仅在证据缺失时兜底, 证据存在时以证据为准。 - 页面:生产保护与恢复面板加「恢复验证」块(完整 KB/索引/桶、状态、最近证据、失败原因、 管理员按钮、5s 轮询),作业类型补 verify 文案。 测试:make verify 16/16 全绿(go 1387 例 + web 454 例 + 契约/迁移/密钥/依赖锁定); 新增用例覆盖证据四条件、闸口证据优先、页面无证据/失败/通过三种呈现与管理员可见性。
90 lines
3.6 KiB
Go
90 lines
3.6 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
|
|
"knowledge-governance/internal/appconfig"
|
|
"knowledge-governance/internal/jobs"
|
|
postgresstore "knowledge-governance/internal/platform/postgres"
|
|
"knowledge-governance/internal/versionhistory"
|
|
)
|
|
|
|
// 发布执行器必须只挂四类 release 作业:多挂一类就会抢走本机队列里别的执行者的作业。
|
|
func TestRegisterLibraryReleaseHandlersCoversOnlyReleaseJobs(t *testing.T) {
|
|
handlers := map[string]jobs.Handler{}
|
|
registerLibraryReleaseHandlers(handlers, nil, appconfig.Config{}, nil)
|
|
want := []string{librarySyncJobType, libraryRestoreJobType, libraryRecoverJobType,
|
|
libraryBaselineJobType, libraryVerifyJobType}
|
|
if len(handlers) != len(want) {
|
|
t.Fatalf("registered %d handlers, want %d: %#v", len(handlers), len(want), handlers)
|
|
}
|
|
for _, jobType := range want {
|
|
if handlers[jobType] == nil {
|
|
t.Fatalf("handler %q is not registered", jobType)
|
|
}
|
|
}
|
|
}
|
|
|
|
// 准入未通过时 handler 必须"明确失败且不做任何动作":不能靠 nil store 或进程内状态蒙过去。
|
|
func TestRegisterLibraryReleaseHandlersFailsClosedWhenNotAdmitted(t *testing.T) {
|
|
handlers := map[string]jobs.Handler{}
|
|
registerLibraryReleaseHandlers(handlers, nil, appconfig.Config{}, errNotAdmitted{})
|
|
for _, jobType := range []string{librarySyncJobType, libraryRestoreJobType, libraryRecoverJobType,
|
|
libraryBaselineJobType, libraryVerifyJobType} {
|
|
err := handlers[jobType](context.Background(), jobs.Job{})
|
|
if err == nil || !strings.Contains(err.Error(), "准入未通过") {
|
|
t.Fatalf("handler %q error = %v, want admission refusal", jobType, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
type errNotAdmitted struct{}
|
|
|
|
func (errNotAdmitted) Error() string { return "fixture: target instance unknown" }
|
|
|
|
// capture 角色不能注册任何 source 之外的队列;release-executor 反之。
|
|
func TestWorkerHandlersFollowWorkerRole(t *testing.T) {
|
|
release := appconfig.Config{
|
|
LibraryWorkerRole: appconfig.LibraryWorkerRoleReleaseExecutor,
|
|
LibraryAgentSocket: "/run/library-agent/agent.sock",
|
|
TestWeKnoraEnabled: true,
|
|
TestWeKnoraAPIKeyFile: "/nonexistent/api-key",
|
|
PPScanEnabled: true,
|
|
VersionHistoryGiteaBaseURL: "https://gitea.invalid/Weknora/knowledge-governance",
|
|
VersionHistoryAllowedOrigins: []string{"https://gitea.invalid"},
|
|
}
|
|
handlers, err := workerHandlers(postgresstore.NewStore(nil), release)
|
|
if err != nil {
|
|
t.Fatalf("release-executor workerHandlers() error = %v", err)
|
|
}
|
|
for _, forbidden := range []string{libraryCaptureJobType, "test.upload", "test.poll", "test.validate", "test.remove", "source.scan.pp", "source.catalog.refresh", "artifact.fetch", versionhistory.JobType} {
|
|
if handlers[forbidden] != nil {
|
|
t.Fatalf("release-executor registered %q", forbidden)
|
|
}
|
|
}
|
|
if handlers["demo"] == nil {
|
|
t.Fatal("demo handler must stay registered")
|
|
}
|
|
|
|
capture := appconfig.Config{
|
|
LibraryWorkerRole: appconfig.LibraryWorkerRoleCapture,
|
|
LibraryAgentSocket: "/run/library-agent/agent.sock",
|
|
TestWeKnoraEnabled: true,
|
|
TestWeKnoraAPIKeyFile: "/nonexistent/api-key",
|
|
}
|
|
if _, err := workerHandlers(nil, capture); err == nil || !strings.Contains(err.Error(), "test WeKnora API key") {
|
|
t.Fatalf("capture role must reach the test WeKnora wiring, got %v", err)
|
|
}
|
|
capture.TestWeKnoraEnabled = false
|
|
capture.PPScanEnabled = false
|
|
handlers, err = workerHandlers(postgresstore.NewStore(nil), capture)
|
|
if err != nil {
|
|
t.Fatalf("capture workerHandlers() error = %v", err)
|
|
}
|
|
if handlers[libraryCaptureJobType] == nil {
|
|
t.Fatal("capture role must register library.capture")
|
|
}
|
|
}
|