Files
knowledge-governance/internal/libraryagent/swap_test.go
T
姚章浩 6ed06357f9
build / build (push) Successful in 1m27s
fix(library): 期望执行器身份随 capture 请求送达并在执行前核对
原来 worker 先 health 再 capture,两次拨号之间 socket 可能被换成另一个实例的
执行器:错的 agent 已经把写入者停了、快照也出了,事后 postcheck 只能拒绝登记,
副作用无法撤销。

现在 capture 请求自带期望身份(治理侧配置生成:project 必填,source_app /
archive_root 配了就绑定)与覆盖三项的稳定指纹;接收方在操作互斥内、执行任何源
操作之前比对,缺字段、指纹与字段不一致、project/source_app 不符都直接拒绝,
**错的执行器一次 capture 都不跑**。封存结果回显该指纹,worker 事后复核按它对照,
postcheck 只作为证据防线。恢复路径不要求期望(它只把写入者恢复回来)。

负例是确定性的:两个真实 agent 各占一个 socket,把调用方指向错的那个,断言它的
capture 调用为 0 且仍能回答 health;同一份期望打到对的 socket 则只跑一次。
2026-10-29 13:23:56 +08:00

150 lines
5.6 KiB
Go

package libraryagent
import (
"context"
"os"
"strings"
"sync"
"testing"
"time"
)
// unix socket 路径有长度上限,测试目录要用短的(TMPDIR 太深)。
func shortSocketDir(t *testing.T) string {
t.Helper()
dir, err := os.MkdirTemp("/tmp", "kgswap-")
if err != nil {
t.Fatal(err)
}
t.Cleanup(func() { os.RemoveAll(dir) })
return dir
}
// 两个真实 agent、两个 socket:负例把调用方指到"另一个实例"的 socket 上,
// 断言**错误 agent 一次 capture 都没跑**(不是跑完再拒),正例走对 socket 正常封存。
func TestCaptureRequestIsRefusedBeforeAnySourceOperationWhenSocketIsSwapped(t *testing.T) {
rightAgent, rightSocket, rightCalls := agentWithProject(t, "kgmaint-weknora", "kgmaint-app")
wrongAgent, wrongSocket, wrongCalls := agentWithProject(t, "weknora071full", "WKNFull-app")
serveAgent(t, rightAgent, rightSocket)
serveAgent(t, wrongAgent, wrongSocket)
expectation := NewExpectation("kgmaint-weknora", "kgmaint-app", "")
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
// 负例:调用方手上的 socket 已被换成另一个实例的执行器。
result, err := Capture(ctx, ClientConfig{Socket: wrongSocket, Timeout: 5 * time.Second},
"internal", "lib-swap", expectation)
if err == nil || result.OK {
t.Fatalf("capture against the wrong executor was accepted: %+v", result)
}
if !strings.Contains(result.Error, "期望") {
t.Fatalf("refusal should name the mismatch: %q", result.Error)
}
if calls := captureCalls(wrongCalls()); len(calls) != 0 {
t.Fatalf("wrong executor ran the capture binary %d time(s): %v", len(calls), calls)
}
// 旁证:错误的执行器进程本身仍然可用(health 正常),拒绝来自身份比对而不是不可达。
health, err := Health(ctx, ClientConfig{Socket: wrongSocket, Timeout: 5 * time.Second})
if err != nil || !health.OK {
t.Fatalf("wrong executor should still answer health: %v %+v", err, health)
}
// 正例:同一份期望打到正确的 socket,正常封存一次。
result, err = Capture(ctx, ClientConfig{Socket: rightSocket, Timeout: 5 * time.Second},
"internal", "lib-swap", expectation)
if err != nil || !result.OK {
t.Fatalf("capture against the right executor failed: %v %+v", err, result)
}
if calls := captureCalls(rightCalls()); len(calls) != 1 {
t.Fatalf("right executor ran %d time(s): %v", len(calls), calls)
}
if calls := captureCalls(wrongCalls()); len(calls) != 0 {
t.Fatalf("wrong executor ran after the positive case: %v", calls)
}
}
// 缺期望、期望指纹对不上、期望里 source_app 不同,都必须 fail closed 且不跑子进程。
func TestCaptureFailsClosedWithoutACompleteExpectation(t *testing.T) {
agent, socket, calls := agentWithProject(t, "kgmaint-weknora", "kgmaint-app")
serveAgent(t, agent, socket)
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
tampered := NewExpectation("kgmaint-weknora", "kgmaint-app", "")
tampered.Project = "someone-else" // 字段改了、指纹没改:请求在半路被改过
cases := []struct {
name string
expectation Expectation
text string
}{
{name: "missing expectation", expectation: Expectation{}, text: "缺少完整的期望执行器身份"},
{name: "tampered expectation", expectation: tampered, text: "缺少完整的期望执行器身份"},
{name: "wrong source app", expectation: NewExpectation("kgmaint-weknora", "WKNFull-app", ""), text: "源容器不一致"},
}
for _, test := range cases {
result, err := Capture(ctx, ClientConfig{Socket: socket, Timeout: 5 * time.Second},
"internal", "lib-"+strings.ReplaceAll(test.name, " ", "-"), test.expectation)
if err == nil || result.OK {
t.Fatalf("%s: accepted %+v", test.name, result)
}
if !strings.Contains(result.Error, test.text) {
t.Fatalf("%s: error %q", test.name, result.Error)
}
}
if calls := captureCalls(calls()); len(calls) != 0 {
t.Fatalf("capture binary ran despite a refused identity: %v", calls)
}
}
// 恢复路径不受期望约束:它只把写入者恢复回来,任何身份都必须能执行。
func TestRecoverStaysAvailableRegardlessOfExpectation(t *testing.T) {
agent, socket, calls := agentWithProject(t, "kgmaint-weknora", "kgmaint-app")
serveAgent(t, agent, socket)
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
result, err := Recover(ctx, ClientConfig{Socket: socket, Timeout: 5 * time.Second})
if err != nil || !result.OK {
t.Fatalf("recover refused: %v %+v", err, result)
}
if len(recoverCalls(calls())) == 0 {
t.Fatal("recover did not run the recovery command")
}
}
// agentWithProject 造一个真实 agent(不跑真命令),返回它自己的调用记录。
func agentWithProject(t *testing.T, project, sourceApp string) (*Agent, string, func() []string) {
t.Helper()
root := shortSocketDir(t)
var mu sync.Mutex
var calls []string
config := Config{
Socket: root + "/agent.sock",
Binary: "/bin/echo",
ArchiveRoot: root + "/library",
JournalRoot: root + "/freeze",
SourceApp: sourceApp,
SourcePG: "pg",
SourceES: "es",
Project: project,
Writers: "app",
NonWriters: "frontend=UI only",
MaxDuration: time.Minute,
Run: func(_ context.Context, name string, args ...string) ([]byte, error) {
mu.Lock()
calls = append(calls, name+" "+strings.Join(args, " "))
mu.Unlock()
return []byte(`{"snapshot_id":"abc","state":"succeeded"}`), nil
},
}
agent, err := New(config)
if err != nil {
t.Fatal(err)
}
return agent, config.Socket, func() []string {
mu.Lock()
defer mu.Unlock()
return append([]string(nil), calls...)
}
}