Files
knowledge-governance/cmd/worker/library_takeover_historical_test.go
T
姚章浩 780ab988c4
build / build (push) Successful in 1m20s
fix(worker): 历史快照恢复接管按作业身份与新授权判定
真实现场 2026-10-30T00:19Z:新恢复作业恢复历史快照 fc595511(已被 0d982f76
顶替),写入 database 后被 SIGKILL;重启接管时 classifyTakeover 只要看到
该快照有 SupersededAt 就判 superseded,没有判这行历史版本属于哪个作业,
把历史那次发布被顶替当成这次作业过期,作业 failed/prebackup,而恢复文案
又写"无需恢复",目标半写且维护锁未释放。

修法:被顶替分支先分清归属——本作业 finalize 成功或版本行属于本作业 ⇒ 仍
拒绝;历史行属于别的作业时,仅当本次是 restore、授权签发于顶替之后、scope
与 instance 两把锁仍由本作业独占且指纹一致、预备份登记属于本作业且清单字节
仍等于摘要,才按 fresh 继续重跑整条链路。任一证据缺失/读不到仍拒绝。

同时把续作早退统一走 failLibraryJobOrTakeover:有持久化预备份时保留
needs_restore 并点名 backup,不再写"无需恢复"。

验证:
- 先写失败回归(历史行+新授权 ⇒ 期望 fresh,实得 superseded),修后绿;
- 真实 PostgreSQL 正负例:授权撤销/实例锁释放/预备份归属被改/清单字节被改
  均回到 superseded;续作早退保留备份与 needs_restore;
- 本地 make verify 16 项必需检查全绿(identity 本地档案跳过)。
2026-10-30 08:51:07 +08:00

91 lines
5.0 KiB
Go

package main
import (
"testing"
"time"
"knowledge-governance/internal/governance"
)
// 回归:新恢复作业的目标快照是"历史版本"(另一作业发布过,后来被更新的版本顶替)。
// 作业在写 database 之后被杀,重启接管时这一行仍是 superseded——
// 但那是**别的作业**的历史,不是本作业过期。只要这次恢复是顶替之后新授权的、
// 维护窗口仍由本作业独占、预备份基线未变,就必须继续(fresh),不能拒绝。
//
// 反过来:本作业自己完成过(版本行归属自己或 finalize 成功)后被后续版本替换,
// 或缺少授权/维护/基线任一证据,都必须继续拒绝——删掉 superseded 判断是另一种事故。
func TestClassifyTakeoverHistoricalRestoreAfterSupersede(t *testing.T) {
supersededAt := time.Now().UTC().Add(-time.Hour)
job := governance.LibraryJob{ID: "librestore-internal-historical", Scope: "internal",
Kind: governance.LibraryJobRestore, TargetSnapshotID: "snap-historical", SnapshotID: "snap-prebackup",
Stages: []governance.LibraryStage{{Stage: "database", State: "running"}}}
finalized := job
finalized.Stages = append(append([]governance.LibraryStage{}, job.Stages...),
governance.LibraryStage{Stage: "finalize", State: "succeeded"})
// 历史生效行属于别的作业,且已被更新版本顶替;当前生效版本不是本目标快照。
factsBy := func(snapshotOwner string) libraryVersionFacts {
return libraryVersionFacts{
HasCurrent: true,
Current: governance.LibraryVersion{Kind: governance.LibraryVersionProductionEffective,
SnapshotID: "snap-newer", SourceJobID: "librestore-internal-newer"},
HasSnapshot: true,
Snapshot: governance.LibraryVersion{Kind: governance.LibraryVersionProductionEffective,
SnapshotID: "snap-historical", SourceJobID: snapshotOwner, SupersededAt: &supersededAt},
}
}
resume := takeoverResumeFacts{AuthorizedAt: supersededAt.Add(time.Minute),
MaintenanceOwned: true, BaselineRecorded: true, BaselineVerified: true}
cases := []struct {
name string
job governance.LibraryJob
facts libraryVersionFacts
resume takeoverResumeFacts
want takeoverKind
}{
{"foreign historical row + new authorized restore + held window + intact baseline",
job, factsBy("libsync-internal-original"), resume, takeoverFresh},
// 授权必须晚于顶替:顶替前签的授权不能当作"知道这是历史版本"的新意图。
{"authorization issued before supersede",
job, factsBy("libsync-internal-original"),
takeoverResumeFacts{AuthorizedAt: supersededAt.Add(-time.Minute), MaintenanceOwned: true,
BaselineRecorded: true, BaselineVerified: true}, takeoverSuperseded},
{"no authorization", job, factsBy("libsync-internal-original"),
takeoverResumeFacts{MaintenanceOwned: true, BaselineRecorded: true, BaselineVerified: true}, takeoverSuperseded},
{"window not owned by this job", job, factsBy("libsync-internal-original"),
takeoverResumeFacts{AuthorizedAt: resume.AuthorizedAt, BaselineRecorded: true, BaselineVerified: true}, takeoverSuperseded},
{"prebackup row missing or owned by another job", job, factsBy("libsync-internal-original"),
takeoverResumeFacts{AuthorizedAt: resume.AuthorizedAt, MaintenanceOwned: true, BaselineVerified: true}, takeoverSuperseded},
{"prebackup manifest changed", job, factsBy("libsync-internal-original"),
takeoverResumeFacts{AuthorizedAt: resume.AuthorizedAt, MaintenanceOwned: true, BaselineRecorded: true}, takeoverSuperseded},
// 本作业自己的生效登记被顶替 ⇒ 本次作业曾经完成,生产已被更新版本取代。
{"own effective row superseded", job, factsBy(job.ID), resume, takeoverSuperseded},
// finalize 阶段成功是独立的完成证据:即使版本归属被改写也拒绝。
{"finalize succeeded then superseded", finalized, factsBy("libsync-internal-original"), resume, takeoverSuperseded},
// 恢复专属:同步没有"恢复历史版本"业务,不能借这条分支。
{"sync with all resume facts", func() governance.LibraryJob { j := job; j.Kind = governance.LibraryJobSync; return j }(),
factsBy("libsync-internal-original"), resume, takeoverSuperseded},
{"superseded row but current version unreadable", job, func() libraryVersionFacts {
f := factsBy("libsync-internal-original")
f.HasCurrent = false
f.Current = governance.LibraryVersion{}
return f
}(), resume, takeoverSuperseded},
// 台账自相矛盾(已顶替却仍是当前生效)优先判未知,不许继续写。
{"superseded row is also current", job, func() libraryVersionFacts {
f := factsBy("libsync-internal-original")
f.Current.SnapshotID = job.TargetSnapshotID
f.Current.SourceJobID = "libsync-internal-original"
return f
}(), resume, takeoverUnknown},
}
for _, test := range cases {
t.Run(test.name, func(t *testing.T) {
if got := classifyTakeover(test.job, test.facts, test.resume); got != test.want {
t.Fatalf("classify = %q, want %q", got, test.want)
}
})
}
}