a7d643635a
build / build (push) Successful in 1m27s
R1 维护/发布守卫硬编码 j.id=$1:维护类入口的 $1 是 scope/instance,作业号在 $2, 导致 update/release/ingress 六个入口正常路径全部匹配不到作业。改为按被更新行自己的 owner_job_id 生成条件,并同时要求该代次在 library_attempts 里仍活跃。 R2 认领只改 jobs.attempt_epoch 不改 attempts.epoch,第二次接管即错位;唯一索引 (job_id) 与"每次接管新 attempt 且历史不可变"矛盾。改为同作业多代次:锁作业行与 operation 行、同 owner 幂等续租、活跃未过期者让路、过期/本作业旧代次标 abandoned、 新代次 epoch=max+1,并清同 operation 其它作业行租约。迟到 write/renew/finish 一律 ErrLibraryEpochStale(finish 补了"只能在活跃态进来一次")。 R3 续作不再新建 -resume 作业:PrepareLibraryJobResume 让原业务作业回 pending 并显式 结束上一代,维护窗口/journal/预备份/写集合仍按原作业 id 归属,代次由 worker 起手递增。 R4 执行域准入改为注册 handler 前读事实:目标实况(KB/租户/schema/索引)、旧 release 路由绑定的 KB、未释放维护窗口持有者;未知或重叠即拒绝执行(不做维护动作、不停既有服务)。 同时自纠 5 项设计偏离:current 次序键取意图创建时间(旧意图迟到事实被拒)、首次锚点 改事务 FOR UPDATE + 回读且 NULL≠0、版本事件冲突只做加法且 xmax=0 才算新事实、 恢复作为新 kind=recover 意图推进 current、隔离测试加测试库护栏并清理残留 schema。 测试:真实 PG(kg-pgtest-writeset,一用例一 schema)新增 8 条集成用例覆盖上述正负例; go test ./... 全绿(50 包)、go vet/build rc=0、web tsc + vitest 485 通过、make verify 16 项通过。
115 lines
5.7 KiB
Go
115 lines
5.7 KiB
Go
package main
|
||
|
||
import (
|
||
"context"
|
||
"testing"
|
||
"time"
|
||
|
||
"knowledge-governance/internal/governance"
|
||
"knowledge-governance/internal/libraryrelease"
|
||
)
|
||
|
||
// 接管复用的预备份必须是"同一份、且登记时刻不被洗掉":
|
||
// 崩溃后又重做一次备份会把半写状态当成可回滚基线,而 created_at 被重写
|
||
// 会让这两种情况在库里长得一模一样(演练脚本就判不出来了)。
|
||
//
|
||
// 只能在真实 PostgreSQL 上证明:这条语义写在 RecordLibraryVersion 的 upsert 里。
|
||
func TestPrebackupVersionKeepsFirstRegistrationTimeOnReuse(t *testing.T) {
|
||
store, _ := openLedgerStore(t)
|
||
ctx := context.Background()
|
||
const scope = "internal"
|
||
const snapshot = "snap-prebackup-reused"
|
||
|
||
first := time.Now().UTC().Add(-30 * time.Minute).Truncate(time.Second)
|
||
record := func(at time.Time, evidence map[string]any) {
|
||
t.Helper()
|
||
if err := store.RecordLibraryVersion(ctx, governance.LibraryVersion{
|
||
ID: governance.LibraryVersionID(governance.LibraryVersionProductionPrebackup, scope, snapshot),
|
||
Scope: scope, Kind: governance.LibraryVersionProductionPrebackup, SnapshotID: snapshot,
|
||
SourceJobID: "librestore-internal-resumed", CreatedBy: "worker",
|
||
Evidence: evidence, CreatedAt: at,
|
||
}); err != nil {
|
||
t.Fatalf("record prebackup at %s: %v", at, err)
|
||
}
|
||
}
|
||
record(first, map[string]any{"backup_snapshot": snapshot, "backup_bytes": 2048})
|
||
|
||
// 接管复用:BackupPrepared 会再登记一次(带 backup_reused),时刻是"现在"。
|
||
record(time.Now().UTC(), map[string]any{"backup_snapshot": snapshot, "backup_bytes": 2048,
|
||
"backup_reused": true})
|
||
|
||
version, found, err := store.LibraryVersionByRef(ctx, scope, governance.LibraryVersionProductionPrebackup,
|
||
"librestore-internal-resumed", snapshot)
|
||
if err != nil || !found {
|
||
t.Fatalf("read prebackup version: found=%t err=%v", found, err)
|
||
}
|
||
if !version.CreatedAt.UTC().Equal(first) {
|
||
t.Fatalf("复用后登记时刻被改写:%s, want %s(备份什么时候拍的被洗掉了)",
|
||
version.CreatedAt.UTC(), first)
|
||
}
|
||
if reused, _ := version.Evidence["backup_reused"].(bool); !reused {
|
||
t.Fatalf("复用的预览份没有 backup_reused=true:%v", version.Evidence)
|
||
}
|
||
|
||
// 反例对照:真的"重新生效"是**新的意图**(新的作业/新的 operation),
|
||
// 它带自己的登记时刻;同一意图里的重复登记则只补证据、时刻不变。
|
||
// 这条区分必须成立,否则页面会把"最近一次生效"显示成很早以前。
|
||
const effectiveSnap = "snap-effective-reactivated"
|
||
effectiveAt := first.Add(time.Hour)
|
||
reactivatedAt := effectiveAt.Add(time.Hour)
|
||
opFirst := testLibraryOperation(t, store, scope, governance.LibraryJobSync, "activate-1", effectiveAt)
|
||
recordVersionEvent(t, store, scope, governance.LibraryVersionProductionEffective, effectiveSnap,
|
||
"librestore-internal-reactivate-1", opFirst, effectiveAt, map[string]any{"action": "restore"})
|
||
// 同一意图内的重复登记:时刻不变(事件不可变)。
|
||
recordVersionEvent(t, store, scope, governance.LibraryVersionProductionEffective, effectiveSnap,
|
||
"librestore-internal-reactivate-1", opFirst, reactivatedAt, map[string]any{"action": "restore"})
|
||
effective, found, err := store.LibraryVersionByRef(ctx, scope, governance.LibraryVersionProductionEffective,
|
||
"librestore-internal-reactivate-1", effectiveSnap)
|
||
if err != nil || !found {
|
||
t.Fatalf("read effective version: found=%t err=%v", found, err)
|
||
}
|
||
if !effective.CreatedAt.UTC().Equal(effectiveAt) {
|
||
t.Fatalf("同一意图的重复登记改写了时刻:%s, want %s", effective.CreatedAt.UTC(), effectiveAt)
|
||
}
|
||
// 新的意图(另一个作业)重新激活同一快照:新事件、新时刻、成为当前。
|
||
opSecond := testLibraryOperation(t, store, scope, governance.LibraryJobSync, "activate-2", reactivatedAt)
|
||
recordVersionEvent(t, store, scope, governance.LibraryVersionProductionEffective, effectiveSnap,
|
||
"librestore-internal-reactivate-2", opSecond, reactivatedAt, map[string]any{"action": "restore"})
|
||
reactivated, found, err := store.LibraryVersionByRef(ctx, scope,
|
||
governance.LibraryVersionProductionEffective, "librestore-internal-reactivate-2", effectiveSnap)
|
||
if err != nil || !found {
|
||
t.Fatalf("read reactivated version: found=%t err=%v", found, err)
|
||
}
|
||
if !reactivated.CreatedAt.UTC().Equal(reactivatedAt) {
|
||
t.Fatalf("重新激活的登记时刻 = %s, want %s", reactivated.CreatedAt.UTC(), reactivatedAt)
|
||
}
|
||
current, hasCurrent, err := store.LibraryCurrentVersion(ctx, scope)
|
||
if err != nil || !hasCurrent || current.ID != reactivated.ID {
|
||
t.Fatalf("当前生效版本应指向重新激活的事件:found=%v err=%v %+v", hasCurrent, err, current)
|
||
}
|
||
}
|
||
|
||
// ledgerBackupStore 复用预备份时必须显式带上 Reused 与持久写集合:
|
||
// 少了 Reused,证据里就分不清"复用"和"重做备份";少了写集合,恢复只能按
|
||
// 目标现状推断残渣(把历史/共享资源当残渣删掉的老缺陷)。
|
||
func TestLedgerBackupStoreMarksReuseAndCarriesWriteSet(t *testing.T) {
|
||
write := &libraryrelease.WriteSet{JobID: "librestore-internal-1", Target: "internal"}
|
||
store := ledgerBackupStore{
|
||
ref: libraryrelease.BackupRef{ID: "backup-snap-1", SnapshotID: "snap-1", Bytes: 4096},
|
||
write: write,
|
||
}
|
||
ref, err := store.Prepare(context.Background(), "target-snap", libraryrelease.CurrentState{})
|
||
if err != nil {
|
||
t.Fatalf("prepare: %v", err)
|
||
}
|
||
if !ref.Reused {
|
||
t.Fatal("复用预备份没有标 Reused:证据里分不清复用与重做备份")
|
||
}
|
||
if ref.SnapshotID != "snap-1" || ref.WriteSet != write {
|
||
t.Fatalf("复用的预备份身份/写集合被改:%+v", ref)
|
||
}
|
||
if _, err := (ledgerBackupStore{ref: ref}).Prepare(context.Background(), "t", libraryrelease.CurrentState{}); err == nil {
|
||
t.Fatal("没有写集合时必须失败(不许降级成按现状推断残渣)")
|
||
}
|
||
}
|