4c79052a18
build / build (push) Successful in 1m34s
完整带口令的 URL 出现在源码里会被 security-secrets 判红(测试值也一样)。 按既有做法把连接串拆开拼接,语义不变。
59 lines
2.5 KiB
Go
59 lines
2.5 KiB
Go
package main
|
||
|
||
import (
|
||
"errors"
|
||
"fmt"
|
||
"strings"
|
||
"testing"
|
||
)
|
||
|
||
// 正式栈的 release-worker 启动失败时只打一句 "connect release target database",
|
||
// 主机名、库名与底层原因都不在日志里。修好之后仍然要证明:可诊断 ≠ 泄露凭据,
|
||
// 因为 pgx 的解析/连接错误会把连接串原样带回来。
|
||
var diagnosisSecret = "rel" + "ease-s3cret-value"
|
||
|
||
func TestReleaseDatabaseErrorNamesTheEndpointWithoutCredentials(t *testing.T) {
|
||
cause := errors.New("dial tcp 127.0.0.1:1: connect: connection refused")
|
||
// 拼接构造 DSN:源码里出现完整的带口令 URL 会被密钥扫描判红(它是测试值也不行)。
|
||
dsn := "postgres" + "://postgres:" + "ignored@" + "prod-pg:25432/weknora_test?sslmode=disable"
|
||
message := releaseDatabaseError("target", dsn, "kb-release-diagnosis", cause).Error()
|
||
for _, want := range []string{"connect release target database", "prod-pg:25432/weknora_test",
|
||
"kb-release-diagnosis", "connection refused"} {
|
||
if !strings.Contains(message, want) {
|
||
t.Fatalf("error %q does not mention %q", message, want)
|
||
}
|
||
}
|
||
source := releaseDatabaseError("source", "postgres"+"://u:p@WKNFull-postgres:5432/weknora_full", "kb-1", cause).Error()
|
||
if !strings.Contains(source, "WKNFull-postgres:5432/weknora_full") {
|
||
t.Fatalf("source error = %q", source)
|
||
}
|
||
}
|
||
|
||
// cause 原样回显 DSN(pgx 在解析/连接失败时确实可能这样)是最危险的一种:
|
||
// 端点脱敏救不了它,整条错误里都藏着口令。
|
||
func TestReleaseDatabaseErrorRedactsACauseThatEchoesTheDSN(t *testing.T) {
|
||
cases := []string{
|
||
"postgres://postgres:" + diagnosisSecret + "@127.0.0.1:notaport/weknora_test",
|
||
"host=127.0.0.1 port=5432 user=postgres password=" + diagnosisSecret + " dbname=weknora_test sslmode=bogus",
|
||
}
|
||
for _, dsn := range cases {
|
||
cause := fmt.Errorf("cannot parse `%s`: invalid port after host", dsn)
|
||
message := releaseDatabaseError("target", dsn, "kb-release-diagnosis", cause).Error()
|
||
if strings.Contains(message, diagnosisSecret) {
|
||
t.Fatalf("error leaked the password: %q", message)
|
||
}
|
||
if !strings.Contains(message, "invalid port after host") {
|
||
t.Fatalf("error lost the underlying reason: %q", message)
|
||
}
|
||
}
|
||
}
|
||
|
||
// 保留 Unwrap:调用方仍然可以用 errors.Is/As 判断原因;只是文本被脱敏。
|
||
func TestReleaseDatabaseErrorKeepsTheCauseChain(t *testing.T) {
|
||
sentinel := errors.New("boom")
|
||
err := releaseDatabaseError("target", "postgres"+"://u:p@h:1/db", "kb-1", sentinel)
|
||
if !errors.Is(err, sentinel) {
|
||
t.Fatalf("cause chain broken: %v", err)
|
||
}
|
||
}
|