Files
knowledge-governance/internal/versionhistory/gitea_test.go
T
姚章浩 4cb5110845
build / build (push) Successful in 1m1s
fix(version-history): 页面链接改走公网 origin(抓取仍走内网)+ tag 补链接
现象(主人反馈):点「查看提交」打开是空白页。原因:链接用的是**抓取用的内网地址**
(`http://192.168.50.223:3000/...`),内网外的浏览器到不了;而公网地址
`https://gitea.zheromiku.top/...` 实测 200。另外 tag 证据里**根本没有 url**,
页面渲染出空 `href`,点下去像"没反应"。

修复:

- 新增 `VERSION_HISTORY_LINK_ORIGIN`(页面链接 origin,公网;留空 = 与抓取 origin 相同):
  抓取仍匿名走内网白名单地址,**给人点的链接**用公网 origin 拼 —— 两者本就不该共用一个地址;
  校验必须是干净的 http(s) 绝对地址。
- tag 证据补 `url`(`<link origin>/<repo>/src/tag/<name>`),并在前端**没有链接就不渲染**该按钮。
- 测试:客户端(LinkOrigin 生效 / 未配时退回 / 非法拒绝)、规则(tag 链接写入证据 / 无基址不编链接)、
  前端(有链接才渲染「查看 tag」)。

验证:make verify 15/15;真实链路重同步后库里 commit_url = `https://gitea.zheromiku.top/...`(200)、
release_tags 带 url。
2026-10-14 11:06:13 +08:00

244 lines
8.9 KiB
Go
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
package versionhistory
import (
"context"
"fmt"
"net/http"
"net/http/httptest"
"strings"
"testing"
"time"
)
const (
shaA = "1111111111111111111111111111111111111111"
shaB = "2222222222222222222222222222222222222222"
shaT = "3333333333333333333333333333333333333333" // 注释 tag 对象
)
func fakeGitea(t *testing.T, handler http.HandlerFunc) *httptest.Server {
t.Helper()
server := httptest.NewServer(handler)
t.Cleanup(server.Close)
return server
}
func validConfig(base string) GiteaConfig {
return GiteaConfig{BaseURL: base, AllowedBaseURLs: []string{base}, Repo: "Weknora/knowledge-governance",
Sleep: func(time.Duration) {}, MaxRetries: 2, PageSize: 50}
}
func TestGiteaClientUsesSeparateLinkOriginForHumanLinks(t *testing.T) {
// 抓取走内网、链接走公网:页面上的链接必须用公网 origin,否则点开是空白。
config := validConfig("http://192.168.50.223:3000")
config.LinkOrigin = "https://gitea.zheromiku.top/"
client, err := NewGiteaClient(config)
if err != nil {
t.Fatalf("构造客户端失败:%v", err)
}
if got := client.CommitURLBase(); got != "https://gitea.zheromiku.top/Weknora/knowledge-governance/commit/" {
t.Fatalf("提交链接基址 = %q(必须用公网 origin)", got)
}
if got := client.TagURLBase(); got != "https://gitea.zheromiku.top/Weknora/knowledge-governance/src/tag/" {
t.Fatalf("tag 链接基址 = %q", got)
}
// 不配 LinkOrigin ⇒ 退回抓取 origin(内网场景仍然一致)
fallback, err := NewGiteaClient(validConfig("http://192.168.50.223:3000"))
if err != nil {
t.Fatalf("构造客户端失败:%v", err)
}
if !strings.HasPrefix(fallback.CommitURLBase(), "http://192.168.50.223:3000/") {
t.Fatalf("未配 LinkOrigin 时应退回抓取 origin:%q", fallback.CommitURLBase())
}
bad := validConfig("http://192.168.50.223:3000")
bad.LinkOrigin = "ftp://nope"
if _, err := NewGiteaClient(bad); err == nil {
t.Fatal("非 http(s) 的链接 origin 必须拒绝")
}
}
func TestGiteaClientRejectsNonWhitelistedOriginAndBadRepo(t *testing.T) {
if _, err := NewGiteaClient(GiteaConfig{BaseURL: "http://evil.example.com",
AllowedBaseURLs: []string{"http://192.168.50.223:3000"}, Repo: "a/b"}); err == nil {
t.Fatal("白名单外的 origin 必须拒绝")
}
if _, err := NewGiteaClient(GiteaConfig{BaseURL: "ftp://host", AllowedBaseURLs: []string{"ftp://host"},
Repo: "a/b"}); err == nil {
t.Fatal("非 http(s) 必须拒绝")
}
if _, err := NewGiteaClient(GiteaConfig{BaseURL: "http://host", AllowedBaseURLs: []string{"http://host"},
Repo: "a/b/c"}); err == nil {
t.Fatal("仓库必须是 owner/name")
}
if _, err := NewGiteaClient(GiteaConfig{BaseURL: "http://host", AllowedBaseURLs: []string{"http://host"},
Repo: "a/b?x=1"}); err == nil {
t.Fatal("仓库名带查询串必须拒绝")
}
}
func TestGiteaClientListCommitsParsesFieldsAndSendsNoCredentials(t *testing.T) {
var sawAuth string
server := fakeGitea(t, func(w http.ResponseWriter, r *http.Request) {
sawAuth = r.Header.Get("Authorization")
if got := r.URL.Path; got != "/api/v1/repos/Weknora/knowledge-governance/commits" {
t.Errorf("路径 = %s", got)
}
if r.URL.Query().Get("limit") != "50" || r.URL.Query().Get("page") != "1" {
t.Errorf("分页参数 = %s", r.URL.RawQuery)
}
w.Header().Set("X-Total-Count", "111")
fmt.Fprintf(w, `[{"sha":%q,"parents":[{"sha":%q}],"created":"2026-10-13T09:12:00Z",
"commit":{"message":"feat: 标题\n\n正文一行\n第二行","author":{"name":"姚章浩","date":"2026-10-13T09:11:00Z"},
"committer":{"name":"姚章浩","date":"2026-10-13T09:12:00Z"}}}]`, shaB, shaA)
})
client, err := NewGiteaClient(validConfig(server.URL))
if err != nil {
t.Fatalf("构造客户端失败:%v", err)
}
commits, total, err := client.ListCommits(context.Background(), 1, 50)
if err != nil {
t.Fatalf("ListCommits:%v", err)
}
if sawAuth != "" {
t.Fatalf("匿名只读不得携带任何凭据,实际带了 Authorization=%q", sawAuth)
}
if total != 111 || len(commits) != 1 {
t.Fatalf("total=%d len=%d", total, len(commits))
}
got := commits[0]
if got.SHA != shaB || len(got.Parents) != 1 || got.Parents[0] != shaA {
t.Fatalf("提交字段解析错:%+v", got)
}
if got.Subject != "feat: 标题" || got.Body != "正文一行\n第二行" {
t.Fatalf("标题/正文拆分错:%q / %q", got.Subject, got.Body)
}
if !got.CommittedAt.Equal(time.Date(2026, 10, 13, 9, 12, 0, 0, time.UTC)) {
t.Fatalf("提交时间解析错:%s", got.CommittedAt)
}
if !strings.HasSuffix(client.CommitURLBase(), "/Weknora/knowledge-governance/commit/") {
t.Fatalf("提交链接基址错:%s", client.CommitURLBase())
}
}
func TestGiteaClientRetriesTransientFailuresThenGivesUp(t *testing.T) {
attempts := 0
server := fakeGitea(t, func(w http.ResponseWriter, r *http.Request) {
attempts++
if attempts < 3 {
w.WriteHeader(http.StatusInternalServerError)
return
}
w.Header().Set("X-Total-Count", "0")
fmt.Fprint(w, "[]")
})
client, err := NewGiteaClient(validConfig(server.URL))
if err != nil {
t.Fatalf("构造客户端失败:%v", err)
}
if _, _, err := client.ListCommits(context.Background(), 1, 50); err != nil {
t.Fatalf("5xx 应退避重试后成功:%v", err)
}
if attempts != 3 {
t.Fatalf("重试次数 = %d,期望 3", attempts)
}
alwaysFail := fakeGitea(t, func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusInternalServerError)
})
client2, err := NewGiteaClient(validConfig(alwaysFail.URL))
if err != nil {
t.Fatalf("构造客户端失败:%v", err)
}
if _, _, err := client2.ListCommits(context.Background(), 1, 50); err == nil {
t.Fatal("持续 5xx 必须报错,不能返回空数据")
}
}
func TestGiteaClientRejectsOversizedResponseAndCrossHostRedirect(t *testing.T) {
big := fakeGitea(t, func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("X-Total-Count", "1")
fmt.Fprintf(w, "[{\"sha\":%q,\"commit\":{\"message\":%q}}]", shaA, strings.Repeat("x", 4096))
})
config := validConfig(big.URL)
config.MaxResponseBytes = 512
client, err := NewGiteaClient(config)
if err != nil {
t.Fatalf("构造客户端失败:%v", err)
}
if _, _, err := client.ListCommits(context.Background(), 1, 50); err == nil {
t.Fatal("超过响应上限必须报错(丢弃)")
}
elsewhere := fakeGitea(t, func(w http.ResponseWriter, r *http.Request) { fmt.Fprint(w, "[]") })
redirector := fakeGitea(t, func(w http.ResponseWriter, r *http.Request) {
http.Redirect(w, r, elsewhere.URL+"/api/v1/repos/Weknora/knowledge-governance/commits", http.StatusFound)
})
client2, err := NewGiteaClient(validConfig(redirector.URL))
if err != nil {
t.Fatalf("构造客户端失败:%v", err)
}
if _, _, err := client2.ListCommits(context.Background(), 1, 50); err == nil {
t.Fatal("跨主机重定向必须拒绝")
}
}
func TestGiteaClientListTagsDetectsAnnotatedAndLightweight(t *testing.T) {
server := fakeGitea(t, func(w http.ResponseWriter, r *http.Request) {
switch {
case r.URL.Path == "/api/v1/repos/Weknora/knowledge-governance/git/refs/tags":
fmt.Fprintf(w, `[{"ref":"refs/tags/v0.1.0","object":{"type":"tag","sha":%q}},
{"ref":"refs/tags/light","object":{"type":"commit","sha":%q}}]`, shaT, shaA)
case r.URL.Path == "/api/v1/repos/Weknora/knowledge-governance/git/tags/"+shaT:
fmt.Fprintf(w, `{"tag":"v0.1.0","object":{"type":"commit","sha":%q}}`, shaB)
default:
t.Errorf("未预期的路径 %s", r.URL.Path)
w.WriteHeader(http.StatusNotFound)
}
})
client, err := NewGiteaClient(validConfig(server.URL))
if err != nil {
t.Fatalf("构造客户端失败:%v", err)
}
tags, err := client.ListTags(context.Background())
if err != nil {
t.Fatalf("ListTags:%v", err)
}
if len(tags) != 2 {
t.Fatalf("tag 数 = %d", len(tags))
}
annotated := tags[0]
if annotated.Name != "v0.1.0" || !annotated.Annotated || annotated.TagSHA != shaT || annotated.TargetSHA != shaB {
t.Fatalf("注释 tag 应解引用到提交:%+v", annotated)
}
lightweight := tags[1]
if lightweight.Annotated || lightweight.TargetSHA != shaA {
t.Fatalf("轻量 tag 不能被当成注释 tag:%+v", lightweight)
}
}
func TestGiteaClientReadFileGuards(t *testing.T) {
server := fakeGitea(t, func(w http.ResponseWriter, r *http.Request) {
if r.URL.Query().Get("ref") != shaA {
t.Errorf("ref = %s", r.URL.Query().Get("ref"))
}
fmt.Fprint(w, "# Changelog\n")
})
client, err := NewGiteaClient(validConfig(server.URL))
if err != nil {
t.Fatalf("构造客户端失败:%v", err)
}
text, err := client.ReadFile(context.Background(), shaA, "CHANGELOG.md")
if err != nil || !strings.Contains(text, "Changelog") {
t.Fatalf("读文件失败:%v / %q", err, text)
}
if _, err := client.ReadFile(context.Background(), "abc", "CHANGELOG.md"); err == nil {
t.Fatal("短 SHA 必须拒绝")
}
if _, err := client.ReadFile(context.Background(), shaA, "../../etc/passwd"); err == nil {
t.Fatal("路径穿越必须拒绝")
}
if _, err := client.ReadFile(context.Background(), shaA, "/etc/passwd"); err == nil {
t.Fatal("绝对路径必须拒绝")
}
}