Files
knowledge-governance/cmd/worker/library_finish_test.go
T
姚章浩 8d2ed8ebe6
build / build (push) Successful in 1m32s
fix(library): 维护释放与服务恢复完成之后才暴露作业成功
原本 execute 写完生效版本就写 succeeded,而服务恢复、入口开放与维护锁释放发生在
窗口返回之后。任一步失败时外部已看到成功,重启接管又只认非终态,于是目标永远
留在维护里(本轮真实现象:同步 succeeded 后立即恢复被 409)。

现在内容校验与版本登记完成后只记"待收尾":finishLibrarySuccess 先确认目标写入者
与入口健康,再按 scope → instance 顺序释放两把锁(每一步错误都上抛,不再 `_ =` 丢弃),
最后才写 succeeded;任一步失败即落失败并保持 needs_restore。释放与终态写入用
context.WithoutCancel 有界包住,停机不会留下半成品。接管的 finalize-only 判定改为
按证据(finalize 阶段成功或未顶掉的生效版本),只复核与登记,不重写生产。

测试覆盖:调用顺序(成功后两把锁必已释放)、健康失败不释放不报成功、三步释放失败
各自不报成功、终态写入失败提示等待接管、接管证据判定正负例。
2026-10-29 14:02:09 +08:00

150 lines
5.8 KiB
Go

package main
import (
"context"
"errors"
"strings"
"testing"
"time"
"knowledge-governance/internal/governance"
)
type fakeFinishStore struct {
calls []string
failOn string
advanced []governance.LibraryJobState
}
func (f *fakeFinishStore) record(name string) error {
f.calls = append(f.calls, name)
if f.failOn == name {
return errors.New("injected " + name + " failure")
}
return nil
}
func (f *fakeFinishStore) SetInstanceMaintenanceIngress(context.Context, string, string, string, string, time.Time) error {
return f.record("instance_ingress")
}
func (f *fakeFinishStore) SetLibraryMaintenanceIngress(context.Context, string, string, string, string, time.Time) error {
return f.record("scope_ingress")
}
func (f *fakeFinishStore) UpdateInstanceMaintenanceState(context.Context, string, string, string, string, time.Time) error {
return f.record("instance_state")
}
func (f *fakeFinishStore) UpdateLibraryMaintenanceState(context.Context, string, string, string, string, time.Time) error {
return f.record("scope_state")
}
func (f *fakeFinishStore) ReleaseInstanceMaintenance(context.Context, string, string, time.Time) error {
return f.record("instance_release")
}
func (f *fakeFinishStore) ReleaseLibraryMaintenance(context.Context, string, string, time.Time) error {
return f.record("scope_release")
}
func (f *fakeFinishStore) AdvanceLibraryJob(_ context.Context, _ string, state governance.LibraryJobState,
_, _, _, _, _ string, _ time.Time) error {
f.advanced = append(f.advanced, state)
return f.record("advance_" + string(state))
}
type fakeHealth struct{ err error }
func (h fakeHealth) VerifyRunning(context.Context) error { return h.err }
func boundary() successBoundary {
return successBoundary{Ready: true, Backup: "backup-1", Target: "snap-1", FinishedAt: time.Now().UTC()}
}
// 首次观察到成功时,两把维护锁必须已经释放,且终态写入排在最后。
func TestFinishLibrarySuccessReleasesEveryLockBeforeSucceeded(t *testing.T) {
store := &fakeFinishStore{}
if err := finishLibrarySuccess(context.Background(), store, fakeHealth{}, "kgseal-weknora", "internal", "job-1", boundary()); err != nil {
t.Fatal(err)
}
want := []string{"scope_ingress", "instance_ingress", "scope_state", "scope_release",
"instance_state", "instance_release", "advance_succeeded"}
if strings.Join(store.calls, ",") != strings.Join(want, ",") {
t.Fatalf("call order = %v", store.calls)
}
if len(store.advanced) != 1 || store.advanced[0] != governance.LibraryJobSucceeded {
t.Fatalf("advanced = %v", store.advanced)
}
}
// 目标服务/入口没恢复健康:不许放锁,不许报成功,作业落成失败并保持维护。
func TestFinishLibrarySuccessKeepsMaintenanceWhenTargetIsNotHealthy(t *testing.T) {
store := &fakeFinishStore{}
err := finishLibrarySuccess(context.Background(), store, fakeHealth{err: errors.New("app not healthy")},
"kgseal-weknora", "internal", "job-2", boundary())
if err == nil || !strings.Contains(err.Error(), "未恢复健康") {
t.Fatalf("err = %v", err)
}
for _, call := range store.calls {
if strings.HasSuffix(call, "_release") || call == "advance_succeeded" {
t.Fatalf("released or reported success despite unhealthy target: %v", store.calls)
}
}
if len(store.advanced) != 1 || store.advanced[0] != governance.LibraryJobFailed {
t.Fatalf("advanced = %v", store.advanced)
}
}
// 任一步释放失败:不报成功,作业失败,维护状态写 needs_restore(等人工/接管)。
func TestFinishLibrarySuccessStopsOnReleaseFailure(t *testing.T) {
for _, step := range []string{"scope_release", "instance_state", "instance_release"} {
t.Run(step, func(t *testing.T) {
store := &fakeFinishStore{failOn: step}
err := finishLibrarySuccess(context.Background(), store, fakeHealth{}, "kgseal-weknora", "internal", "job-3", boundary())
if err == nil {
t.Fatalf("%s failure was swallowed", step)
}
for _, call := range store.calls {
if call == "advance_succeeded" {
t.Fatalf("reported success after %s failed: %v", step, store.calls)
}
}
if len(store.advanced) != 1 || store.advanced[0] != governance.LibraryJobFailed {
t.Fatalf("advanced = %v", store.advanced)
}
})
}
}
// 终态写入失败:锁已释放,但不能声称成功;作业保持非终态等接管。
func TestFinishLibrarySuccessReportsTerminalWriteFailure(t *testing.T) {
store := &fakeFinishStore{failOn: "advance_succeeded"}
err := finishLibrarySuccess(context.Background(), store, fakeHealth{}, "kgseal-weknora", "internal", "job-4", boundary())
if err == nil || !strings.Contains(err.Error(), "等待接管") {
t.Fatalf("err = %v", err)
}
}
// 接管判定只认证据:finalize 阶段成功或存在未被顶掉的生效版本。
func TestNeedsFinalizeOnlyUsesRealEvidence(t *testing.T) {
job := governance.LibraryJob{Scope: "internal", Kind: governance.LibraryJobSync, TargetSnapshotID: "snap-1"}
if needsFinalizeOnly(job, nil) {
t.Fatal("job without evidence treated as finalized")
}
withStage := job
withStage.Stages = []governance.LibraryStage{{Stage: "finalize", State: "succeeded"}}
if !needsFinalizeOnly(withStage, nil) {
t.Fatal("finalize stage ignored")
}
versions := []governance.LibraryVersion{{Kind: governance.LibraryVersionProductionEffective, SnapshotID: "snap-1"}}
if !needsFinalizeOnly(job, versions) {
t.Fatal("effective version ignored")
}
superseded := []governance.LibraryVersion{{Kind: governance.LibraryVersionProductionEffective,
SnapshotID: "snap-1", SupersededAt: ptrTime(time.Now())}}
if needsFinalizeOnly(job, superseded) {
t.Fatal("superseded version treated as evidence")
}
other := []governance.LibraryVersion{{Kind: governance.LibraryVersionProductionEffective, SnapshotID: "snap-2"}}
if needsFinalizeOnly(job, other) {
t.Fatal("version of another snapshot treated as evidence")
}
}
func ptrTime(value time.Time) *time.Time { return &value }