knowledge-governance/internal/httpapi/review_batch_test.go

package httpapi

import (
	"context"
	"encoding/json"
	"errors"
	"net/http"
	"net/http/httptest"
	"strings"
	"testing"

	"knowledge-governance/internal/governance"
	"knowledge-governance/internal/platform/postgres"
)

// reviewBatchFakeStore：在既有 fakeJobStore 之上补出批量审核能力，验证批量端点的
// 幂等键要求、逐条结果回报与错误映射。
type reviewBatchFakeStore struct {
	fakeJobStore
	captured governance.ReviewPublicationsBatchRequest
	result   governance.ReviewPublicationsBatchResult
	replayed bool
	err      error
}

func (s *reviewBatchFakeStore) ReviewPublicationsBatchWithOperation(_ context.Context, request governance.ReviewPublicationsBatchRequest, _ string) (governance.ReviewPublicationsBatchResult, bool, error) {
	s.captured = request
	return s.result, s.replayed, s.err
}

func TestBatchReviewCandidatesHandler(t *testing.T) {
	store := &reviewBatchFakeStore{result: governance.ReviewPublicationsBatchResult{Selected: 3, Decided: 2, Skipped: 1, SkippedIDs: []string{"tp-c"}, Reviews: []governance.PublicationReview{}}}
	handler, err := NewHandler(Config{Store: store})
	if err != nil {
		t.Fatal(err)
	}

	// 缺幂等键：写路由一律要求。
	missing := httptest.NewRecorder()
	handler.ServeHTTP(missing, httptest.NewRequest(http.MethodPost, "/api/v1/review-candidates/batch-decision", strings.NewReader(`{"publication_ids":["tp-a"],"decision":"approved","decided_visibility":"internal","decision_code":"approved_for_release"}`)))
	if missing.Code != http.StatusBadRequest {
		t.Fatalf("missing idempotency key status=%d", missing.Code)
	}

	// 空选择：直接拒绝。
	empty := httptest.NewRecorder()
	emptyRequest := httptest.NewRequest(http.MethodPost, "/api/v1/review-candidates/batch-decision", strings.NewReader(`{"publication_ids":[],"decision":"approved","decided_visibility":"internal","decision_code":"approved_for_release"}`))
	emptyRequest.Header.Set("Idempotency-Key", "op-batch-1")
	handler.ServeHTTP(empty, emptyRequest)
	if empty.Code != http.StatusBadRequest {
		t.Fatalf("empty selection status=%d", empty.Code)
	}

	// 正常：逐条结果原样回报，操作人由服务端盖章。
	ok := httptest.NewRecorder()
	okRequest := httptest.NewRequest(http.MethodPost, "/api/v1/review-candidates/batch-decision", strings.NewReader(`{"publication_ids":["tp-a","tp-b","tp-c"],"decision":"approved","decided_visibility":"internal","decision_code":"approved_for_release"}`))
	okRequest.Header.Set("Idempotency-Key", "op-batch-2")
	handler.ServeHTTP(ok, okRequest)
	if ok.Code != http.StatusOK {
		t.Fatalf("batch review status=%d body=%s", ok.Code, ok.Body.String())
	}
	var body struct {
		Data struct {
			Selected   int      `json:"selected"`
			Decided    int      `json:"decided"`
			Skipped    int      `json:"skipped"`
			SkippedIDs []string `json:"skipped_ids"`
		} `json:"data"`
	}
	if err := json.Unmarshal(ok.Body.Bytes(), &body); err != nil {
		t.Fatal(err)
	}
	if body.Data.Decided != 2 || body.Data.Skipped != 1 || len(body.Data.SkippedIDs) != 1 || body.Data.SkippedIDs[0] != "tp-c" {
		t.Fatalf("batch result=%#v", body.Data)
	}
	if store.captured.ReviewerRef == "" {
		t.Fatal("reviewer must be stamped by the server")
	}

	// 错误映射。
	for _, testCase := range []struct {
		name   string
		err    error
		status int
	}{
		{"invalid", postgres.ErrInvalidPublicationReview, http.StatusBadRequest},
		{"conflict", postgres.ErrOperationRequestConflict, http.StatusConflict},
		{"unexpected", errors.New("boom"), http.StatusInternalServerError},
	} {
		failing := &reviewBatchFakeStore{err: testCase.err}
		failingHandler, err := NewHandler(Config{Store: failing})
		if err != nil {
			t.Fatal(err)
		}
		recorder := httptest.NewRecorder()
		request := httptest.NewRequest(http.MethodPost, "/api/v1/review-candidates/batch-decision", strings.NewReader(`{"publication_ids":["tp-a"],"decision":"approved","decided_visibility":"internal","decision_code":"approved_for_release"}`))
		request.Header.Set("Idempotency-Key", "op-batch-3")
		failingHandler.ServeHTTP(recorder, request)
		if recorder.Code != testCase.status {
			t.Fatalf("%s status=%d want=%d", testCase.name, recorder.Code, testCase.status)
		}
	}

	// 未接线：诚实 501。
	unwired, err := NewHandler(Config{Store: storeWithoutReviewBatch{Store: store}})
	if err != nil {
		t.Fatal(err)
	}
	unwiredRecorder := httptest.NewRecorder()
	unwiredRequest := httptest.NewRequest(http.MethodPost, "/api/v1/review-candidates/batch-decision", strings.NewReader(`{"publication_ids":["tp-a"],"decision":"approved","decided_visibility":"internal","decision_code":"approved_for_release"}`))
	unwiredRequest.Header.Set("Idempotency-Key", "op-batch-4")
	unwired.ServeHTTP(unwiredRecorder, unwiredRequest)
	if unwiredRecorder.Code != http.StatusNotImplemented {
		t.Fatalf("unwired status=%d", unwiredRecorder.Code)
	}
}

type storeWithoutReviewBatch struct{ Store }