Files
knowledge-governance/cmd/worker/library_baseline_test.go
T
姚章浩 a42b101a7b
build / build (push) Successful in 1m25s
fix(library): 基线崩溃续作与维护原状态保留
父审发现三处会让目标卡死或状态对不上实际入口,逐条修:

1. 登记成功但没来得及收尾:崩溃重入会撞上"已有生效版本"直接失败,
   目标留在维护里、占用也不释放。现在按「本作业+同一快照」识别为自己的
   版本,只做收尾(恢复服务/开入口/释放两把占用),不重新捕获、不重写;
   别人的版本仍然拒绝。捕获完成但登记失败则明确失败并写"未对目标写入"。
2. 重入覆盖原运行状态:崩溃时服务已被停住,再读一次只会读到 stopped,
   写回去会让恢复阶段永远不启动写入者。AcquireInstance/LibraryMaintenance
   在 owner 相同的重入时保留已持久化原状态;新作业接管已释放窗口用自己的观察。
   真实 PostgreSQL 集成用例覆盖(先红后绿)。
3. 版本登记移进维护窗口:捕获/校验/登记要么一起成立、要么目标原样恢复;
   记录失败时窗口已开放,治理状态同步释放,不再"显示维护中、实际已开"。
   索引映射读不到时拒绝登记,不再用空摘要写证据。

顺带:
- 基线窗口统一收尾抽成 settleBaselineWindow,四种结局各有测试(成功/健康失败/
  held 保持维护/已恢复则释放),并用真实 DB 用例证明 baseline 与 sync/restore
  共用写互斥、幂等重试不产生第二个作业。
- 新增 cmd/librarydrill:维护隔离 → 整库预备份 → 一致性校验 → canary 漂移检测
  → 按预备份恢复 → 逐类复核 → 按原状态恢复服务。用与 worker 相同的 LIBRARY_*
  配置,绝不触碰封存源。
- 目标/预备份/维护栈装配收成 internal/librarystack 一份(worker 与演练共用)。

验证:go build/vet/test 全过;TEST_DATABASE_URL 指向临时 PostgreSQL 跑
TestMaintenanceReentryKeepsOriginalServiceState(修复前失败:got app=stopped)
与 TestLibraryWriteMutexCoversBaselineJobs;本地门禁 15/15。
2026-10-29 19:08:58 +08:00

150 lines
6.0 KiB
Go

package main
import (
"context"
"errors"
"strings"
"testing"
"time"
"knowledge-governance/internal/governance"
)
// 崩溃续作的版本判定:本作业+同一快照 = 只收尾;别人的生效版本 = 拒绝;都没有 = 正常建基线。
func TestClassifyBaselineVersions(t *testing.T) {
const jobA, jobB, snap = "libbase-internal-1", "libbase-internal-2", "snap-abc"
effective := func(sourceJob, snapshot string, superseded bool) governance.LibraryVersion {
item := governance.LibraryVersion{
Scope: "internal", Kind: governance.LibraryVersionProductionEffective,
SnapshotID: snapshot, SourceJobID: sourceJob, CreatedAt: time.Now().UTC(),
}
if superseded {
at := time.Now().UTC()
item.SupersededAt = &at
}
return item
}
if state := classifyBaselineVersions(nil, jobA, snap); state.Own || state.Foreign != nil {
t.Fatalf("no versions must mean neither own nor foreign: %+v", state)
}
if state := classifyBaselineVersions([]governance.LibraryVersion{effective(jobA, snap, false)}, jobA, snap); !state.Own {
t.Fatalf("same job + same snapshot must be recognized as own: %+v", state)
}
// 快照不同就不是"我登记的那份",不能当成可收尾。
if state := classifyBaselineVersions([]governance.LibraryVersion{effective(jobA, "snap-other", false)}, jobA, snap); state.Own || state.Foreign == nil {
t.Fatalf("different snapshot of same job must not be own: %+v", state)
}
// 别人的生效版本:即使快照相同也必须拒绝。
foreign := classifyBaselineVersions([]governance.LibraryVersion{effective(jobB, snap, false)}, jobA, snap)
if foreign.Own || foreign.Foreign == nil || foreign.Foreign.SourceJobID != jobB {
t.Fatalf("foreign effective version must be reported: %+v", foreign)
}
// 已被顶替的旧版本不算生效版本。
if state := classifyBaselineVersions([]governance.LibraryVersion{effective(jobB, snap, true)}, jobA, snap); state.Own || state.Foreign != nil {
t.Fatalf("superseded version must not block a baseline: %+v", state)
}
}
// 版本已登记 + 健康:走成功边界,释放两把占用并把作业标成功。
func TestSettleBaselineWindowFinishesWhenRecorded(t *testing.T) {
store := &fakeFinishStore{}
if err := settleBaselineWindow(context.Background(), store, fakeHealth{}, "job-1", "internal", "kgseal-app",
"snap-abc", true, "succeeded", nil); err != nil {
t.Fatalf("settle: %v", err)
}
if !containsCall(store.calls, "advance_succeeded") {
t.Fatalf("job must be marked succeeded: %v", store.calls)
}
if containsCall(store.states, "needs_restore") {
t.Fatalf("success path must not hold the target in maintenance: %v", store.states)
}
if !containsCall(store.calls, "scope_release") || !containsCall(store.calls, "instance_release") {
t.Fatalf("both locks must be released: %v", store.calls)
}
}
// 版本已登记但目标服务/入口没恢复:不能报成功,必须保持维护并标 needs_restore。
func TestSettleBaselineWindowHoldsWhenHealthFails(t *testing.T) {
store := &fakeFinishStore{}
err := settleBaselineWindow(context.Background(), store, fakeHealth{err: errors.New("kgseal-ingress 未就绪")},
"job-1", "internal", "kgseal-app", "snap-abc", true, "succeeded", nil)
if err == nil {
t.Fatal("unhealthy target must not report success")
}
if containsCall(store.calls, "advance_succeeded") {
t.Fatalf("must not mark succeeded while target is unhealthy: %v", store.calls)
}
if countCall(store.states, "needs_restore") != 2 {
t.Fatalf("must hold both records with needs_restore: %v", store.states)
}
}
// 没有登记、窗口仍是 held:只能保持维护(服务确实没回来),绝不能释放占用。
func TestSettleBaselineWindowKeepsHeldWindowInMaintenance(t *testing.T) {
store := &fakeFinishStore{}
err := settleBaselineWindow(context.Background(), store, fakeHealth{}, "job-1", "internal", "kgseal-app",
"snap-abc", false, "held", errors.New("停写入者后后台仍有任务"))
if err == nil || !strings.Contains(err.Error(), "保持维护") {
t.Fatalf("err=%v", err)
}
if containsCall(store.calls, "scope_release") || containsCall(store.calls, "instance_release") {
t.Fatalf("held window must not release locks: %v", store.calls)
}
if countCall(store.states, "needs_restore") != 2 {
t.Fatalf("held window must be recorded as needs_restore: %v", store.states)
}
if !containsCall(store.calls, "advance_failed") {
t.Fatalf("job must fail: %v", store.calls)
}
}
// 没有登记、但窗口已按原状态开放:状态必须跟着变成"已释放",
// 不能留下"显示维护中、实际入口已开"。
func TestSettleBaselineWindowReleasesWhenWindowRestored(t *testing.T) {
store := &fakeFinishStore{}
err := settleBaselineWindow(context.Background(), store, fakeHealth{}, "job-1", "internal", "kgseal-app",
"snap-abc", false, "failed", errors.New("捕获目标整库失败"))
if err == nil || !strings.Contains(err.Error(), "未建立基线") {
t.Fatalf("err=%v", err)
}
if !containsCall(store.calls, "scope_release") || !containsCall(store.calls, "instance_release") {
t.Fatalf("restored window must release both locks: %v", store.calls)
}
if containsCall(store.states, "needs_restore") {
t.Fatalf("released window must not be marked as needs_restore: %v", store.states)
}
if !containsCall(store.calls, "advance_failed") {
t.Fatalf("job must fail: %v", store.calls)
}
}
// 释放失败时不能在作业上写"无需恢复":那会让界面与实际占用分叉。
func TestSettleBaselineWindowReportsReleaseFailure(t *testing.T) {
store := &fakeFinishStore{failOn: "scope_release"}
err := settleBaselineWindow(context.Background(), store, fakeHealth{}, "job-1", "internal", "kgseal-app",
"snap-abc", false, "failed", nil)
if err == nil || !strings.Contains(err.Error(), "维护占用释放失败") {
t.Fatalf("err=%v", err)
}
}
func countCall(calls []string, want string) int {
count := 0
for _, call := range calls {
if call == want {
count++
}
}
return count
}
func containsCall(calls []string, want string) bool {
for _, call := range calls {
if call == want {
return true
}
}
return false
}