package httpapi import ( "context" "encoding/json" "net/http" "net/http/httptest" "strings" "testing" "time" "knowledge-governance/internal/qawemail" ) type fakeWeeklyMailStore struct { preview qawemail.SendPreview previewErr error result qawemail.ManualResult sendErr error calls int lastWeek string lastRev int64 lastHash string lastActor string } func (f *fakeWeeklyMailStore) ReadSettings(context.Context) (qawemail.Settings, error) { return qawemail.Settings{}, nil } func (f *fakeWeeklyMailStore) SaveSettings(context.Context, string, qawemail.SettingsInput) (qawemail.Settings, error) { return qawemail.Settings{}, nil } func (f *fakeWeeklyMailStore) Confirm(context.Context, string, string) (qawemail.Confirmation, error) { return qawemail.Confirmation{}, nil } func (f *fakeWeeklyMailStore) Unconfirm(context.Context, string) error { return nil } func (f *fakeWeeklyMailStore) ReadConfirmation(context.Context, string) (*qawemail.Confirmation, error) { return nil, nil } func (f *fakeWeeklyMailStore) Sends(context.Context, string) ([]qawemail.Send, error) { return nil, nil } func (f *fakeWeeklyMailStore) TestSend(context.Context, string) (string, error) { return "", nil } func (f *fakeWeeklyMailStore) SaveDashboardImage(context.Context, string, []byte) error { return nil } func (f *fakeWeeklyMailStore) SendDue(context.Context, time.Time) (qawemail.DueResult, error) { return qawemail.DueResult{}, nil } func (f *fakeWeeklyMailStore) PreviewSend(_ context.Context, week string, revision int64, hash string, _ time.Time) (qawemail.SendPreview, error) { f.lastWeek, f.lastRev, f.lastHash = week, revision, hash if f.previewErr != nil { return qawemail.SendPreview{}, f.previewErr } out := f.preview out.Week, out.Revision, out.BodySHA256 = week, revision, hash return out, nil } func (f *fakeWeeklyMailStore) SendManual(_ context.Context, week string, revision int64, hash, actor string, _ time.Time) (qawemail.ManualResult, error) { f.calls++ f.lastWeek, f.lastRev, f.lastHash, f.lastActor = week, revision, hash, actor if f.sendErr != nil { return qawemail.ManualResult{}, f.sendErr } out := f.result out.Week, out.Revision = week, revision return out, nil } func weeklyMailSendRequest(t *testing.T, role, body string, withIntent bool) *http.Request { t.Helper() request := httptest.NewRequest(http.MethodPost, "/api/v1/qa-ops/master/weekly-mail/send/2026-W45", strings.NewReader(body)) request.SetPathValue("week", "2026-W45") request = request.WithContext(context.WithValue(request.Context(), sessionKey{}, sessionIdentity{Username: "tester", Role: role})) if withIntent { request.Header.Set("X-Governance-Action", "qa-weekly-mail") } return request } // 正式补发是管理员动作:普通角色与缺少同源意图都必须被挡在 SMTP 之前。 func TestWeeklyMailFormalSendRequiresAdminAndIntent(t *testing.T) { store := &fakeWeeklyMailStore{result: qawemail.ManualResult{Status: "sent", MessageID: ""}} config := Config{QAWeeklyMail: store} body := `{"revision":16,"body_sha256":"` + strings.Repeat("a", 64) + `"}` recorder := httptest.NewRecorder() qaWeeklyMailSend(recorder, weeklyMailSendRequest(t, "engineer", body, true), config) if recorder.Code != http.StatusForbidden { t.Fatalf("非管理员必须 403,status=%d body=%s", recorder.Code, recorder.Body.String()) } recorder = httptest.NewRecorder() qaWeeklyMailSend(recorder, weeklyMailSendRequest(t, roleAdmin, body, false), config) if recorder.Code != http.StatusForbidden { t.Fatalf("缺少同源操作意图必须 403,status=%d body=%s", recorder.Code, recorder.Body.String()) } if store.calls != 0 { t.Fatalf("被拒请求不得调用发送:calls=%d", store.calls) } } // 成功补发必须把 week/版本/hash/操作人原样交给 store,并回传真实 message_id 与收件人数。 func TestWeeklyMailFormalSendPassesExactRevisionAndReturnsReceipt(t *testing.T) { store := &fakeWeeklyMailStore{result: qawemail.ManualResult{Status: "sent", MessageID: "", Recipients: 119, Cc: 8}} config := Config{QAWeeklyMail: store} hash := strings.Repeat("b", 64) recorder := httptest.NewRecorder() qaWeeklyMailSend(recorder, weeklyMailSendRequest(t, roleAdmin, `{"revision":16,"body_sha256":"`+hash+`"}`, true), config) if recorder.Code != http.StatusOK { t.Fatalf("管理员补发应成功,status=%d body=%s", recorder.Code, recorder.Body.String()) } if store.lastWeek != "2026-W45" || store.lastRev != 16 || store.lastHash != hash || store.lastActor != "tester" { t.Fatalf("补发参数没有精确传递:week=%q rev=%d hash=%q actor=%q", store.lastWeek, store.lastRev, store.lastHash, store.lastActor) } var payload struct { Data qawemail.ManualResult `json:"data"` } if err := json.Unmarshal(recorder.Body.Bytes(), &payload); err != nil { t.Fatal(err) } if payload.Data.MessageID != "" || payload.Data.Recipients != 119 || payload.Data.Cc != 8 { t.Fatalf("响应必须带回真实发送凭据与正式收件人数:%+v", payload.Data) } } // 前置条件不满足必须给出具体原因,而不是冒充 SMTP 失败。 func TestWeeklyMailFormalSendExplainsRefusalsInsteadOfSMTPFailure(t *testing.T) { cases := []struct { name string err error status int contains string }{ {"future", qawemail.ErrFutureWeek, http.StatusBadRequest, "未来周"}, {"slot", qawemail.ErrSlotPending, http.StatusConflict, "尚未到达设定的发送时点"}, {"stale", qawemail.ErrNotCurrent, http.StatusConflict, "正文/版本已变化"}, {"inflight", qawemail.ErrSendInFlight, http.StatusConflict, "结果未知"}, {"nopassword", qawemail.ErrNoPassword, http.StatusConflict, "授权码"}, } for _, tc := range cases { t.Run(tc.name, func(t *testing.T) { store := &fakeWeeklyMailStore{sendErr: tc.err} recorder := httptest.NewRecorder() qaWeeklyMailSend(recorder, weeklyMailSendRequest(t, roleAdmin, `{"revision":16,"body_sha256":"`+strings.Repeat("c", 64)+`"}`, true), Config{QAWeeklyMail: store}) if recorder.Code != tc.status || !strings.Contains(recorder.Body.String(), tc.contains) { t.Fatalf("%s 应 %d 且说明原因 %q,status=%d body=%s", tc.name, tc.status, tc.contains, recorder.Code, recorder.Body.String()) } }) } } // SMTP 真实失败:必须 502 且带上真实原因,绝不能回“已发送”。 func TestWeeklyMailFormalSendReportsDeliveryFailure(t *testing.T) { store := &fakeWeeklyMailStore{result: qawemail.ManualResult{Status: "failed", Reason: "发送失败:smtp 登录失败: 535"}} recorder := httptest.NewRecorder() qaWeeklyMailSend(recorder, weeklyMailSendRequest(t, roleAdmin, `{"revision":16,"body_sha256":"`+strings.Repeat("d", 64)+`"}`, true), Config{QAWeeklyMail: store}) if recorder.Code != http.StatusBadGateway || !strings.Contains(recorder.Body.String(), "535") { t.Fatalf("未送达必须 502 并带真实原因,status=%d body=%s", recorder.Code, recorder.Body.String()) } } // 补发前预览必须给出真实 week/版本/收件人数,用于确认框;预览本身不投递。 func TestWeeklyMailSendPreviewShowsExactDistribution(t *testing.T) { store := &fakeWeeklyMailStore{preview: qawemail.SendPreview{Status: "ready", Recipients: 119, Cc: 8}} hash := strings.Repeat("e", 64) request := httptest.NewRequest(http.MethodGet, "/api/v1/qa-ops/master/weekly-mail/send/2026-W45?revision=16&body_sha256="+hash, nil) request.SetPathValue("week", "2026-W45") request = request.WithContext(context.WithValue(request.Context(), sessionKey{}, sessionIdentity{Username: "tester", Role: roleAdmin})) recorder := httptest.NewRecorder() qaWeeklyMailSendPreview(recorder, request, Config{QAWeeklyMail: store}) if recorder.Code != http.StatusOK { t.Fatalf("预览应成功,status=%d body=%s", recorder.Code, recorder.Body.String()) } var payload struct { Data qawemail.SendPreview `json:"data"` } if err := json.Unmarshal(recorder.Body.Bytes(), &payload); err != nil { t.Fatal(err) } if payload.Data.Recipients != 119 || payload.Data.Cc != 8 || payload.Data.Revision != 16 || payload.Data.Status != "ready" { t.Fatalf("预览必须给出正式收件人数与版本:%+v", payload.Data) } if store.calls != 0 { t.Fatal("预览不得触发发送") } }