package qaopsorg import ( "testing" "time" ) func TestDepartmentStatisticsDeduplicateSubtreePeopleAndUseCurrentMembership(t *testing.T) { directory := Directory{Departments: []Department{{ID: "root", Name: "Root"}, {ID: "child", ParentID: "root", Name: "Child"}, {ID: "former", ParentID: "root", Name: "Former"}, {ID: "current", ParentID: "root", Name: "Current"}, {ID: "empty", ParentID: "root", Name: "Empty"}}, People: []Person{{ID: "one", UnionID: "union-one", Name: "Fixture One", DepartmentIDs: []string{"root", "child"}}, {ID: "moved", Name: "Moved Fixture", DepartmentIDs: []string{"current"}}, {ID: "never", DepartmentIDs: []string{"child"}}}} p, err := BuildAttribution(State{State: "ready", DirectoryID: "fixture"}, directory) if err != nil { t.Fatal(err) } earlier := time.Date(2026, 10, 1, 0, 0, 0, 0, time.UTC) later := earlier.Add(time.Hour) out, err := AggregateDepartmentStatistics(p, []DepartmentActivity{{StaffID: "one", Visits: 2, LastAskedAt: earlier}, {UnionID: "union-one", Visits: 1, LastAskedAt: later}, {Asker: "Moved Fixture", Visits: 4, LastAskedAt: earlier}, {StaffID: "not-in-current-directory", Visits: 5, LastAskedAt: later}}) if err != nil { t.Fatal("current-roster subtree aggregation is missing", err) } rows := map[string]DepartmentStatistic{} for _, row := range out.Rows { rows[row.ID] = row } root, child, current, former, empty := rows["root"], rows["child"], rows["current"], rows["former"], rows["empty"] if root.TotalPeople != 3 || root.Visitors != 2 || root.Visits != 7 || root.Ratio == nil || *root.Ratio != 100.0*2/3 || root.LastAskedAt == nil || !root.LastAskedAt.Equal(later) { t.Fatalf("subtree parent duplicated or event counts lost: %+v", root) } if child.TotalPeople != 2 || child.Visitors != 1 || child.Visits != 3 || child.Ratio == nil || *child.Ratio != 50 { t.Fatalf("parent/child alias not deduplicated: %+v", child) } if current.Visitors != 1 || current.Visits != 4 || former.Visitors != 0 || former.Visits != 0 { t.Fatal("historical events were attributed to an old department") } if empty.TotalPeople != 0 || empty.Ratio != nil || empty.LastAskedAt != nil { t.Fatal("zero denominator fabricated a percentage/time") } if out.TotalVisits != 12 || out.UnmappedVisits != 5 || out.TotalPeople != 3 { t.Fatalf("unmatched events hidden or fake membership: %+v", out) } }