package postgres import ( "context" "errors" "os" "testing" "time" "github.com/jackc/pgx/v5/pgxpool" "knowledge-governance/internal/governance" ) // 系统自动批准只能写"第一条"审核:人工一旦表过态,机器不得用一条更晚的 approved // 把人工结论翻回去(重跑验收时尤其危险)。人工审核不受限,随时可再审。 func TestAutoReviewNeverOverridesHumanDecisions(t *testing.T) { databaseURL := isolatedIntegrationDatabaseURL(t, os.Getenv("TEST_DATABASE_URL")) if databaseURL == "" { t.Skip("TEST_DATABASE_URL is not set") } ctx := context.Background() pool, err := pgxpool.New(ctx, databaseURL) if err != nil { t.Fatal(err) } defer pool.Close() if err := ApplyMigrations(ctx, pool); err != nil { t.Fatal(err) } store := NewStore(pool) now := time.Date(2026, 10, 10, 12, 0, 0, 0, time.UTC) if _, err := pool.Exec(ctx, `INSERT INTO source_connections (id, source_type, name) VALUES ('conn-manual', 'manual', 'Manual')`); err != nil { t.Fatal(err) } insertReviewFixture(t, ctx, pool, 10, "tp-auto-first", now) insertReviewFixture(t, ctx, pool, 11, "tp-auto-rejected", now) // 还没有任何审核:系统可以写第一条。 if _, err := store.ReviewPublication(ctx, governance.ReviewPublicationRequest{ PublicationID: "tp-auto-first", Decision: governance.ReviewApproved, DecidedVisibility: governance.VisibilityInternal, ReviewerRef: "system:auto", DecisionCode: "approved_for_release", Now: now.Add(time.Minute), }); err != nil { t.Fatalf("first auto review must be allowed: %v", err) } // 人工先驳回:系统再也不能自动批准这一条。 if _, err := store.ReviewPublication(ctx, governance.ReviewPublicationRequest{ PublicationID: "tp-auto-rejected", Decision: governance.ReviewRejected, DecidedVisibility: governance.VisibilityInternal, ReviewerRef: "admin", DecisionCode: "needs_correction", Now: now.Add(time.Minute), }); err != nil { t.Fatalf("human rejection must succeed: %v", err) } if _, err := store.ReviewPublication(ctx, governance.ReviewPublicationRequest{ PublicationID: "tp-auto-rejected", Decision: governance.ReviewApproved, DecidedVisibility: governance.VisibilityInternal, ReviewerRef: "system:auto", DecisionCode: "approved_for_release", Now: now.Add(2 * time.Minute), }); !errors.Is(err, ErrPublicationReviewNotEligible) { t.Fatalf("auto review over a human decision error=%v, want ErrPublicationReviewNotEligible", err) } var decision, reviewer string if err := pool.QueryRow(ctx, `SELECT decision, reviewer_ref FROM publication_reviews WHERE publication_id='tp-auto-rejected' ORDER BY created_at DESC, id DESC LIMIT 1`).Scan(&decision, &reviewer); err != nil { t.Fatal(err) } if decision != "rejected" || reviewer != "admin" { t.Fatalf("latest review = %q by %q, want rejected by admin", decision, reviewer) } // 人工仍可再审(例如改判为批准)。 if _, err := store.ReviewPublication(ctx, governance.ReviewPublicationRequest{ PublicationID: "tp-auto-rejected", Decision: governance.ReviewApproved, DecidedVisibility: governance.VisibilityInternal, ReviewerRef: "admin", DecisionCode: "approved_for_release", Now: now.Add(3 * time.Minute), }); err != nil { t.Fatalf("human re-review must still be allowed: %v", err) } }