package monitoring import ( "encoding/json" "testing" ) func TestComputeJobWindowMetricsRates(t *testing.T) { // Mixed completed/failed inside the window: rates must be exact. m := computeJobWindowMetrics([]windowJobOutcome{ {state: "completed", durationSeconds: 10}, {state: "completed", durationSeconds: 20}, {state: "completed", durationSeconds: 30}, {state: "failed", durationSeconds: 40}, }, 60) if m.WindowSeconds != 60 || m.JobsCompleted != 3 || m.JobsFailed != 1 { t.Fatalf("counts = %+v", m) } if m.SuccessRate == nil || *m.SuccessRate != 75 { t.Fatalf("success rate = %v, want 75", m.SuccessRate) } if m.FailureRate == nil || *m.FailureRate != 25 { t.Fatalf("failure rate = %v, want 25", m.FailureRate) } // Durations: avg 25s, p50 20s (nearest-rank on 4 sorted samples 10/20/30/40). if m.DurationAvgSeconds == nil || *m.DurationAvgSeconds != 25 { t.Fatalf("avg = %v, want 25", m.DurationAvgSeconds) } if m.DurationP50Seconds == nil || *m.DurationP50Seconds != 20 { t.Fatalf("p50 = %v, want 20", m.DurationP50Seconds) } if m.DurationP95Seconds == nil || *m.DurationP95Seconds != 40 { t.Fatalf("p95 = %v, want 40", m.DurationP95Seconds) } } func TestComputeJobWindowMetricsNullsWhenNoSamples(t *testing.T) { // Insufficient data must be null, never a fabricated 0%. m := computeJobWindowMetrics([]windowJobOutcome{{state: "completed", durationSeconds: -1}}, 3600) if m.JobsCompleted != 1 { t.Fatalf("completed = %d", m.JobsCompleted) } if m.SuccessRate == nil || *m.SuccessRate != 100 { t.Fatalf("success rate = %v, want 100 (1/1)", m.SuccessRate) } if m.DurationAvgSeconds != nil || m.DurationP50Seconds != nil || m.DurationP95Seconds != nil { t.Fatalf("durations must be null without terminal-time samples: %+v", m) } empty := computeJobWindowMetrics(nil, 3600) if empty.SuccessRate != nil || empty.FailureRate != nil || empty.JobsStarted != 0 { t.Fatalf("empty window = %+v, want all-null rates", empty) } blob, err := json.Marshal(empty) if err != nil { t.Fatal(err) } for _, key := range []string{`"success_rate":null`, `"failure_rate":null`, `"duration_avg_seconds":null`} { if !contains(string(blob), key) { t.Fatalf("metrics JSON missing %s: %s", key, blob) } } } func contains(haystack, needle string) bool { for i := 0; i+len(needle) <= len(haystack); i++ { if haystack[i:i+len(needle)] == needle { return true } } return false }