feat(qaops): 增加版本化部门区域归属配置与预览

This commit is contained in:
姚章浩
2026-10-17 11:39:38 +08:00
parent fd04bf7886
commit dab74b706b
23 changed files with 1693 additions and 51 deletions
+81
View File
@@ -0,0 +1,81 @@
package httpapi
import (
"context"
"encoding/json"
"errors"
"io"
"knowledge-governance/internal/qaopsorg"
"net/http"
"net/url"
)
type QAOrgStore interface {
GetView(context.Context) (qaopsorg.State, error)
PreviewRules(context.Context, qaopsorg.SaveRequest) (qaopsorg.State, error)
SaveRules(context.Context, qaopsorg.SaveRequest, string) (qaopsorg.State, error)
}
func qaOrganization(w http.ResponseWriter, r *http.Request, config Config) {
if !authorizeQAOps(w, r) {
return
}
if r.URL.RawQuery != "" {
writeOrgError(w, qaopsorg.ErrInvalid)
return
}
if config.QAOrg == nil {
writeOrgError(w, qaopsorg.ErrUnavailable)
return
}
var result qaopsorg.State
var err error
if r.Method == http.MethodGet {
result, err = config.QAOrg.GetView(r.Context())
} else {
if r.Header.Get("X-Governance-Action") != "qa-organization" || r.Header.Get("Sec-Fetch-Site") == "cross-site" {
writeJSON(w, 403, map[string]string{"error": "区域配置需要同源操作意图"})
return
}
// A same-origin browser request can pass a reverse proxy that rewrites
// Host. Fetch Metadata is browser-controlled; keep the explicit action
// header and reject cross-site requests without trusting forwarded hosts.
if raw := r.Header.Get("Origin"); raw != "" && r.Header.Get("Sec-Fetch-Site") != "same-origin" {
origin, parseErr := url.Parse(raw)
if parseErr != nil || (origin.Scheme != "http" && origin.Scheme != "https") || origin.Host != r.Host {
writeJSON(w, 403, map[string]string{"error": "拒绝跨站配置请求"})
return
}
}
var request qaopsorg.SaveRequest
decoder := json.NewDecoder(http.MaxBytesReader(w, r.Body, 1<<20))
decoder.DisallowUnknownFields()
if decoder.Decode(&request) != nil || decoder.Decode(&struct{}{}) != io.EOF || request.DirectoryID == "" || request.Rules == nil {
writeOrgError(w, qaopsorg.ErrInvalid)
return
}
if r.Method == http.MethodPost {
result, err = config.QAOrg.PreviewRules(r.Context(), request)
} else {
identity, _ := sessionFrom(r.Context())
result, err = config.QAOrg.SaveRules(r.Context(), request, identity.Username)
}
}
if err != nil {
writeOrgError(w, err)
return
}
writeJSON(w, 200, map[string]any{"data": result})
}
func writeOrgError(w http.ResponseWriter, err error) {
status, message := 503, "通讯录或区域配置存储不可用,未展示为空数据"
switch {
case errors.Is(err, qaopsorg.ErrInvalid):
status, message = 400, "部门树或区域配置无效,请核对重复、缺失路径及区域"
case errors.Is(err, qaopsorg.ErrConflict):
status, message = 409, "通讯录或区域配置已变化,请重新读取后预览"
case errors.Is(err, qaopsorg.ErrNoDirectory):
status, message = 409, "尚无完整通讯录快照,不能保存区域配置"
}
writeJSON(w, status, map[string]string{"error": message})
}
+33
View File
@@ -0,0 +1,33 @@
package httpapi
import (
"net/http"
"net/http/httptest"
"strings"
"testing"
)
func TestQAOrganizationSameOriginThroughReverseProxy(t *testing.T) {
auth := newFakeAuthStore()
auth.sessions["org-proxy-admin"] = "usr-boss"
spy := &orgSpy{}
handler, err := NewHandler(Config{Store: &fakeJobStore{}, QAOrg: spy, Auth: &AuthConfig{Store: auth}})
if err != nil {
t.Fatal(err)
}
for _, tc := range []struct {
site string
status int
}{{"same-origin", 200}, {"cross-site", 403}, {"same-site", 403}} {
req := httptest.NewRequest("PUT", "http://internal-api:8080/api/v1/qa-ops/organization/regions", strings.NewReader(`{"directory_id":"d","base_revision":"","rules":[]}`))
req.AddCookie(&http.Cookie{Name: sessionCookieName, Value: "org-proxy-admin"})
req.Header.Set("X-Governance-Action", "qa-organization")
req.Header.Set("Origin", "http://frontend:8088")
req.Header.Set("Sec-Fetch-Site", tc.site)
res := httptest.NewRecorder()
handler.ServeHTTP(res, req)
if res.Code != tc.status {
t.Fatalf("proxy fetch site %s got %d want %d", tc.site, res.Code, tc.status)
}
}
}
+82
View File
@@ -0,0 +1,82 @@
package httpapi
import (
"context"
"knowledge-governance/internal/qaopsorg"
"net/http"
"net/http/httptest"
"strings"
"testing"
)
type orgSpy struct {
calls int
actor string
err error
}
func (s *orgSpy) GetView(context.Context) (qaopsorg.State, error) {
s.calls++
return qaopsorg.State{State: "empty"}, s.err
}
func (s *orgSpy) PreviewRules(context.Context, qaopsorg.SaveRequest) (qaopsorg.State, error) {
s.calls++
return qaopsorg.State{}, s.err
}
func (s *orgSpy) SaveRules(_ context.Context, _ qaopsorg.SaveRequest, actor string) (qaopsorg.State, error) {
s.calls++
s.actor = actor
return qaopsorg.State{}, s.err
}
func TestQAOrganizationGuardsIdentityIntentAndErrors(t *testing.T) {
spy := &orgSpy{}
auth := newFakeAuthStore()
auth.sessions["org-admin"] = "usr-boss"
auth.sessions["org-viewer"] = "usr-eye"
handler, err := NewHandler(Config{Store: &fakeJobStore{}, QAOrg: spy, Auth: &AuthConfig{Store: auth}})
if err != nil {
t.Fatal(err)
}
base := "/api/v1/qa-ops/organization"
for _, tc := range []struct {
method, path, token, action, origin, body string
status int
}{
{"GET", base, "", "", "", "", 401},
{"GET", base, "org-viewer", "", "", "", 403},
{"GET", base, "org-admin", "", "", "", 200},
{"GET", base + "?tenant=another", "org-admin", "", "", "", 400},
{"PUT", base + "/regions", "org-admin", "", "", "{}", 403},
{"PUT", base + "/regions", "org-admin", "qa-organization", "https://untrusted.invalid", "{}", 403},
{"PUT", base + "/regions", "org-admin", "qa-organization", "", `{"updated_by":"forged"}`, 400},
{"PUT", base + "/regions", "org-admin", "qa-organization", "", `{} {}`, 400},
{"PUT", base + "/regions", "org-admin", "qa-organization", "", `{}`, 400},
{"PUT", base + "/regions", "org-admin", "qa-organization", "", `{"directory_id":"d","base_revision":"","rules":null}`, 400},
{"PUT", base + "/regions", "org-admin", "qa-organization", "", `{"directory_id":"d","base_revision":"","rules":[]}`, 200},
{"POST", base + "/preview", "org-admin", "qa-organization", "", `{"directory_id":"d","base_revision":"","rules":[]}`, 200},
} {
req := httptest.NewRequest(tc.method, tc.path, strings.NewReader(tc.body))
if tc.token != "" {
req.AddCookie(&http.Cookie{Name: sessionCookieName, Value: tc.token})
}
req.Header.Set("X-Governance-Action", tc.action)
req.Header.Set("Origin", tc.origin)
res := httptest.NewRecorder()
handler.ServeHTTP(res, req)
if res.Code != tc.status {
t.Fatalf("%s %s got %d want %d: %s", tc.method, tc.path, res.Code, tc.status, res.Body.String())
}
}
if spy.calls != 3 || spy.actor == "" || spy.actor == "forged" {
t.Fatalf("invalid requests reached store or actor not stamped: %+v", spy)
}
spy.err = qaopsorg.ErrConflict
req := httptest.NewRequest("PUT", base+"/regions", strings.NewReader(`{"directory_id":"d","base_revision":"","rules":[]}`))
req.AddCookie(&http.Cookie{Name: sessionCookieName, Value: "org-admin"})
req.Header.Set("X-Governance-Action", "qa-organization")
res := httptest.NewRecorder()
handler.ServeHTTP(res, req)
if res.Code != 409 {
t.Fatal("stale configuration not reported as conflict")
}
}
+4
View File
@@ -101,6 +101,7 @@ type Store interface {
}
type Config struct {
QAOrg QAOrgStore
QAOps QAOpsReader
QAOpsTenantKey string
QAOpsEnabled bool
@@ -171,6 +172,9 @@ func NewHandler(config Config) (http.Handler, error) {
config.NewID = newID
}
mux := http.NewServeMux()
mux.HandleFunc("GET /api/v1/qa-ops/organization", func(w http.ResponseWriter, r *http.Request) { qaOrganization(w, r, config) })
mux.HandleFunc("POST /api/v1/qa-ops/organization/preview", func(w http.ResponseWriter, r *http.Request) { qaOrganization(w, r, config) })
mux.HandleFunc("PUT /api/v1/qa-ops/organization/regions", func(w http.ResponseWriter, r *http.Request) { qaOrganization(w, r, config) })
mux.HandleFunc("GET /api/v1/qa-ops/status", func(w http.ResponseWriter, r *http.Request) {
qaOpsStatus(w, r, config)
})