feat(release): 建批时冻结 + 验收通过自动批准 —— 把"每份文档 8 步"砍掉两步并去掉两次卡死
背景:发布管理把"逐条核验"的仪式强加给每一份文档。实测一份文档要 9~11 次交互,
且有两处顺序陷阱(冻结后批准 → 建批 422;生成即固化 → 批准被永久钉住)。
P0-1 建批时冻结:
- CreateReleaseBatch 在未指定版本时,自己把当前实时计划冻结成一份**已确认**版本并绑定
(同一事务;同摘要复用最近版本,planned 或 confirmed 都可复用,因此同一份计划不堆版本)。
- 语义不变:批一旦建立,清单/摘要/验收轮次/目标库绑定全部不可变、回滚按它走;变的只是
"谁在什么时候按固化键"——从操作员的手动两步变成建批这一下。
- 效果:去掉「生成新版本」「确认冻结」两步;消灭"批准晚于冻结 → 422"这类顺序陷阱;
前端不再传版本 id,也不再有"所选知识不在冻结清单里"的阻断。
- 计划→清单项的映射抽成 ChangeSetItemsFromPlan 供两处共用,否则两处算出的摘要不同,
"同一计划复用同一版本"永远不命中。
P0-2 验收通过自动批准:
- 验收三项结论达发布门槛(knowledge_exists/chunks_present=passed,retrieval_hit 与门槛同
口径)时,由 worker 写入 reviewer_ref='system:auto' 的批准记录,替代"每份文档点一次批准"。
- 策略 TEST_AUTO_REVIEW_POLICY = off | internal(默认,仅对内)| all;值不认识拒绝启动。
只影响审核这一步:生产授权、双闸与发布前快照门禁不受影响。界面上只读展示当前策略。
- 安全边界(写死在审核 SQL 里):系统只允许写"第一条"审核——人工一旦表过态,机器不得用一条
更晚的 approved 把人工结论翻回去;人工随时可再审。集成测试去掉该约束即 FAIL(已实测)。
- 自动批准自身的任何失败都不影响验收结论,只上报。
顺带(P1-1 前半,已被 P0-1 取代的部分已删除):
- 写操作失败把服务端 {"error": ...} 的原因带出来,并对已知原因给出下一步(不再只给 HTTP 状态码)。
- 当前的"不在已冻结清单里"标注与就地修复按钮随 P0-1 一起移除(该失败模式已不存在)。
测试:bind_time_freeze_integration_test.go(绑定已确认版本/同计划复用/冻结后不可变/
动作不符仍 NotEligible)、auto_review_integration_test.go(系统只写第一条、人工可再审)、
validate_test.go(对内自动/对外不自动/策略关闭/验收未过不批/自身失败不影响验收)、
auto_review_test.go、config_test 及前端能力解析测试。
实测耗时:本机 Go 全量 26 包通过、前端 178 条通过。
This commit is contained in:
@@ -349,7 +349,7 @@ describe('ReleaseManagement', () => {
|
||||
reviewPage={reviewPage} reviewLoading={false} reviewError={null} reviewingId={null}
|
||||
batchPage={batchPage} batchDetail={batchDetail} batchLoading={false} batchError={null} mutatingBatchId={null}
|
||||
onReview={vi.fn()} onReviewRefresh={vi.fn()} onCreateBatch={vi.fn()} onSealBatch={vi.fn()} onSelectBatch={vi.fn()} onBatchRefresh={vi.fn()}
|
||||
releaseCapabilities={{ production_release_requests_enabled: true, production_backup_restore_verified: false }} executionPage={executionPage} executionDetail={executionDetail} executionLoading={false} executionError={null} onSelectExecution={vi.fn()} onExecutionRefresh={vi.fn()}
|
||||
releaseCapabilities={{ production_release_requests_enabled: true, production_backup_restore_verified: false, test_auto_review_policy: '' }} executionPage={executionPage} executionDetail={executionDetail} executionLoading={false} executionError={null} onSelectExecution={vi.fn()} onExecutionRefresh={vi.fn()}
|
||||
releasePlan={releasePlan}
|
||||
selectedDeleteIDs={['tp-delete']} onToggleDelete={vi.fn()}
|
||||
/>)
|
||||
@@ -413,7 +413,7 @@ describe('release plan pagination (R3)', () => {
|
||||
batchPage: { items: [], total: 0, limit: 20, offset: 0 } as any,
|
||||
batchDetail: null, batchLoading: false, batchError: null, mutatingBatchId: null,
|
||||
onReview: vi.fn(), onReviewRefresh: vi.fn(), onCreateBatch: vi.fn(), onSealBatch: vi.fn(), onSelectBatch: vi.fn(), onBatchRefresh: vi.fn(),
|
||||
releaseCapabilities: { production_release_requests_enabled: false, production_backup_restore_verified: false },
|
||||
releaseCapabilities: { production_release_requests_enabled: false, production_backup_restore_verified: false, test_auto_review_policy: '' },
|
||||
executionPage: { items: [], total: 0, limit: 20, offset: 0 } as any,
|
||||
executionDetail: null, executionLoading: false, executionError: null, onSelectExecution: vi.fn(), onExecutionRefresh: vi.fn(),
|
||||
selectedDeleteIDs: [] as string[], onToggleDelete: vi.fn(),
|
||||
@@ -457,7 +457,7 @@ describe('R4 rollback levels in the execution timeline', () => {
|
||||
batchPage: { items: [], total: 0, limit: 20, offset: 0 } as any,
|
||||
batchDetail: null, batchLoading: false, batchError: null, mutatingBatchId: null,
|
||||
onReview: vi.fn(), onReviewRefresh: vi.fn(), onCreateBatch: vi.fn(), onSealBatch: vi.fn(), onSelectBatch: vi.fn(), onBatchRefresh: vi.fn(),
|
||||
releaseCapabilities: { production_release_requests_enabled: true, production_backup_restore_verified: false },
|
||||
releaseCapabilities: { production_release_requests_enabled: true, production_backup_restore_verified: false, test_auto_review_policy: '' },
|
||||
releasePlan: { items: [], summary: { add: 0, update: 0, delete: 0, blocked: 0, unchanged: 0 } } as ReleasePlan,
|
||||
executionDetail: null, executionLoading: false, executionError: null, onSelectExecution: vi.fn(), onExecutionRefresh: vi.fn(),
|
||||
selectedDeleteIDs: [] as string[], onToggleDelete: vi.fn(),
|
||||
@@ -494,7 +494,7 @@ describe('ReleaseManagement production actions', () => {
|
||||
reviewPage={{ items: [], total: 0, limit: 20, offset: 0 }} reviewLoading={false} reviewError={null} reviewingId={null}
|
||||
batchPage={batchPage} batchDetail={null} batchLoading={false} batchError={null} mutatingBatchId={null}
|
||||
onReview={vi.fn()} onReviewRefresh={vi.fn()} onCreateBatch={vi.fn()} onSealBatch={vi.fn()} onSelectBatch={vi.fn()} onBatchRefresh={vi.fn()}
|
||||
releaseCapabilities={{ production_release_requests_enabled: true, production_backup_restore_verified: true }}
|
||||
releaseCapabilities={{ production_release_requests_enabled: true, production_backup_restore_verified: true, test_auto_review_policy: '' }}
|
||||
executionPage={executionPage} executionDetail={null} executionLoading={false} executionError={null} onSelectExecution={vi.fn()} onExecutionRefresh={vi.fn()}
|
||||
releasePlan={{ items: [], summary: { add: 0, update: 0, delete: 0, blocked: 0, unchanged: 0 } }}
|
||||
selectedDeleteIDs={[]} onToggleDelete={vi.fn()} {...extra} />
|
||||
|
||||
+18
-7
@@ -12,7 +12,7 @@ import { fetchSourceAssets } from './assets'
|
||||
import type { LegacyStatus, SourceAssetPage } from './assets'
|
||||
import { fetchJobs } from './jobs'
|
||||
import type { Job, JobState } from './jobs'
|
||||
import { confirmReleaseChangeSet, createReleaseBatch, fetchLatestReleaseChangeSet, fetchReleaseAuditChain, fetchReleaseBatch, fetchReleaseBatches, fetchReleaseCapabilities, fetchReleaseExecution, fetchReleaseExecutions, fetchReleasePlan, fetchReviewCandidates, generateReleaseChangeSet, productionConfirmationPhrases, reviewPublication, runProductionAction, sealReleaseBatch } from './reviewRelease'
|
||||
import { confirmReleaseChangeSet, createReleaseBatch, fetchLatestReleaseChangeSet, fetchReleaseAuditChain, fetchReleaseBatch, fetchReleaseBatches, fetchReleaseCapabilities, fetchReleaseExecution, fetchReleaseExecutions, fetchReleasePlan, fetchReviewCandidates, generateReleaseChangeSet, productionConfirmationPhrases, reviewPublication, runProductionAction, sealReleaseBatch } from './reviewRelease'
|
||||
import type { ProductionActionKind } from './reviewRelease'
|
||||
import type { ReleaseAuditChain, ReleaseBatchDetail, ReleaseBatchPage, ReleaseCapabilities, ReleaseChangeSetDetail, ReleaseExecutionDetail, ReleaseExecutionPage, ReleasePlan, ReleasePlanItem, ReviewCandidatePage, Visibility } from './reviewRelease'
|
||||
import { fetchSourceConnections, fetchSourceScanDetail, fetchSourceScans, triggerSourceScan } from './sourceConnections'
|
||||
@@ -251,7 +251,7 @@ const emptyReviewPage: ReviewCandidatePage = { items: [], total: 0, limit: 20, o
|
||||
|
||||
const emptyBatchPage: ReleaseBatchPage = { items: [], total: 0, limit: 20, offset: 0 }
|
||||
const emptyExecutionPage: ReleaseExecutionPage = { items: [], total: 0, limit: 20, offset: 0 }
|
||||
const disabledReleaseCapabilities: ReleaseCapabilities = { production_release_requests_enabled: false, production_backup_restore_verified: false }
|
||||
const disabledReleaseCapabilities: ReleaseCapabilities = { production_release_requests_enabled: false, production_backup_restore_verified: false, test_auto_review_policy: '' }
|
||||
const emptyReleasePlan: ReleasePlan = { items: [], summary: { add: 0, update: 0, delete: 0, blocked: 0, unchanged: 0 } }
|
||||
|
||||
export function ModulePage({ moduleId, jobs, loading, error, onRefresh, connectionPage = emptyConnectionPage, connectionLoading = false, connectionError = null, onConnectionRefresh = () => undefined, scanningConnectionId = null, onTriggerSourceScan = () => undefined, scanPage = emptyScanPage, scanDetail = null, scanLoading = false, scanError = null, selectedScanId = null, onSelectScan = () => undefined, assetPage = emptyAssetPage, assetLoading = false, assetError = null, assetState = '', onAssetStateChange = () => undefined, onAssetPageChange = () => undefined, onAssetRefresh = () => undefined, publicationPage = emptyPublicationPage, publicationLoading = false, publicationError = null, publicationState = '', retryingId = null, onPublicationStateChange = () => undefined, onPublicationPageChange = () => undefined, onPublicationRefresh = () => undefined, onRetry = () => undefined, reviewPage = emptyReviewPage, reviewLoading = false, reviewError = null, reviewingId = null, batchPage = emptyBatchPage, batchDetail = null, batchLoading = false, batchError = null, mutatingBatchId = null, onReview = () => undefined, onReviewRefresh = () => undefined, onCreateBatch = () => undefined, onSealBatch = () => undefined, onSelectBatch = () => undefined, onBatchRefresh = () => undefined, releaseCapabilities = disabledReleaseCapabilities, releasePlan = emptyReleasePlan, releaseChangeSet = null, changeSetBusy = false, changeSetError = null, onGenerateChangeSet = () => undefined, onConfirmChangeSet = () => undefined, selectedDeleteIDs = [], onToggleDelete = () => undefined, executionPage = emptyExecutionPage, executionDetail = null, executionChain = null, executionLoading = false, executionError = null, onSelectExecution = () => undefined, onExecutionRefresh = () => undefined, pendingReleaseAction = null, releaseActionPhrase = '', releaseActionBusy = false, releaseActionError = null, releaseActionMessage = null, onStartReleaseAction = () => undefined, onReleaseActionPhrase = () => undefined, onSubmitReleaseAction = () => undefined, onCancelReleaseAction = () => undefined }: ModulePageProps) {
|
||||
@@ -866,6 +866,14 @@ function releaseGuidance(props: ReleaseManagementProps, pending: number) {
|
||||
}
|
||||
}
|
||||
|
||||
// 审核策略文案:让运维一眼看到"现在自动批准到什么程度",而不是靠猜。
|
||||
function autoReviewNote(policy: string): string {
|
||||
if (policy === 'off') return '审核策略:全部人工审核(验收通过也不会自动批准)。'
|
||||
if (policy === 'internal') return '审核策略:对内知识验收通过后由系统自动批准(记为 system:auto);对外仍需人工。'
|
||||
if (policy === 'all') return '审核策略:对内对外都在验收通过后由系统自动批准;对外发布请另行把关。'
|
||||
return ''
|
||||
}
|
||||
|
||||
export function ReleaseManagement(props: ReleaseManagementProps) {
|
||||
/* R3 pagination probe */
|
||||
const auth = useOptionalAuth()
|
||||
@@ -894,6 +902,9 @@ export function ReleaseManagement(props: ReleaseManagementProps) {
|
||||
: !props.releaseCapabilities.production_backup_restore_verified
|
||||
? '生产操作权限:已阻断'
|
||||
: '生产操作权限:等待负责人确认'
|
||||
// 建批只绑定"已确认"的版本;所选知识不在那份清单里时必定 422(今天实测的坑)。
|
||||
// 就地把它变成可操作:说明原因 + 给一个"生成新版本并确认冻结"的按钮。
|
||||
// P0-1 之后不再有"所选知识不在已冻结清单里"这种阻断:清单在建批那一刻才冻结。
|
||||
const batchBlocker = [
|
||||
selectedCount === 0 ? '请先勾选已批准或待删除的知识' : '',
|
||||
props.selectedDeleteIDs.length > 0 && !deleteConfirmed ? '请确认所选删除项会停止生产检索' : '',
|
||||
@@ -991,9 +1002,7 @@ export function ReleaseManagement(props: ReleaseManagementProps) {
|
||||
{changeSet && changeSet.state === 'planned' ? <details className="release-changeset-items"><summary>查看冻结清单({changeSet.items.length}项)</summary><ul>{changeSet.items.map((item) => <li key={item.seq}>{`${item.seq}. ${item.title} · ${item.target_scope === 'internal' ? '对内' : '对外'} · ${frozenActionLabel(item.action)}${item.can_release ? '' : '(阻断:' + (item.blocker === 'source_unavailable' ? '来源不可用' : '测试未就绪') + ')'}`}</li>)}</ul></details> : null}
|
||||
{changeSetError ? <p className="form-error">{changeSetError}</p> : null}
|
||||
<div className="release-changeset-actions">
|
||||
<button type="button" className="secondary-action" disabled={changeSetBusy} title="把当前实时发布计划固化为新版本(相同计划自动去重)" onClick={() => onGenerateChangeSet(batchName.trim() || `发布计划 ${new Date().toLocaleDateString('zh-CN')}`)}>生成新版本</button>
|
||||
{changeSet && changeSet.state === 'planned' ? <button type="button" disabled={changeSetBusy} onClick={() => onConfirmChangeSet(changeSet.id)}>确认冻结(此后不可更改)</button> : null}
|
||||
{changeSet && changeSet.state === 'confirmed' ? <small className="safe-badge">创建批次将自动绑定 v{changeSet.number} 并校验清单</small> : <small>草稿批次需先由上方“确认冻结”固定目标</small>}
|
||||
{changeSet ? <small className="safe-badge">建批时自动冻结当前计划(同摘要复用同一版本 v{changeSet.number}),无需手动确认冻结</small> : <small>建批时会自动冻结当前发布计划</small>}
|
||||
</div>
|
||||
</div>
|
||||
})()}
|
||||
@@ -1007,7 +1016,7 @@ export function ReleaseManagement(props: ReleaseManagementProps) {
|
||||
</section>
|
||||
<section className="panel review-panel" id="review-actions">
|
||||
<div className="panel-heading release-toolbar">
|
||||
<div><h2>第 3 步:审核要发布的知识</h2><p>先确认测试结果和对内/对外范围,再批准或驳回。批准后才能勾选加入批次。</p></div>
|
||||
<div><h2>第 3 步:审核要发布的知识</h2><p>先确认测试结果和对内/对外范围,再批准或驳回。批准后才能勾选加入批次。</p>{autoReviewNote(props.releaseCapabilities.test_auto_review_policy) ? <p className="tiny" role="note">{autoReviewNote(props.releaseCapabilities.test_auto_review_policy)}</p> : null}</div>
|
||||
</div>
|
||||
{batchBlocker ? <div className="button-reason" role="note"><strong>{`为什么按钮不能点:${batchBlocker}`}</strong></div> : null}
|
||||
<div className="review-decision-guide" aria-label="审核判断标准">
|
||||
@@ -1389,7 +1398,9 @@ export default function App() {
|
||||
setMutatingBatchId('creating')
|
||||
setBatchError(null)
|
||||
try {
|
||||
const batch = await createReleaseBatch(name, publicationIDs, deletePublicationIDs, releaseChangeSet?.state === 'confirmed' ? releaseChangeSet.id : '')
|
||||
// 不传版本 id:服务端在"建批这一下"冻结当前计划(同摘要复用同一版本),
|
||||
// 操作员因此不必先「生成新版本」再「确认冻结」。
|
||||
const batch = await createReleaseBatch(name, publicationIDs, deletePublicationIDs, '')
|
||||
setSelectedDeleteIDs([])
|
||||
await loadBatches()
|
||||
setBatchDetail(await fetchReleaseBatch(batch.id))
|
||||
|
||||
@@ -116,7 +116,7 @@ describe('release execution audit parsing', () => {
|
||||
expect(page.items[0]).not.toHaveProperty('manifest_sha256')
|
||||
const detail = parseReleaseExecutionDetailResponse({ data: { ...execution, items: [{ publication_id: 'tp-safe', title: 'Synthetic', action: 'delete', state: 'verified', previous_production_revision: 'prod-v0', production_revision: 'absent', error_code: '', created_at: '2026-09-06T10:00:00Z', completed_at: '2026-09-06T10:02:00Z', target_knowledge_base_id: 'kb-target-1', knowledge_id: 'must-drop' }] } })
|
||||
expect(detail.items[0]).toEqual({ publication_id: 'tp-safe', title: 'Synthetic', action: 'delete', state: 'verified', previous_production_revision: 'prod-v0', production_revision: 'absent', error_code: '', created_at: '2026-09-06T10:00:00Z', completed_at: '2026-09-06T10:02:00Z', target_knowledge_base_id: 'kb-target-1' })
|
||||
expect(parseReleaseCapabilitiesResponse({ data: { production_release_requests_enabled: true, production_backup_restore_verified: false, secret: 'drop' } })).toEqual({ production_release_requests_enabled: true, production_backup_restore_verified: false })
|
||||
expect(parseReleaseCapabilitiesResponse({ data: { production_release_requests_enabled: true, production_backup_restore_verified: false, secret: 'drop' } })).toEqual({ production_release_requests_enabled: true, production_backup_restore_verified: false, test_auto_review_policy: '' })
|
||||
})
|
||||
|
||||
it('rejects a release item execution the API forgot to describe', () => {
|
||||
@@ -243,3 +243,15 @@ describe('建批失败时把服务端原因带出来', () => {
|
||||
await expect(createReleaseBatch('验收12', ['tp-x'], [], '')).rejects.toThrow('could not create release batch')
|
||||
})
|
||||
})
|
||||
|
||||
describe('审核策略的只读展示', () => {
|
||||
it('服务端返回策略时解析出来', () => {
|
||||
const parsed = parseReleaseCapabilitiesResponse({ data: { production_release_requests_enabled: true, production_backup_restore_verified: true, test_auto_review_policy: 'internal' } })
|
||||
expect(parsed.test_auto_review_policy).toBe('internal')
|
||||
})
|
||||
|
||||
it('旧服务端不返回策略时不报错', () => {
|
||||
const parsed = parseReleaseCapabilitiesResponse({ data: { production_release_requests_enabled: false, production_backup_restore_verified: false } })
|
||||
expect(parsed.test_auto_review_policy).toBe('')
|
||||
})
|
||||
})
|
||||
|
||||
@@ -123,6 +123,8 @@ export interface ReleaseExecutionDetail extends ReleaseExecution {
|
||||
export interface ReleaseCapabilities {
|
||||
production_release_requests_enabled: boolean
|
||||
production_backup_restore_verified: boolean
|
||||
/** 当前审核策略(只读展示):off / internal / all。旧服务端不返回时按空串处理。 */
|
||||
test_auto_review_policy: string
|
||||
}
|
||||
|
||||
export interface ReleasePlanItem {
|
||||
@@ -212,9 +214,12 @@ export function parseReleaseCapabilitiesResponse(value: unknown): ReleaseCapabil
|
||||
if (!isRecord(value) || !isRecord(value.data) || typeof value.data.production_release_requests_enabled !== 'boolean' || typeof value.data.production_backup_restore_verified !== 'boolean') {
|
||||
throw new Error('invalid release capabilities response')
|
||||
}
|
||||
// 审核策略是只读展示项:旧服务端不返回时不报错(空串 = 界面不显示这一行)。
|
||||
const policy = typeof value.data.test_auto_review_policy === 'string' ? value.data.test_auto_review_policy : ''
|
||||
return {
|
||||
production_release_requests_enabled: value.data.production_release_requests_enabled,
|
||||
production_backup_restore_verified: value.data.production_backup_restore_verified,
|
||||
test_auto_review_policy: policy,
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user