feat(qa-ops): 按确认口径补齐质量比例与分母明细
build / build (push) Successful in 1m6s

使用完整筛选范围的当前有效结论计算覆盖率和正确率,人工优先,失效与对应待确认/未评估/不计入排除;零分母返回null,界面展示原始分子分母和排除构成,前端拒绝不守恒或比例不一致的响应。

验证:make verify退出码0,Go658及前端257通过,91项声明可选集成跳过;隔离PG、三包竞态及合成/真实只读源浏览器验证通过。无新增迁移,不接AI模型,不改绩效,不写源库;本批未推送或部署,8088运行版保持0.1.21。
This commit is contained in:
姚章浩
2026-10-18 02:00:31 +08:00
parent 4b3aaff321
commit 828c2c5fa0
13 changed files with 367 additions and 11 deletions
+8
View File
@@ -117,6 +117,14 @@ func TestQAQualityDetailListAndWholeScopeCounts(t *testing.T) {
if w.Code != 200 || !strings.Contains(w.Body.String(), `"unreviewed":2`) || source.scopeCalls != 1 || source.tenant != "fixed" || store.calls < 2 {
t.Fatal("quality summary estimated from page instead of scope", w.Code, w.Body.String())
}
var counts struct {
Data struct {
Summary qaopsquality.Summary `json:"summary"`
} `json:"data"`
}
if json.Unmarshal(w.Body.Bytes(), &counts) != nil || counts.Data.Summary.Rates.Coverage.Denominator != 2 || counts.Data.Summary.Rates.Coverage.Numerator != 0 || counts.Data.Summary.Rates.Correctness.Percent != nil {
t.Fatal("confirmed quality metrics were not computed for the whole scope")
}
store.fail = true
w = qualityRequest(h, "GET", "/api/v1/qa-ops/records/fixture-turn", "quality-admin", "")
if w.Code != 503 || !strings.Contains(w.Body.String(), "quality_unavailable") {
+1 -1
View File
@@ -104,7 +104,7 @@ func Project(hash string, epoch, revision int64, automatic Check, review *Review
return view
}
func Summarize(views map[string]View) Summary {
result := Summary{Total: len(views)}
result := Summary{Total: len(views), Rates: ComputeRates(views)}
for _, v := range views {
switch v.State {
case "reviewed":
+7 -6
View File
@@ -64,12 +64,13 @@ type History struct {
NextCheck int64 `json:"next_check"`
}
type Summary struct {
Total int `json:"total"`
Reviewed int `json:"reviewed"`
Unreviewed int `json:"unreviewed"`
Stale int `json:"stale"`
PendingConfirmation int `json:"pending_confirmation"`
RuleUncovered int `json:"rule_uncovered"`
Rates Rates `json:"rates"`
Total int `json:"total"`
Reviewed int `json:"reviewed"`
Unreviewed int `json:"unreviewed"`
Stale int `json:"stale"`
PendingConfirmation int `json:"pending_confirmation"`
RuleUncovered int `json:"rule_uncovered"`
}
type Receipt struct {
View View `json:"view"`
+72
View File
@@ -0,0 +1,72 @@
package qaopsquality
type Rate struct {
Numerator int `json:"numerator"`
Denominator int `json:"denominator"`
Percent *float64 `json:"percent"`
}
type RateBreakdown struct {
Covered int `json:"covered"`
Uncovered int `json:"uncovered"`
Partial int `json:"partial"`
Pending int `json:"pending"`
Unassessed int `json:"unassessed"`
Excluded int `json:"excluded"`
Stale int `json:"stale"`
CoveredCorrect int `json:"covered_correct"`
CoveredIncorrect int `json:"covered_incorrect"`
CoveredPending int `json:"covered_pending"`
CoveredUnassessed int `json:"covered_unassessed"`
}
type Rates struct {
PolicyVersion string `json:"policy_version"`
Coverage Rate `json:"coverage"`
Correctness Rate `json:"correctness"`
Breakdown RateBreakdown `json:"breakdown"`
}
func ComputeRates(views map[string]View) Rates {
out := Rates{PolicyVersion: "quality-rates-human-first-v1"}
b := &out.Breakdown
for _, v := range views {
if v.State == "stale" {
b.Stale++
continue
}
switch v.Effective.Coverage {
case "covered":
b.Covered++
switch v.Effective.Correctness {
case "correct":
b.CoveredCorrect++
case "incorrect":
b.CoveredIncorrect++
case "pending":
b.CoveredPending++
default:
b.CoveredUnassessed++
}
case "uncovered":
b.Uncovered++
case "partial":
b.Partial++
case "pending":
b.Pending++
case "excluded":
b.Excluded++
default:
b.Unassessed++
}
}
out.Coverage = makeRate(b.Covered, b.Covered+b.Uncovered+b.Partial)
out.Correctness = makeRate(b.CoveredCorrect, b.CoveredCorrect+b.CoveredIncorrect)
return out
}
func makeRate(numerator, denominator int) Rate {
r := Rate{Numerator: numerator, Denominator: denominator}
if denominator > 0 {
p := 100 * float64(numerator) / float64(denominator)
r.Percent = &p
}
return r
}
+44
View File
@@ -0,0 +1,44 @@
package qaopsquality
import (
"encoding/json"
"knowledge-governance/internal/dobotaiops"
"math"
"strings"
"testing"
)
func TestQualityRatesUseEffectiveCurrentConclusionsAndExplicitDenominators(t *testing.T) {
views := map[string]View{}
for i, fields := range []Fields{{Coverage: "covered", Correctness: "correct"}, {Coverage: "covered", Correctness: "incorrect"}, {Coverage: "covered", Correctness: "pending"}, {Coverage: "uncovered"}, {Coverage: "partial", Correctness: "correct"}, {Coverage: "pending", Correctness: "correct"}, {}, {Coverage: "excluded", Correctness: "pending"}, {Coverage: "covered", Correctness: "correct"}, {Coverage: "covered"}} {
state := "reviewed"
if i == 3 || i == 6 {
state = "unreviewed"
}
if i == 8 {
state = "stale"
}
views[string(rune('a'+i))] = View{State: state, Effective: fields, Automatic: Check{Result: dobotaiops.CheckAnswerCoverage("暂无已发布")}}
}
r := ComputeRates(views)
if r.PolicyVersion != "quality-rates-human-first-v1" || r.Coverage.Numerator != 4 || r.Coverage.Denominator != 6 || r.Correctness.Numerator != 1 || r.Correctness.Denominator != 2 {
t.Fatal("effective decisions, partial or exclusion scopes incorrect", r)
}
if r.Coverage.Percent == nil || math.Abs(*r.Coverage.Percent-100*float64(4)/6) > 1e-10 || r.Correctness.Percent == nil || *r.Correctness.Percent != 50 {
t.Fatal("ratio value disagrees with raw counts")
}
b := r.Breakdown
if b.Covered+b.Uncovered+b.Partial+b.Pending+b.Unassessed+b.Excluded+b.Stale != len(views) || b.CoveredCorrect+b.CoveredIncorrect+b.CoveredPending+b.CoveredUnassessed != b.Covered {
t.Fatal("denominator breakdown not conserved")
}
if got := Summarize(views); got.Rates.Coverage.Denominator != 6 {
t.Fatal("scope summary did not consume the one shared calculation")
}
}
func TestQualityRatesEmptyScopeHasNullPercent(t *testing.T) {
r := ComputeRates(map[string]View{})
raw, _ := json.Marshal(r)
if r.Coverage.Percent != nil || r.Correctness.Percent != nil || strings.Count(string(raw), `"percent":null`) != 2 {
t.Fatal("zero denominator fabricated zero or full rate")
}
}