From 27828ff21e7c66846ba41ed50894814915fdf36f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=A7=9A=E7=AB=A0=E6=B5=A9?= Date: Fri, 30 Oct 2026 02:03:28 +0800 Subject: [PATCH] =?UTF-8?q?test(worker):=20=E7=BC=96=E6=8E=92=E9=93=BE?= =?UTF-8?q?=E8=B7=AF=E9=87=8C=E5=8C=85=E8=A3=85=E5=B1=82=E5=BF=85=E9=A1=BB?= =?UTF-8?q?=E7=9C=9F=E7=9A=84=E8=A7=A6=E5=8F=91=E5=86=99=E9=9B=86=E5=90=88?= =?UTF-8?q?=E9=A2=84=E6=A3=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 只测“包装体转发”还不够:Run 是按可选接口断言决定要不要预检的。补一条走 libraryrelease.Run + contentTrackedTarget 的用例,断言预检被调用一次、结果 带回编排层、四类写入照常执行。 --- cmd/worker/library_writeset_test.go | 59 +++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/cmd/worker/library_writeset_test.go b/cmd/worker/library_writeset_test.go index 74b46fc..dac7bff 100644 --- a/cmd/worker/library_writeset_test.go +++ b/cmd/worker/library_writeset_test.go @@ -203,3 +203,62 @@ func TestContentTrackedTargetForwardsWriteSetPlanning(t *testing.T) { t.Fatalf("错误必须点名写集合:%v", err) } } + +// 编排路径上的同一个断言:Run 是按 target.(WriteSetPlanner) 决定要不要预检的, +// 所以包装体必须在**真实调用链里**也把预检带上(只测直接调用内层会漏掉这一层)。 +type orchestratorTarget struct { + planned int + applied []libraryrelease.Stage +} + +func (t *orchestratorTarget) Current(context.Context) (libraryrelease.CurrentState, error) { + return libraryrelease.CurrentState{}, nil +} +func (t *orchestratorTarget) Apply(_ context.Context, stage libraryrelease.Stage, _ string) error { + t.applied = append(t.applied, stage) + return nil +} +func (t *orchestratorTarget) Verify(context.Context, libraryrelease.Expectation) error { return nil } +func (t *orchestratorTarget) Restore(context.Context, libraryrelease.BackupRef) error { return nil } +func (t *orchestratorTarget) PlanWriteSet(_ context.Context, plan libraryrelease.WriteSetPlan) (libraryrelease.WriteSet, error) { + t.planned++ + set := libraryrelease.WriteSet{Version: libraryrelease.WriteSetVersion, JobID: plan.JobID, Target: plan.Target, + TenantID: 10001, KnowledgeBaseID: "kb", BackupSnapshotID: plan.BackupSnapshotID, + TargetSnapshotID: plan.TargetSnapshotID, CreatedAt: time.Now().UTC(), + Universe: plan.Universe, + Rows: []libraryrelease.WriteSetRow{{Table: "resources", ID: "res-1"}}} + if err := set.Seal(); err != nil { + return libraryrelease.WriteSet{}, err + } + return set, nil +} + +type stubBackupStore struct{} + +func (stubBackupStore) Prepare(context.Context, string, libraryrelease.CurrentState) (libraryrelease.BackupRef, error) { + return libraryrelease.BackupRef{ID: "backup-1", SnapshotID: "backup-snap", + Universe: map[string]libraryrelease.TableFingerprint{"resources": {Count: 1, Digest: "abc"}}}, nil +} + +func TestRunPlansWriteSetThroughContentTrackedWrapper(t *testing.T) { + inner := &orchestratorTarget{} + tracked := &contentTrackedTarget{inner: inner, onApply: func() {}} + now := time.Now().UTC() + request := libraryrelease.Request{JobID: "job-1", Target: "internal", SnapshotID: "snap-1", + ParamsDigest: "digest-1", Now: now, + Grant: libraryrelease.Grant{Target: "internal", SnapshotID: "snap-1", ParamsDigest: "digest-1", + ExpiresAt: now.Add(time.Hour), AuthorizedBy: "acceptance"}} + outcome := libraryrelease.Run(context.Background(), request, tracked, stubBackupStore{}, nil) + if outcome.State != "succeeded" { + t.Fatalf("outcome = %+v", outcome) + } + if inner.planned != 1 { + t.Fatalf("编排路径没有经过包装层触发写集合预检,planned=%d", inner.planned) + } + if outcome.Backup.WriteSet == nil || outcome.Backup.WriteSet.Digest == "" { + t.Fatalf("预检结果必须带回给编排层(恢复要按它清理):%+v", outcome.Backup) + } + if len(inner.applied) != len(libraryrelease.Stages()) { + t.Fatalf("四类写入必须都执行,applied=%v", inner.applied) + } +}