feat: expose runtime build version
This commit is contained in:
@@ -25,9 +25,16 @@ type AuditService interface {
|
||||
GetTurn(context.Context, string) (audit.TurnDetail, error)
|
||||
}
|
||||
|
||||
type BuildInfo struct {
|
||||
Version string `json:"version"`
|
||||
CommitSHA string `json:"commit_sha"`
|
||||
BuildTime string `json:"build_time"`
|
||||
}
|
||||
|
||||
type Options struct {
|
||||
AuditService AuditService
|
||||
AdminToken string
|
||||
BuildInfo BuildInfo
|
||||
}
|
||||
|
||||
type Server struct {
|
||||
@@ -35,6 +42,7 @@ type Server struct {
|
||||
ingressToken string
|
||||
auditService AuditService
|
||||
adminToken string
|
||||
buildInfo BuildInfo
|
||||
mux *http.ServeMux
|
||||
}
|
||||
|
||||
@@ -58,13 +66,25 @@ func NewWithOptions(service QAService, ingressToken string, opts Options) (*Serv
|
||||
if hasAdminToken && constantTimeTokenEqual(adminToken, ingressToken) {
|
||||
return nil, errors.New("DOBOTAI_ADMIN_TOKEN must differ from DOBOTAI_INGRESS_TOKEN")
|
||||
}
|
||||
buildInfo := opts.BuildInfo
|
||||
if buildInfo.Version == "" {
|
||||
buildInfo.Version = "dev"
|
||||
}
|
||||
if buildInfo.CommitSHA == "" {
|
||||
buildInfo.CommitSHA = "unknown"
|
||||
}
|
||||
if buildInfo.BuildTime == "" {
|
||||
buildInfo.BuildTime = "unknown"
|
||||
}
|
||||
|
||||
s := &Server{
|
||||
service: service, ingressToken: ingressToken,
|
||||
auditService: opts.AuditService, adminToken: adminToken,
|
||||
mux: http.NewServeMux(),
|
||||
buildInfo: buildInfo,
|
||||
mux: http.NewServeMux(),
|
||||
}
|
||||
s.mux.HandleFunc("GET /healthz", s.health)
|
||||
s.mux.HandleFunc("GET /version", s.version)
|
||||
s.mux.HandleFunc("POST /v1/qa", s.authorizeToken(s.ingressToken, s.ask))
|
||||
if hasAuditService {
|
||||
s.mux.HandleFunc("GET /v1/admin/audit/turns", s.authorizeToken(s.adminToken, s.listAuditTurns))
|
||||
@@ -102,6 +122,11 @@ func (s *Server) health(w http.ResponseWriter, _ *http.Request) {
|
||||
writeJSON(w, http.StatusOK, map[string]string{"status": "ok"})
|
||||
}
|
||||
|
||||
func (s *Server) version(w http.ResponseWriter, _ *http.Request) {
|
||||
w.Header().Set("Cache-Control", "no-store")
|
||||
writeJSON(w, http.StatusOK, s.buildInfo)
|
||||
}
|
||||
|
||||
func (s *Server) ask(w http.ResponseWriter, r *http.Request) {
|
||||
r.Body = http.MaxBytesReader(w, r.Body, 1<<20)
|
||||
defer r.Body.Close()
|
||||
|
||||
@@ -25,6 +25,46 @@ func (f *captureQA) Ask(_ context.Context, request core.QARequest) (core.QAResul
|
||||
return core.QAResult{TurnID: "turn-capture", Answer: "answer"}, nil
|
||||
}
|
||||
|
||||
func TestVersionEndpointReturnsBuildMetadataWithoutAuthentication(t *testing.T) {
|
||||
server, err := NewWithOptions(fakeQA{}, "ingress-secret", Options{
|
||||
BuildInfo: BuildInfo{
|
||||
Version: "2.1.0",
|
||||
CommitSHA: "abc123def456",
|
||||
BuildTime: "2026-07-27T12:00:00Z",
|
||||
},
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
request := httptest.NewRequest(http.MethodGet, "/version", nil)
|
||||
result := httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(result, request)
|
||||
if result.Code != http.StatusOK {
|
||||
t.Fatalf("status=%d body=%s", result.Code, result.Body.String())
|
||||
}
|
||||
if got := result.Header().Get("Cache-Control"); got != "no-store" {
|
||||
t.Fatalf("Cache-Control=%q, want no-store", got)
|
||||
}
|
||||
want := `{"version":"2.1.0","commit_sha":"abc123def456","build_time":"2026-07-27T12:00:00Z"}`
|
||||
if got := strings.TrimSpace(result.Body.String()); got != want {
|
||||
t.Fatalf("body=%s, want %s", got, want)
|
||||
}
|
||||
}
|
||||
|
||||
func TestVersionEndpointUsesSafeDefaults(t *testing.T) {
|
||||
server, err := New(fakeQA{}, "ingress-secret")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
request := httptest.NewRequest(http.MethodGet, "/version", nil)
|
||||
result := httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(result, request)
|
||||
want := `{"version":"dev","commit_sha":"unknown","build_time":"unknown"}`
|
||||
if got := strings.TrimSpace(result.Body.String()); result.Code != http.StatusOK || got != want {
|
||||
t.Fatalf("status=%d body=%s, want %s", result.Code, got, want)
|
||||
}
|
||||
}
|
||||
|
||||
func TestQAEndpointRequiresTokenAndReturnsResult(t *testing.T) {
|
||||
server, err := New(fakeQA{}, "ingress-secret")
|
||||
if err != nil {
|
||||
|
||||
Reference in New Issue
Block a user