Files
Enterprise-Knowledge-Base/internal/im/wecom/reconnect_test.go
T
wizardchen 6c1442aaf9 fix(im): clamp reconnect backoff to avoid int64 overflow → busy loop
After ~34 failed reconnects, math.Pow(2, attempt-1) * baseDelay overflowed
int64 and produced a negative time.Duration, which bypassed the max-delay
cap. time.After(-1s) fires immediately, so a single bad credential (e.g.
WeCom bot_id/secret error 853000) turned into thousands of reconnects
per minute and massive log spam ("reconnecting in -1s (attempt 4601)").

Replace math.Pow with a bit-shift and cap the exponent at 30, which is
well above the shift needed to reach the 30s max delay. Same fix applied
to the WeChat long-poll client. Added a regression test that exercises
attempt=4601.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-05 00:36:18 +08:00

38 lines
1.2 KiB
Go
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
package wecom
import (
"testing"
"time"
)
// TestReconnectDelayOverflow guards against the bug where large attempt
// counters produced a negative time.Duration, bypassing the max-delay
// cap and causing a busy reconnect loop (e.g. "reconnecting in -1s").
func TestReconnectDelayOverflow(t *testing.T) {
tests := []struct {
name string
attempt int
want time.Duration
}{
{"zero attempt clamps to base", 0, defaultReconnectBaseDelay},
{"negative attempt clamps to base", -5, defaultReconnectBaseDelay},
{"attempt 1 = base", 1, defaultReconnectBaseDelay},
{"attempt 2 = 2× base", 2, 2 * defaultReconnectBaseDelay},
{"attempt 5 = 16s", 5, 16 * time.Second},
{"attempt 6 caps at max", 6, defaultReconnectMaxDelay},
{"attempt 100 caps at max", 100, defaultReconnectMaxDelay},
{"attempt 4601 caps at max (regression)", 4601, defaultReconnectMaxDelay},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := reconnectDelay(tt.attempt)
if got != tt.want {
t.Errorf("reconnectDelay(%d) = %v, want %v", tt.attempt, got, tt.want)
}
if got <= 0 {
t.Errorf("reconnectDelay(%d) returned non-positive %v — would cause busy loop", tt.attempt, got)
}
})
}
}