Files
Enterprise-Knowledge-Base/internal/application/repository/chunk_sqlite_test.go
T
swim2sun d2c6814f22 fix: SQLite/Lite mode compatibility for FAQ import and chunk operations
Multiple fixes for WeKnora Lite mode (SQLite, no Redis):

1. Redis nil pointer panic on FAQ import (knowledge.go)
   - Add in-memory fallback (sync.Map) for FAQ import progress tracking
   - Add nil guards for running task locks and progress queries

2. seq_id not auto-incrementing in SQLite (chunk.go, tag.go)
   - GORM autoIncrement on non-PK columns doesn't work in SQLite
   - Add AssignChunkSeqIDs() to pre-assign seq_ids before batch insert
   - Add BeforeCreate hook for KnowledgeTag
   - Use Unscoped() to include soft-deleted records in MAX(seq_id) query

3. NOW() function not available in SQLite (chunk.go)
   - Replace raw SQL NOW() with time.Now() or datetime('now')
   - Use dialector check for raw SQL that must differ between PG and SQLite

4. FAQ KB should reject file uploads (knowledge.go)
   - Add kb.Type == "faq" check in CreateKnowledgeFromFile

5. Linux/macOS build compatibility (Makefile)
   - Conditionally apply macOS-only linker flag based on uname

6. Add SQLite integration tests (chunk_sqlite_test.go)
   - TestCreateChunks_SQLite_SeqIDAutoAssigned
   - TestCreateChunks_SQLite_SeqIDContinuesFromExisting
   - TestCreateChunks_SQLite_SeqIDUniqueAcrossKBs
   - TestCreateChunks_SQLite_SeqIDAfterSoftDelete
   - TestKnowledgeTag_SQLite_SeqIDAutoAssigned
   - TestUpdateChunk_SQLite_NoNOWError

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-15 20:37:10 +08:00

218 lines
6.1 KiB
Go

package repository
import (
"context"
"testing"
"github.com/Tencent/WeKnora/internal/types"
"github.com/google/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gorm.io/driver/sqlite"
"gorm.io/gorm"
)
// setupChunkTestDB creates an in-memory SQLite database with chunk and tag tables.
func setupChunkTestDB(t *testing.T) *gorm.DB {
t.Helper()
db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
require.NoError(t, err)
require.NoError(t, db.AutoMigrate(&types.Chunk{}, &types.KnowledgeTag{}))
return db
}
func makeChunk(kbID, knowledgeID string, chunkType string) *types.Chunk {
return &types.Chunk{
ID: uuid.New().String(),
TenantID: 1,
KnowledgeBaseID: kbID,
KnowledgeID: knowledgeID,
Content: "test content",
ChunkType: chunkType,
IsEnabled: true,
}
}
func TestCreateChunks_SQLite_SeqIDAutoAssigned(t *testing.T) {
db := setupChunkTestDB(t)
repo := NewChunkRepository(db)
ctx := context.Background()
kbID := uuid.New().String()
knowledgeID := uuid.New().String()
// Create a batch of 5 chunks
chunks := []*types.Chunk{
makeChunk(kbID, knowledgeID, "faq"),
makeChunk(kbID, knowledgeID, "faq"),
makeChunk(kbID, knowledgeID, "faq"),
makeChunk(kbID, knowledgeID, "faq"),
makeChunk(kbID, knowledgeID, "faq"),
}
err := repo.CreateChunks(ctx, chunks)
require.NoError(t, err)
// Verify all chunks got unique sequential seq_ids
var saved []types.Chunk
require.NoError(t, db.Order("seq_id").Find(&saved).Error)
assert.Len(t, saved, 5)
for i, c := range saved {
assert.Equal(t, int64(i+1), c.SeqID, "chunk %d should have seq_id %d", i, i+1)
}
}
func TestCreateChunks_SQLite_SeqIDContinuesFromExisting(t *testing.T) {
db := setupChunkTestDB(t)
repo := NewChunkRepository(db)
ctx := context.Background()
kbID := uuid.New().String()
knowledgeID := uuid.New().String()
// Create first batch
batch1 := []*types.Chunk{
makeChunk(kbID, knowledgeID, "faq"),
makeChunk(kbID, knowledgeID, "faq"),
makeChunk(kbID, knowledgeID, "faq"),
}
require.NoError(t, repo.CreateChunks(ctx, batch1))
// Create second batch - seq_ids should continue from 3
batch2 := []*types.Chunk{
makeChunk(kbID, knowledgeID, "faq"),
makeChunk(kbID, knowledgeID, "faq"),
}
require.NoError(t, repo.CreateChunks(ctx, batch2))
var saved []types.Chunk
require.NoError(t, db.Order("seq_id").Find(&saved).Error)
assert.Len(t, saved, 5)
for i, c := range saved {
assert.Equal(t, int64(i+1), c.SeqID, "chunk %d should have seq_id %d", i, i+1)
}
}
func TestCreateChunks_SQLite_SeqIDUniqueAcrossKBs(t *testing.T) {
db := setupChunkTestDB(t)
repo := NewChunkRepository(db)
ctx := context.Background()
kb1 := uuid.New().String()
kb2 := uuid.New().String()
k1 := uuid.New().String()
k2 := uuid.New().String()
// Create chunks in two different knowledge bases
require.NoError(t, repo.CreateChunks(ctx, []*types.Chunk{
makeChunk(kb1, k1, "faq"),
makeChunk(kb1, k1, "faq"),
}))
require.NoError(t, repo.CreateChunks(ctx, []*types.Chunk{
makeChunk(kb2, k2, "faq"),
makeChunk(kb2, k2, "faq"),
}))
// All seq_ids should be globally unique (1,2,3,4)
var saved []types.Chunk
require.NoError(t, db.Order("seq_id").Find(&saved).Error)
assert.Len(t, saved, 4)
seqIDs := map[int64]bool{}
for _, c := range saved {
assert.NotZero(t, c.SeqID)
assert.False(t, seqIDs[c.SeqID], "seq_id %d should be unique", c.SeqID)
seqIDs[c.SeqID] = true
}
}
func TestKnowledgeTag_SQLite_SeqIDAutoAssigned(t *testing.T) {
db := setupChunkTestDB(t)
ctx := context.Background()
kbID := uuid.New().String()
// Create tags one by one (as the application does)
tag1 := &types.KnowledgeTag{
ID: uuid.New().String(),
TenantID: 1,
KnowledgeBaseID: kbID,
Name: "tag1",
}
tag2 := &types.KnowledgeTag{
ID: uuid.New().String(),
TenantID: 1,
KnowledgeBaseID: kbID,
Name: "tag2",
}
require.NoError(t, db.WithContext(ctx).Create(tag1).Error)
require.NoError(t, db.WithContext(ctx).Create(tag2).Error)
// Both should have non-zero, unique seq_ids
assert.NotZero(t, tag1.SeqID)
assert.NotZero(t, tag2.SeqID)
assert.NotEqual(t, tag1.SeqID, tag2.SeqID)
}
func TestCreateChunks_SQLite_SeqIDAfterSoftDelete(t *testing.T) {
db := setupChunkTestDB(t)
repo := NewChunkRepository(db)
ctx := context.Background()
kbID := uuid.New().String()
knowledgeID := uuid.New().String()
// Create first batch
batch1 := []*types.Chunk{
makeChunk(kbID, knowledgeID, "faq"),
makeChunk(kbID, knowledgeID, "faq"),
makeChunk(kbID, knowledgeID, "faq"),
}
require.NoError(t, repo.CreateChunks(ctx, batch1))
// Soft-delete all chunks (like frontend "clear" does)
require.NoError(t, db.Where("knowledge_base_id = ?", kbID).Delete(&types.Chunk{}).Error)
// Verify soft-deleted
var activeCount int64
db.Model(&types.Chunk{}).Where("knowledge_base_id = ?", kbID).Count(&activeCount)
assert.Equal(t, int64(0), activeCount, "all chunks should be soft-deleted")
// Create second batch — seq_ids must NOT conflict with soft-deleted ones
batch2 := []*types.Chunk{
makeChunk(kbID, knowledgeID, "faq"),
makeChunk(kbID, knowledgeID, "faq"),
}
err := repo.CreateChunks(ctx, batch2)
require.NoError(t, err, "should not get UNIQUE constraint error after soft delete")
// Verify new seq_ids start after the soft-deleted max (3)
var saved []types.Chunk
require.NoError(t, db.Order("seq_id").Find(&saved).Error)
assert.Len(t, saved, 2)
assert.Equal(t, int64(4), saved[0].SeqID)
assert.Equal(t, int64(5), saved[1].SeqID)
}
func TestUpdateChunk_SQLite_NoNOWError(t *testing.T) {
db := setupChunkTestDB(t)
ctx := context.Background()
kbID := uuid.New().String()
knowledgeID := uuid.New().String()
chunk := makeChunk(kbID, knowledgeID, "faq")
require.NoError(t, db.WithContext(ctx).Create(chunk).Error)
// Test updating a chunk field — verifies no NOW() related errors
err := db.WithContext(ctx).Model(chunk).Update("content", "updated content").Error
assert.NoError(t, err)
var saved types.Chunk
require.NoError(t, db.First(&saved, "id = ?", chunk.ID).Error)
assert.Equal(t, "updated content", saved.Content)
}