f2e8e3f56c
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
131 lines
3.7 KiB
Go
131 lines
3.7 KiB
Go
package contextcmd
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
)
|
|
|
|
func TestUse_OK(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
out, _ := iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "staging",
|
|
Contexts: map[string]config.Context{
|
|
"staging": {Host: "https://staging.example.com"},
|
|
"production": {Host: "https://prod.example.com"},
|
|
},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save initial config: %v", err)
|
|
}
|
|
|
|
if err := runUse("production", nil); err != nil {
|
|
t.Fatalf("runUse: %v", err)
|
|
}
|
|
|
|
got, err := config.Load()
|
|
if err != nil {
|
|
t.Fatalf("reload: %v", err)
|
|
}
|
|
if got.CurrentContext != "production" {
|
|
t.Errorf("CurrentContext = %q, want production", got.CurrentContext)
|
|
}
|
|
if !strings.Contains(out.String(), "production") {
|
|
t.Errorf("output should mention switched-to context, got %q", out.String())
|
|
}
|
|
}
|
|
|
|
func TestUse_NotFound_WithDidYouMean(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{Contexts: map[string]config.Context{
|
|
"production": {Host: "https://prod"},
|
|
"staging": {Host: "https://staging"},
|
|
}}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
err := runUse("prodution", nil) // typo: missing 'c'
|
|
if err == nil {
|
|
t.Fatal("expected error")
|
|
}
|
|
cm, ok := err.(*cmdutil.Error)
|
|
if !ok {
|
|
t.Fatalf("expected *cmdutil.Error, got %T", err)
|
|
}
|
|
if cm.Code != cmdutil.CodeLocalContextNotFound {
|
|
t.Errorf("code = %q, want %q", cm.Code, cmdutil.CodeLocalContextNotFound)
|
|
}
|
|
if cm.Hint != `did you mean: "production"?` {
|
|
t.Errorf("hint should be exact `did you mean: \"production\"?`, got %q", cm.Hint)
|
|
}
|
|
}
|
|
|
|
// TestUse_NotFound_DeterministicTieBreak guards against map-iteration-order
|
|
// flake: when two candidates have equal levenshtein distance, the suggestion
|
|
// must be reproducibly the lexicographically-smaller one.
|
|
func TestUse_NotFound_DeterministicTieBreak(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
_, _ = iostreams.SetForTest(t)
|
|
cfg := &config.Config{Contexts: map[string]config.Context{
|
|
"prod": {Host: "https://a"},
|
|
"prom": {Host: "https://b"},
|
|
"prog": {Host: "https://c"},
|
|
}}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
// "prox" is distance 1 from prod / prom (both win); lex tie-break → prod.
|
|
for i := 0; i < 5; i++ {
|
|
err := runUse("prox", nil)
|
|
if err == nil {
|
|
t.Fatalf("iter %d: expected error", i)
|
|
}
|
|
cm := err.(*cmdutil.Error)
|
|
if cm.Hint != `did you mean: "prod"?` {
|
|
t.Fatalf("iter %d: tie-break must pick lex-smallest 'prod', got %q", i, cm.Hint)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestUse_NotFound_EmptyContexts(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
err := runUse("anything", nil)
|
|
if err == nil {
|
|
t.Fatal("expected error")
|
|
}
|
|
cm := err.(*cmdutil.Error)
|
|
if !strings.Contains(cm.Hint, "auth login") {
|
|
t.Errorf("hint should mention `auth login` for empty Contexts, got %q", cm.Hint)
|
|
}
|
|
}
|
|
|
|
func TestUse_CaseSensitive(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{Contexts: map[string]config.Context{
|
|
"Production": {Host: "https://prod"},
|
|
}}
|
|
_ = config.Save(cfg)
|
|
|
|
err := runUse("production", nil) // lowercase - must NOT match "Production"
|
|
if err == nil {
|
|
t.Fatal("expected case-sensitive miss")
|
|
}
|
|
cm := err.(*cmdutil.Error)
|
|
// did-you-mean kicks in (distance 1 - "P"→"p")
|
|
if !strings.Contains(cm.Hint, "Production") {
|
|
t.Errorf("hint should suggest 'Production' (case-different), got %q", cm.Hint)
|
|
}
|
|
}
|