f27a1e083c
Addresses review feedback on the IM storage URL rewrite: - localFileService.GetFileURL now reads tenant ID from request context first, falling back to ParseTenantIDFromStoragePath only when context is absent. Fixes ambiguity for cloud providers whose paths embed numeric bucket/region names before the tenant segment, which could mint presigned URLs bound to the wrong tenant ID. - Shorten presigned URL default TTL from 24h to 2h. A leaked HMAC key authorizes cross-tenant file reads, so URLs should expire quickly; IM clients fetch referenced images within seconds anyway. - Document ParseTenantIDFromStoragePath as a best-effort fallback. - Add unit tests covering context-first, path-fallback, and the no-external-URL backward-compat path.
254 lines
9.3 KiB
Go
254 lines
9.3 KiB
Go
package file
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"mime/multipart"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/Tencent/WeKnora/internal/logger"
|
|
"github.com/Tencent/WeKnora/internal/types"
|
|
"github.com/Tencent/WeKnora/internal/types/interfaces"
|
|
secutils "github.com/Tencent/WeKnora/internal/utils"
|
|
)
|
|
|
|
// localFileService implements the FileService interface for local file system storage
|
|
type localFileService struct {
|
|
baseDir string // Base directory for file storage
|
|
externalURL string // External URL base for presigned URL generation (empty = return local:// paths)
|
|
}
|
|
|
|
const localScheme = "local://"
|
|
|
|
// CheckConnectivity verifies the local storage directory exists and is accessible.
|
|
func (s *localFileService) CheckConnectivity(ctx context.Context) error {
|
|
info, err := os.Stat(s.baseDir)
|
|
if err != nil {
|
|
return fmt.Errorf("storage directory not accessible: %w", err)
|
|
}
|
|
if !info.IsDir() {
|
|
return fmt.Errorf("storage path is not a directory: %s", s.baseDir)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// NewLocalFileService creates a new local file service instance.
|
|
// externalURL is the externally-reachable base URL (e.g. "https://weknora.example.com");
|
|
// when set, GetFileURL returns presigned HTTP URLs instead of local:// paths.
|
|
func NewLocalFileService(baseDir, externalURL string) interfaces.FileService {
|
|
return &localFileService{
|
|
baseDir: baseDir,
|
|
externalURL: strings.TrimRight(externalURL, "/"),
|
|
}
|
|
}
|
|
|
|
// SaveFile stores an uploaded file to the local file system
|
|
// The file is stored in a directory structure: baseDir/tenantID/knowledgeID/filename
|
|
// Returns the full file path or an error if saving fails
|
|
func (s *localFileService) SaveFile(ctx context.Context,
|
|
file *multipart.FileHeader, tenantID uint64, knowledgeID string,
|
|
) (string, error) {
|
|
logger.Info(ctx, "Starting to save file locally")
|
|
logger.Infof(ctx, "File information: name=%s, size=%d, tenant ID=%d, knowledge ID=%s",
|
|
file.Filename, file.Size, tenantID, knowledgeID)
|
|
|
|
// Create storage directory with tenant and knowledge ID
|
|
dir := filepath.Join(s.baseDir, fmt.Sprintf("%d", tenantID), knowledgeID)
|
|
if _, err := secutils.SafePathUnderBase(s.baseDir, dir); err != nil {
|
|
logger.Errorf(ctx, "Path traversal denied for SaveFile dir: %v", err)
|
|
return "", fmt.Errorf("invalid path: %w", err)
|
|
}
|
|
logger.Infof(ctx, "Creating directory: %s", dir)
|
|
if err := os.MkdirAll(dir, 0o755); err != nil {
|
|
logger.Errorf(ctx, "Failed to create directory: %v", err)
|
|
return "", fmt.Errorf("failed to create directory: %w", err)
|
|
}
|
|
|
|
// Generate unique filename using timestamp
|
|
ext := filepath.Ext(file.Filename)
|
|
filename := fmt.Sprintf("%d%s", time.Now().UnixNano(), ext)
|
|
filePath := filepath.Join(dir, filename)
|
|
logger.Infof(ctx, "Generated file path: %s", filePath)
|
|
|
|
// Open source file for reading
|
|
logger.Info(ctx, "Opening source file")
|
|
src, err := file.Open()
|
|
if err != nil {
|
|
logger.Errorf(ctx, "Failed to open source file: %v", err)
|
|
return "", fmt.Errorf("failed to open file: %w", err)
|
|
}
|
|
defer src.Close()
|
|
|
|
// Create destination file for writing
|
|
logger.Info(ctx, "Creating destination file")
|
|
dst, err := os.Create(filePath)
|
|
if err != nil {
|
|
logger.Errorf(ctx, "Failed to create destination file: %v", err)
|
|
return "", fmt.Errorf("failed to create file: %w", err)
|
|
}
|
|
defer dst.Close()
|
|
|
|
// Copy content from source to destination
|
|
logger.Info(ctx, "Copying file content")
|
|
if _, err := io.Copy(dst, src); err != nil {
|
|
logger.Errorf(ctx, "Failed to copy file content: %v", err)
|
|
return "", fmt.Errorf("failed to save file: %w", err)
|
|
}
|
|
|
|
logger.Infof(ctx, "File saved successfully: %s", filePath)
|
|
// Return provider:// path format: local://{relative_path}
|
|
relPath, _ := filepath.Rel(s.baseDir, filePath)
|
|
return localScheme + filepath.ToSlash(relPath), nil
|
|
}
|
|
|
|
// GetFile retrieves a file from the local file system by its path
|
|
// Returns a ReadCloser for reading the file content
|
|
// Supports both provider scheme: local://{relative_path} and legacy absolute paths.
|
|
// 路径必须在 baseDir 下,防止路径遍历(如 ../../)
|
|
func (s *localFileService) GetFile(ctx context.Context, filePath string) (io.ReadCloser, error) {
|
|
logger.Infof(ctx, "Getting file: %s", filePath)
|
|
|
|
candidate := s.normalizePathForBase(filePath)
|
|
resolved, err := secutils.SafePathUnderBase(s.baseDir, candidate)
|
|
if err != nil {
|
|
logger.Errorf(ctx, "Path traversal denied for GetFile: %v", err)
|
|
return nil, fmt.Errorf("invalid file path: %w", err)
|
|
}
|
|
|
|
file, err := os.Open(resolved)
|
|
if err != nil {
|
|
logger.Errorf(ctx, "Failed to open file: %v", err)
|
|
return nil, fmt.Errorf("failed to open file: %w", err)
|
|
}
|
|
|
|
logger.Info(ctx, "File opened successfully")
|
|
return file, nil
|
|
}
|
|
|
|
// DeleteFile removes a file from the local file system
|
|
// Returns an error if deletion fails
|
|
// 路径必须在 baseDir 下,防止路径遍历(如 ../../)
|
|
func (s *localFileService) DeleteFile(ctx context.Context, filePath string) error {
|
|
logger.Infof(ctx, "Deleting file: %s", filePath)
|
|
|
|
candidate := s.normalizePathForBase(filePath)
|
|
resolved, err := secutils.SafePathUnderBase(s.baseDir, candidate)
|
|
if err != nil {
|
|
logger.Errorf(ctx, "Path traversal denied for DeleteFile: %v", err)
|
|
return fmt.Errorf("invalid file path: %w", err)
|
|
}
|
|
|
|
err = os.Remove(resolved)
|
|
if err != nil {
|
|
logger.Errorf(ctx, "Failed to delete file: %v", err)
|
|
return fmt.Errorf("failed to delete file: %w", err)
|
|
}
|
|
|
|
logger.Info(ctx, "File deleted successfully")
|
|
return nil
|
|
}
|
|
|
|
// SaveBytes saves bytes data to a file and returns the file path
|
|
// temp parameter is ignored for local storage (no auto-expiration support)
|
|
// fileName 仅允许安全文件名,禁止路径遍历(如 ../../)
|
|
func (s *localFileService) SaveBytes(ctx context.Context, data []byte, tenantID uint64, fileName string, temp bool) (string, error) {
|
|
logger.Infof(ctx, "Saving bytes data: fileName=%s, size=%d, tenantID=%d, temp=%v", fileName, len(data), tenantID, temp)
|
|
|
|
safeName, err := secutils.SafeFileName(fileName)
|
|
if err != nil {
|
|
logger.Errorf(ctx, "Invalid fileName for SaveBytes: %v", err)
|
|
return "", fmt.Errorf("invalid file name: %w", err)
|
|
}
|
|
|
|
// Create storage directory with tenant ID
|
|
dir := filepath.Join(s.baseDir, fmt.Sprintf("%d", tenantID), "exports")
|
|
if err := os.MkdirAll(dir, 0o755); err != nil {
|
|
logger.Errorf(ctx, "Failed to create directory: %v", err)
|
|
return "", fmt.Errorf("failed to create directory: %w", err)
|
|
}
|
|
|
|
// Generate unique filename using timestamp
|
|
ext := filepath.Ext(safeName)
|
|
baseName := safeName[:len(safeName)-len(ext)]
|
|
uniqueFileName := fmt.Sprintf("%s_%d%s", baseName, time.Now().UnixNano(), ext)
|
|
filePath := filepath.Join(dir, uniqueFileName)
|
|
|
|
// Write data to file
|
|
if err := os.WriteFile(filePath, data, 0o644); err != nil {
|
|
logger.Errorf(ctx, "Failed to write file: %v", err)
|
|
return "", fmt.Errorf("failed to write file: %w", err)
|
|
}
|
|
|
|
logger.Infof(ctx, "Bytes data saved successfully: %s", filePath)
|
|
relPath, _ := filepath.Rel(s.baseDir, filePath)
|
|
return localScheme + filepath.ToSlash(relPath), nil
|
|
}
|
|
|
|
// GetFileURL returns a download URL for the file.
|
|
// When externalURL is configured, returns a presigned HTTP URL suitable for external access.
|
|
// Otherwise returns the local://... path for backward compatibility.
|
|
func (s *localFileService) GetFileURL(ctx context.Context, filePath string) (string, error) {
|
|
// Normalize to provider:// format.
|
|
normalized := filePath
|
|
if !strings.HasPrefix(filePath, localScheme) {
|
|
relPath, err := filepath.Rel(s.baseDir, filePath)
|
|
if err != nil {
|
|
normalized = filePath
|
|
} else {
|
|
normalized = localScheme + filepath.ToSlash(relPath)
|
|
}
|
|
}
|
|
|
|
// If external URL is configured, generate a presigned HTTP URL.
|
|
if s.externalURL != "" {
|
|
// Prefer tenant ID from context (authoritative); fall back to parsing
|
|
// the storage path for callers that don't propagate tenant context.
|
|
tenantID, ok := types.TenantIDFromContext(ctx)
|
|
if !ok || tenantID == 0 {
|
|
tenantID = secutils.ParseTenantIDFromStoragePath(normalized)
|
|
}
|
|
presignedURL, err := secutils.SignFileURL(s.externalURL, normalized, tenantID, 0)
|
|
if err != nil {
|
|
logger.Warnf(ctx, "Failed to generate presigned URL for %s: %v, returning local:// path", normalized, err)
|
|
return normalized, nil
|
|
}
|
|
return presignedURL, nil
|
|
}
|
|
|
|
return normalized, nil
|
|
}
|
|
|
|
// normalizePathForBase keeps backward compatibility for legacy file paths:
|
|
// - provider scheme: "local://tenant/.." → baseDir/tenant/..
|
|
// - absolute path: "/data/files/tenant/.."
|
|
// - path under base dir: "tenant/.."
|
|
// - legacy relative with base prefix: "data/files/tenant/.."
|
|
func (s *localFileService) normalizePathForBase(filePath string) string {
|
|
// Handle provider:// format: local://{relPath}
|
|
if strings.HasPrefix(filePath, localScheme) {
|
|
relPath := strings.TrimPrefix(filePath, localScheme)
|
|
return filepath.Join(s.baseDir, filepath.FromSlash(relPath))
|
|
}
|
|
|
|
clean := filepath.Clean(strings.TrimSpace(filePath))
|
|
if clean == "." || clean == "" {
|
|
return clean
|
|
}
|
|
if filepath.IsAbs(clean) {
|
|
return clean
|
|
}
|
|
|
|
// Strip duplicated base prefix in legacy relative paths, e.g. "data/files/..."
|
|
baseClean := filepath.Clean(s.baseDir)
|
|
baseNoSlash := strings.Trim(baseClean, string(filepath.Separator))
|
|
cleanNoDot := strings.TrimPrefix(clean, "."+string(filepath.Separator))
|
|
if strings.HasPrefix(cleanNoDot, baseNoSlash+string(filepath.Separator)) {
|
|
cleanNoDot = strings.TrimPrefix(cleanNoDot, baseNoSlash+string(filepath.Separator))
|
|
}
|
|
return filepath.Join(baseClean, cleanNoDot)
|
|
}
|