e623e8208f
Removes the entire envelope machinery now that every success path
emits bare JSON:
- cli/internal/format/envelope.go (Envelope, Success, Failure,
SuccessWithRisk, WriteEnvelope, Meta, Notice, UpdateNotice,
VersionSkewNotice, Risk, RiskLevel, ErrorBody) + tests.
- cli/internal/format/filter.go envelope-specific helpers
(WriteEnvelopeFiltered, marshalEnvelope, applyFieldFilter,
filterDataPayload, filterObjectData); the reusable
filterArrayItems / filterObjectKeys / writeJQ stay for bare.go.
- cli/internal/cmdutil/exporter.go + tests (envelope-only).
- cli/internal/cmdutil/PrintErrorEnvelope + ToErrorBody +
operationRiskOf + Error.OperationRisk field + OperationRisk struct.
Error path: all errors now go to stderr via cmdutil.PrintError in
`code: message\nhint: ...` form, regardless of --json. Stdout stays
empty (or holds the partial-success the command already wrote) so
downstream `--json | jq` pipelines never have to filter error shapes
out of the success stream. Typed exit codes (3 auth.* / 4
resource.not_found / 5 input.* / 6 server.rate_limited / 7 server.*
+ network.* / 10 input.confirmation_required) carry the failure
class for agents that branch on it.
Acceptance contract:
- envelope_test.go → wire_test.go (TestEnvelopeGolden → TestWireGolden).
- testdata/envelopes/ → testdata/wire/.
- Error-path cases assert the typed code substring on stderr.
- Orphan whoami.*.json goldens deleted.
AGENTS.md + README.md rewritten for the bare-data contract:
- Drop envelope schema section + dry-run rule.
- Document bare JSON on stdout + `code: msg\nhint: …` on stderr.
- ADR-3 reframed around bare data and why error separation matters
for `--json | jq` pipelines.
WriteJSONFiltered short-circuits to WriteJSON when both filters are
empty (skip the marshal-buffer round-trip for the common case).
Final review pass:
- Fix wire-contract bug: `--json id,name` (space form) is broken by
pflag's NoOptDefVal; AGENTS.md / README.md / SetAgentHelp + the
field-discovery help text all switched to `--json=id,name`.
- Fix `weknora api --jq` silently ignored: api.go now routes through
WriteJSONFiltered with jopts.JQ.
- AGENTS.md: drop the false claim that `auth logout` honors `-y`
(logout is local-only with no ConfirmDestructive guard); list the
actual destructive commands instead.
- Rewrite cli/acceptance/e2e/e2e_test.go for the bare-data wire shape
(was still parsing `out["data"]` / `env["ok"]`).
- Add `JSONOptions.Emit(w, v)` helper; collapse ~33 repeated
`format.WriteJSONFiltered(iostreams.IO.Out, X, jopts.Fields,
jopts.JQ)` sites to `jopts.Emit(iostreams.IO.Out, X)` — drops the
format import from 22 cmd/* files.
- Delete single-caller `cmdutil.MustRequireFlag`; inline as
`_ = cmd.MarkFlagRequired(...)` everywhere.
- Add `_ = cmd.MarkFlagRequired("name")` to `kb create`; it was the
only write command relying on runtime --name validation while
`context add` already used the cobra-level mark.
- `context use`: register `--json` / `--jq` (was always emitting JSON
unconditionally with no human path and no flag — diverged from
every other write command); human mode now prints
`✓ Switched context to X (was Y)`.
- Replace per-package `confirmPrompter` / `scriptedConfirm` /
`errPrompter` test doubles with `testutil.ConfirmPrompter`.
- Rename `chatService` → `ChatService` (export to match siblings
`ListService` / `ViewService`); rename `printUploadSuccess` →
`renderUploadSuccess` (siblings use `render*`).
- `defaultHint(CodeResourceNotFound)`: drop the hardcoded
"list available with `weknora kb list`" — misleading on agent /
doc / session 404. Replaced with "verify the resource ID and try
again".
- Strip stale `v0.2/v0.3` / "envelope" / "v0.0/v0.1 supports only"
historical tags from production comments and a few test
descriptions.
160 lines
4.5 KiB
Go
160 lines
4.5 KiB
Go
package contextcmd
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/aiclient"
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
)
|
|
|
|
// contextUseFields enumerates fields surfaced for `--json` discovery on
|
|
// `context use`.
|
|
var contextUseFields = []string{"current_context", "previous_context"}
|
|
|
|
// NewCmdUse builds the `weknora context use <name>` command.
|
|
func NewCmdUse(f *cmdutil.Factory) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "use <name>",
|
|
Short: "Switch the default context for subsequent commands",
|
|
Long: `Switches the default context written in config.yaml. Names are case-sensitive.
|
|
|
|
The active context is what every subsequent command uses for auth + host. The
|
|
global --context flag (e.g. weknora --context staging kb list) overrides for
|
|
one command without writing to disk.
|
|
|
|
AI agents: Do NOT switch the active context unless the user explicitly asked
|
|
you to. Context selection is a user preference; one-shot overrides should use
|
|
the global --context flag instead, which writes nothing to disk.`,
|
|
Example: ` weknora context use staging # persist switch
|
|
weknora --context staging kb list # one-shot override (no disk write)
|
|
weknora context use staging --json # {current_context, previous_context}`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
jopts, err := cmdutil.CheckJSONFlags(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runUse(args[0], jopts)
|
|
},
|
|
}
|
|
cmdutil.AddJSONFlags(cmd, contextUseFields)
|
|
aiclient.SetAgentHelp(cmd, "Switches default CLI context. With --json: returns {current_context, previous_context}. Errors with local.context_not_found and a did-you-mean hint when name unknown.")
|
|
return cmd
|
|
}
|
|
|
|
type useResult struct {
|
|
CurrentContext string `json:"current_context"`
|
|
PreviousContext string `json:"previous_context,omitempty"`
|
|
}
|
|
|
|
func runUse(name string, jopts *cmdutil.JSONOptions) error {
|
|
cfg, err := config.Load()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if _, ok := cfg.Contexts[name]; !ok {
|
|
return notFoundError(name, cfg)
|
|
}
|
|
prev := cfg.CurrentContext
|
|
cfg.CurrentContext = name
|
|
if err := config.Save(cfg); err != nil {
|
|
return err
|
|
}
|
|
result := useResult{CurrentContext: name, PreviousContext: prev}
|
|
if jopts.Enabled() {
|
|
return jopts.Emit(iostreams.IO.Out, result)
|
|
}
|
|
if prev != "" && prev != name {
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ Switched context to %s (was %s)\n", name, prev)
|
|
} else {
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ Active context: %s\n", name)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func notFoundError(name string, cfg *config.Config) error {
|
|
if len(cfg.Contexts) == 0 {
|
|
return &cmdutil.Error{
|
|
Code: cmdutil.CodeLocalContextNotFound,
|
|
Message: fmt.Sprintf("context not found: %s", name),
|
|
Hint: "no contexts registered — run `weknora auth login` first",
|
|
}
|
|
}
|
|
keys := contextKeys(cfg.Contexts)
|
|
candidate := closestMatch(name, keys)
|
|
var hint string
|
|
if candidate != "" && candidate != name {
|
|
hint = fmt.Sprintf("did you mean: %q?", candidate)
|
|
} else {
|
|
hint = fmt.Sprintf("available contexts: %v", keys)
|
|
}
|
|
return &cmdutil.Error{
|
|
Code: cmdutil.CodeLocalContextNotFound,
|
|
Message: fmt.Sprintf("context not found: %s", name),
|
|
Hint: hint,
|
|
}
|
|
}
|
|
|
|
func contextKeys(m map[string]config.Context) []string {
|
|
out := make([]string, 0, len(m))
|
|
for k := range m {
|
|
out = append(out, k)
|
|
}
|
|
return out
|
|
}
|
|
|
|
// closestMatch returns the candidate with min levenshtein distance ≤ 2,
|
|
// or "" if none qualifies. Ties broken by lexicographic order so the hint
|
|
// is deterministic across map-iteration orderings (Go randomizes range over
|
|
// map; without this, did-you-mean output is flaky for equally-close
|
|
// candidates).
|
|
func closestMatch(target string, candidates []string) string {
|
|
sorted := append([]string(nil), candidates...)
|
|
sort.Strings(sorted)
|
|
best := ""
|
|
bestD := 3
|
|
for _, c := range sorted {
|
|
d := levenshtein(target, c)
|
|
if d < bestD {
|
|
bestD = d
|
|
best = c
|
|
}
|
|
}
|
|
if bestD > 2 {
|
|
return ""
|
|
}
|
|
return best
|
|
}
|
|
|
|
func levenshtein(a, b string) int {
|
|
la, lb := len(a), len(b)
|
|
if la == 0 {
|
|
return lb
|
|
}
|
|
if lb == 0 {
|
|
return la
|
|
}
|
|
prev := make([]int, lb+1)
|
|
curr := make([]int, lb+1)
|
|
for j := 0; j <= lb; j++ {
|
|
prev[j] = j
|
|
}
|
|
for i := 1; i <= la; i++ {
|
|
curr[0] = i
|
|
for j := 1; j <= lb; j++ {
|
|
cost := 1
|
|
if a[i-1] == b[j-1] {
|
|
cost = 0
|
|
}
|
|
curr[j] = min(curr[j-1]+1, prev[j]+1, prev[j-1]+cost)
|
|
}
|
|
prev, curr = curr, prev
|
|
}
|
|
return prev[lb]
|
|
}
|