nullkey
c87e35b34b
Code-reuse polish (post-implementation review pass): - Extract text.OneLine(maxWidth, s) helper combining preview-row normalization (newline/CR/tab → space) with text.Truncate's UTF-8-safe truncation. Replaces agent/view.go truncate1Line (ASCII '...' + byte-slice CJK-unsafe) and chunk/list.go singleLine. - Lift cmdutil.OpenInput(path) for the '-' = stdin / else os.Open pattern shared across agent create/edit and the api command. Replaces agent/create.go's private openInput. - Strip inline doc-spec parentheticals from source comments — those belong in commit messages and project docs, not in source where they rot. Pre-PR audit fixes: - doc upload: reject `--metadata` paired with `--from-url` as input.invalid_argument up-front (the URL-ingest request type has no metadata field server-side, so the pair would otherwise silently drop). Long help and CHANGELOG updated to call out the asymmetry. - doc upload (file path): map sdk.ErrDuplicateFile sentinel to resource.already_exists. The sentinel arrives with no "HTTP error <n>:" prefix because the SDK short-circuits on file-hash before reading the HTTP status, so the previous WrapHTTP fall-through misclassified it as network.error with a misleading "check base URL reachability" hint. The --from-url branch already handled ErrDuplicateURL this way; this closes the asymmetry. Caught by e2e re-upload of an already-ingested file; regression test added. - README exit-10 enumeration adds `agent delete` and `chunk delete` (these were missing alongside the v0.5 destructive verbs they were meant to gate). Docs sync: - cli/README.md: command tree now includes the chunk subtree; adds agent / chunk lines to the 5-minute quickstart; adds a "Contributing / Reporting issues" section pointing at the repo's SECURITY.md and AGENTS.md; drops third-party CLI parallels from the surface description. - cli/AGENTS.md: "Command surface design SOP" gains the flag-vs-escape-hatch step. "CRUD command flag canon" renamed to the hard-required-flags pattern with the contrast (TTY-prompts-fill) defined inline rather than via opaque shorthand. - cli/CHANGELOG.md: search docs case-sensitivity shift promoted to its own #### Breaking changes subsection. MCP doc_list filter count corrected from 5 to 6. Drops the bogus go.mod yaml.v3 entry (yaml.v3 was already a dependency on main; v0.5 added zero go.mod lines). Replaces internal-Go identifiers (fuzzyTime, NoOptDefVal) with user-language and drops the § section-symbol jargon.
51 lines
1.5 KiB
Go
51 lines
1.5 KiB
Go
package mcpcmd
|
|
|
|
import (
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
mcpserver "github.com/Tencent/WeKnora/cli/internal/mcp"
|
|
)
|
|
|
|
// NewCmdServe builds `weknora mcp serve`. Currently stdio-only; HTTP
|
|
// (streamable / SSE) transports may be added later.
|
|
func NewCmdServe(f *cmdutil.Factory) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "serve",
|
|
Short: "Run an MCP server over stdio",
|
|
Long: `Speaks JSON-RPC 2.0 on stdin/stdout to an MCP client. Logs go to
|
|
stderr; the data channel is reserved for protocol traffic.
|
|
|
|
Authentication is inherited from the active context (or --context). The
|
|
server eagerly resolves the SDK client at startup - if no context is
|
|
configured, the process exits with auth.unauthenticated before any MCP
|
|
handshake. This way an IDE-side agent sees a clear failure mode rather
|
|
than a server that handshakes successfully then errors on every tool.
|
|
|
|
To register with your MCP client, add an entry pointing at this binary
|
|
under "mcpServers":
|
|
|
|
{
|
|
"mcpServers": {
|
|
"weknora": {
|
|
"command": "weknora",
|
|
"args": ["mcp", "serve"]
|
|
}
|
|
}
|
|
}
|
|
|
|
Consult your MCP client's documentation for the exact config-file location.`,
|
|
Args: cobra.NoArgs,
|
|
RunE: func(c *cobra.Command, _ []string) error {
|
|
// Eagerly construct the SDK client. Surfaces auth /
|
|
// configuration problems before any MCP handshake.
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return mcpserver.RunStdio(c.Context(), cli)
|
|
},
|
|
}
|
|
return cmd
|
|
}
|