567d7ac74e
Adds the structured-output and agent-help surface plus root-level signal
handling so AI agents (and humans working through pipes) get a stable
wire contract.
* --format text|json|ndjson flag, registered per-command on outputs that
need it; default text on TTY, json on pipe. --jq <expr> pairs with json
/ ndjson to filter or project. FormatOptions absorbs JQ; WantsJSON()
helper for the JSON dispatch.
* WriteNDJSON helper in internal/format/ (per ndjson.org: one JSON value
per line, arrays split element-per-line, empty slice → zero bytes).
* chat / agent invoke wire --format ndjson via SDK StreamResponse /
AgentStreamResponse 1:1 passthrough. Both commands detect ctx.Cancelled
in every stream + session-create path and emit a stable
"operation.cancelled" code on Ctrl-C / SIGTERM.
* main.go wires signal.NotifyContext(SIGINT, SIGTERM) into the root
context so long-running commands run their cancellation cleanup
(re-emit auto-created session id, etc); the process exits 130 when
the context was signal-cancelled, matching Unix convention.
* MCP chat / agent_invoke output schemas extended with thinking /
tool_calls / assistant_message_id (server-side accumulated; MCP
tools/call has no standard partial-response). doc_view and doc_download
now use doc_id (not knowledge_id) so agents see a single id naming
convention across all tools — matches the chunk_list / search_chunks
schemas and the CLI's <doc-id> positional.
* SetAgentHelp(cmd, AgentHelp{...}) — opt-in machine-friendly --help
payload activated by WEKNORA_AGENT_HELP=1. Applied to chat / kb list.
* kb create --storage-provider <local|minio|cos|tos|s3|oss|ks3> — sets
the new KB's storage_provider_config.provider at creation time (server
does not expose it on update). Required on self-hosted deployments
where the server-side default doesn't pre-populate a provider —
without it, subsequent doc upload returns a misleading "kb not found".
311 lines
12 KiB
Go
311 lines
12 KiB
Go
// Package chat implements `weknora chat <text>` - the streaming RAG answer
|
|
// entry point.
|
|
//
|
|
// Two output modes share a single SDK call:
|
|
//
|
|
// - Stream mode (TTY + text format): write each StreamResponse.Content
|
|
// fragment directly to iostreams.IO.Out as it arrives, then print a
|
|
// footer with knowledge references. This is the "feels alive" UX a
|
|
// human typing in a terminal expects.
|
|
//
|
|
// - Accumulate mode (--format json / pipe): buffer every fragment via
|
|
// sse.Accumulator and emit a single JSON object (or a single plain-text
|
|
// answer + references block) once Done. Agents and pipes get a
|
|
// deterministic single record to parse.
|
|
//
|
|
// The SDK's KnowledgeQAStream callback contract is invoked sequentially on
|
|
// one goroutine, so neither mode needs locking. The runChat core takes a
|
|
// ChatService interface so tests inject a fake without standing up a real
|
|
// SSE server.
|
|
package chat
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/format"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/sse"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// chatFields enumerates the fields surfaced for `--format json` discovery
|
|
// on `chat`. Mirrors the chatData struct json tags.
|
|
var chatFields = []string{
|
|
"answer", "references", "thinking",
|
|
"session_id", "assistant_message_id", "kb_id", "query",
|
|
}
|
|
|
|
type Options struct {
|
|
Query string
|
|
KBID string
|
|
SessionID string
|
|
}
|
|
|
|
// ChatService is the narrow SDK surface this command depends on. *sdk.Client
|
|
// satisfies it; tests substitute a fake. Compile-time check is at the bottom
|
|
// of this file.
|
|
type ChatService interface {
|
|
CreateSession(ctx context.Context, req *sdk.CreateSessionRequest) (*sdk.Session, error)
|
|
KnowledgeQAStream(ctx context.Context, sessionID string, req *sdk.KnowledgeQARequest, cb func(*sdk.StreamResponse) error) error
|
|
}
|
|
|
|
// chatData is the JSON payload emitted on the JSON path. Mirrors what an
|
|
// agent needs to continue a conversation: the answer text, retrieval
|
|
// references, and the session pointer to thread follow-ups.
|
|
type chatData struct {
|
|
Answer string `json:"answer"`
|
|
References []*sdk.SearchResult `json:"references"`
|
|
// Thinking holds the reasoning / reflection text emitted by reasoning
|
|
// models via response_type=thinking frames. Omitted when empty
|
|
// (non-reasoning model or model didn't surface reasoning for this
|
|
// query).
|
|
Thinking string `json:"thinking,omitempty"`
|
|
SessionID string `json:"session_id"`
|
|
AssistantMessageID string `json:"assistant_message_id,omitempty"`
|
|
KBID string `json:"kb_id"`
|
|
Query string `json:"query"`
|
|
}
|
|
|
|
// NewCmd builds `weknora chat <text>`.
|
|
func NewCmd(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &Options{}
|
|
cmd := &cobra.Command{
|
|
Use: `chat "<text>"`,
|
|
Short: "Ask a streaming RAG question against a knowledge base",
|
|
Long: `Send a query to the WeKnora knowledge-chat endpoint and stream the
|
|
answer back. By default a fresh session is created on first invocation; pass
|
|
--session to continue an existing conversation.
|
|
|
|
Modes:
|
|
TTY (text format, default): live token streaming + reference footer
|
|
--format json / pipe: buffered, emitted once on completion`,
|
|
Example: ` weknora chat "What is RRF?" --kb a32a63ff-fb36-4874-bcaa-30f48570a694
|
|
weknora chat "Summarise this design doc" --kb my-kb --format json
|
|
weknora chat "Continue?" --session sess_abc`,
|
|
Args: cobra.MinimumNArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
opts.Query = strings.TrimSpace(strings.Join(args, " "))
|
|
if opts.Query == "" {
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument, "query argument cannot be empty")
|
|
}
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
kbID, err := f.ResolveKB(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
opts.KBID = kbID
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runChat(c.Context(), opts, fopts, cli)
|
|
},
|
|
}
|
|
cmd.Flags().String("kb", "", "Knowledge base UUID or name (overrides project link / env)")
|
|
cmd.Flags().StringVar(&opts.SessionID, "session", "", "Continue an existing chat session (skip auto-create)")
|
|
cmdutil.AddFormatFlag(cmd, chatFields...)
|
|
cmdutil.SetAgentHelp(cmd, cmdutil.AgentHelp{
|
|
UsedFor: "Ask a streaming RAG question against a knowledge base and get a single answer + cited chunks. Agents should use --format json for parseable output.",
|
|
RequiredFlags: []string{"--kb"},
|
|
Examples: []string{`weknora chat "What is RRF?" --kb kb_abc --format json`},
|
|
Output: "answer / references / session_id / thinking — see chatData struct (chat.go)",
|
|
})
|
|
return cmd
|
|
}
|
|
|
|
// runChat is the testable core: validate, ensure a session, dispatch the
|
|
// stream, and route output. Returns a typed error.
|
|
func runChat(ctx context.Context, opts *Options, fopts *cmdutil.FormatOptions, svc ChatService) error {
|
|
if opts.Query == "" {
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument, "query argument cannot be empty")
|
|
}
|
|
if opts.KBID == "" {
|
|
// Defensive: the cobra layer resolves KB before runChat; this guards
|
|
// the direct-test entry point.
|
|
return cmdutil.NewError(cmdutil.CodeKBIDRequired, "kb id is required")
|
|
}
|
|
if svc == nil {
|
|
return cmdutil.NewError(cmdutil.CodeServerError, "chat: no SDK client available")
|
|
}
|
|
|
|
jsonOut := fopts != nil && fopts.Mode == cmdutil.FormatJSON
|
|
|
|
sessionID := opts.SessionID
|
|
autoCreated := false
|
|
if sessionID == "" {
|
|
sess, err := svc.CreateSession(ctx, &sdk.CreateSessionRequest{Title: "weknora chat"})
|
|
if err != nil {
|
|
// Ctrl-C during session creation: classify as cancelled so the
|
|
// hint nudges the user toward retry-with-signal-clean, not
|
|
// "pass --session" as session_create_failed would.
|
|
if isCancelled(ctx, err) {
|
|
return cmdutil.Wrapf(cmdutil.CodeOperationCancelled, err, "chat cancelled")
|
|
}
|
|
// Map HTTP-shaped failures, but tag generic transport / unknown
|
|
// errors as session_create_failed so the dedicated hint fires.
|
|
code := cmdutil.ClassifyHTTPError(err)
|
|
if code == cmdutil.CodeNetworkError || code == cmdutil.CodeServerError {
|
|
code = cmdutil.CodeSessionCreateFailed
|
|
}
|
|
return cmdutil.Wrapf(code, err, "create chat session")
|
|
}
|
|
sessionID = sess.ID
|
|
autoCreated = true
|
|
}
|
|
|
|
// Decide output mode. Stream mode requires:
|
|
// 1. an interactive stdout (tty)
|
|
// 2. no --format json (JSON output is single-record by definition)
|
|
// 3. no --format ndjson (handled by the early-return branch below)
|
|
streamMode := iostreams.IO.IsStdoutTTY() && !jsonOut &&
|
|
(fopts == nil || fopts.Mode != cmdutil.FormatNDJSON)
|
|
|
|
// Surface the auto-created session ID up-front so a user who hits ^C
|
|
// mid-stream still has the pointer to resume - no need to scroll back
|
|
// past tokens. Skipped in JSON mode (it ends up in the data object) and
|
|
// when the caller already supplied --session.
|
|
if autoCreated && !jsonOut {
|
|
fmt.Fprintf(iostreams.IO.Err, "session: %s (use --session to continue)\n", sessionID)
|
|
}
|
|
|
|
req := &sdk.KnowledgeQARequest{
|
|
Query: opts.Query,
|
|
KnowledgeBaseIDs: []string{opts.KBID},
|
|
AgentEnabled: false,
|
|
WebSearchEnabled: false,
|
|
Channel: "api",
|
|
}
|
|
|
|
// --format ndjson: stream raw SDK events as NDJSON. Encoder hoisted out
|
|
// of callback to avoid per-event allocation.
|
|
if fopts != nil && fopts.Mode == cmdutil.FormatNDJSON {
|
|
enc := json.NewEncoder(iostreams.IO.Out)
|
|
enc.SetEscapeHTML(false)
|
|
cb := func(r *sdk.StreamResponse) error {
|
|
return enc.Encode(r)
|
|
}
|
|
if err := svc.KnowledgeQAStream(ctx, sessionID, req, cb); err != nil {
|
|
if isCancelled(ctx, err) {
|
|
return cmdutil.Wrapf(cmdutil.CodeOperationCancelled, err, "chat cancelled")
|
|
}
|
|
return cmdutil.WrapHTTP(err, "knowledge qa stream")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
acc := &sse.Accumulator{}
|
|
|
|
cb := func(r *sdk.StreamResponse) error {
|
|
if streamMode && r != nil && r.Content != "" {
|
|
// Best-effort write; if stdout dies the SDK will surface the
|
|
// error on the next iteration. No need to bail early.
|
|
_, _ = iostreams.IO.Out.Write([]byte(r.Content))
|
|
}
|
|
acc.Append(r)
|
|
return nil
|
|
}
|
|
|
|
streamErr := svc.KnowledgeQAStream(ctx, sessionID, req, cb)
|
|
if streamErr != nil {
|
|
// Re-surface the auto-created session id on failure so a user who
|
|
// missed the start-of-stream notice (it scrolls past mid-stream
|
|
// tokens, especially on ^C) can still recover with --session.
|
|
// Skipped in JSON mode - the data object carries it in .session_id.
|
|
if autoCreated && !jsonOut {
|
|
fmt.Fprintf(iostreams.IO.Err, "session: %s (resume with --session %s)\n", sessionID, sessionID)
|
|
}
|
|
// Context cancelled (Ctrl-C) → user-aborted, exit 130 lineage.
|
|
if isCancelled(ctx, streamErr) {
|
|
return cmdutil.Wrapf(cmdutil.CodeOperationCancelled, streamErr, "chat cancelled")
|
|
}
|
|
// Stream began (we observed at least one event) but never reached a
|
|
// terminal Done frame: typed as sse_stream_aborted so the hint
|
|
// nudges the user toward a retry.
|
|
if acc.Result() != "" && !acc.Done() {
|
|
return cmdutil.Wrapf(cmdutil.CodeSSEStreamAborted, streamErr, "stream aborted before completion")
|
|
}
|
|
// Pre-stream HTTP / transport failure: route through the canonical
|
|
// classifier so 401 / 404 / 5xx still surface their specific codes.
|
|
return cmdutil.WrapHTTP(streamErr, "knowledge qa stream")
|
|
}
|
|
|
|
// SDK returned nil but we never saw a Done event - server closed the
|
|
// connection cleanly mid-stream. Treat as aborted so the user sees the
|
|
// truncation rather than a silent partial answer. Includes the empty-body
|
|
// case (Done frame never arrived AND no content): better to surface the
|
|
// abort than emit ok=true with answer="" - agents can't distinguish the
|
|
// model genuinely had nothing to say from the stream getting cut.
|
|
if !acc.Done() {
|
|
return cmdutil.NewError(cmdutil.CodeSSEStreamAborted, "stream ended without a terminal event")
|
|
}
|
|
|
|
answer := acc.Result()
|
|
references := acc.References
|
|
|
|
if jsonOut {
|
|
// Prefer the SDK-echoed session id (acc.SessionID) but fall back to
|
|
// our local sessionID - agents must always see a usable pointer.
|
|
sid := acc.SessionID
|
|
if sid == "" {
|
|
sid = sessionID
|
|
}
|
|
data := chatData{
|
|
Answer: answer,
|
|
References: references,
|
|
Thinking: acc.Thinking(),
|
|
SessionID: sid,
|
|
AssistantMessageID: acc.AssistantMessageID,
|
|
KBID: opts.KBID,
|
|
Query: opts.Query,
|
|
}
|
|
return fopts.Emit(iostreams.IO.Out, data)
|
|
}
|
|
|
|
// Human / non-JSON paths: streaming mode already wrote the answer body
|
|
// via the callback, so we only need to render the trailing references
|
|
// (and a closing newline). Accumulate + non-JSON writes the answer here
|
|
// for the first time.
|
|
out := iostreams.IO.Out
|
|
if streamMode {
|
|
// Ensure the answer line ends cleanly before the references footer.
|
|
if !strings.HasSuffix(answer, "\n") {
|
|
fmt.Fprintln(out)
|
|
}
|
|
} else {
|
|
fmt.Fprint(out, answer)
|
|
if !strings.HasSuffix(answer, "\n") {
|
|
fmt.Fprintln(out)
|
|
}
|
|
}
|
|
format.WriteReferences(out, references)
|
|
return nil
|
|
}
|
|
|
|
// isCancelled reports whether err or ctx represents a context-cancelled
|
|
// state — true on Ctrl-C / SIGTERM after main.go's signal.NotifyContext
|
|
// fires. Wrapping URL/transport layers may rewrite context.Canceled into
|
|
// something errors.Is no longer recognises, so we fall back to ctx.Err().
|
|
func isCancelled(ctx context.Context, err error) bool {
|
|
if errors.Is(err, context.Canceled) {
|
|
return true
|
|
}
|
|
if ctx.Err() == context.Canceled {
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
// compile-time check: the production SDK client implements ChatService.
|
|
var _ ChatService = (*sdk.Client)(nil)
|