f89d54362d
Closes deep-tuning gaps in v0.4-shipped doc / kb / session commands. Each command had multiple SDK fields the CLI silently hardcoded or omitted; this commit threads them through. doc upload: - --enable-multimodel (tri-state via NoOptDefVal): toggle multimodal extraction (PDF/DOCX image-to-text) per upload. Empty explicit value (e.g. --enable-multimodel="" from uninterpolated shell var) rejected as input.invalid_argument rather than silently coerced. - --metadata key=value (repeatable): attach arbitrary metadata - --channel <name> (default api, override for browser / wechat ingests) - URL mode gains --title / --file-type / --tag-id; URL-only flags rejected with input.invalid_argument when used without --from-url doc list filter flags: - --keyword (server-side LIKE — case-sensitive per PG) - --file-type / --source / --tag-id - --start-time / --end-time (RFC3339) search docs switches from client-side substring to server-side Keyword via ListKnowledgeWithFilter — smaller wire payload, but case-sensitivity shifts (documented in CHANGELOG + help text + Long). MCP doc_list schema gains the same 6 filter fields (parity with CLI). session view --full + --limit: loads chat history via LoadMessages SDK method. kb view human KV expanded: type / pinned / temporary / processing state + count / summary model / created timestamp. All omit-empty. doc view human KV expanded: title (when distinct from filename) / description / source / channel / summary_status / enable_status / tag_id / storage (human bytes) / file_hash (12-char prefix).
168 lines
5.5 KiB
Go
168 lines
5.5 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
type fakeGetSvc struct {
|
|
kb *sdk.KnowledgeBase
|
|
err error
|
|
}
|
|
|
|
func (f *fakeGetSvc) GetKnowledgeBase(ctx context.Context, id string) (*sdk.KnowledgeBase, error) {
|
|
return f.kb, f.err
|
|
}
|
|
|
|
func TestGet_OK_Human(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{
|
|
ID: "kb1", Name: "Marketing", KnowledgeCount: 12, ChunkCount: 245,
|
|
}}
|
|
if err := runView(context.Background(), &ViewOptions{}, nil, svc, "kb1"); err != nil {
|
|
t.Fatalf("runGet: %v", err)
|
|
}
|
|
got := out.String()
|
|
for _, want := range []string{"ID:", "kb1", "NAME:", "Marketing", "DOCS:", "12 docs", "CHUNKS:", "245 chunks"} {
|
|
if !strings.Contains(got, want) {
|
|
t.Errorf("missing %q in:\n%s", want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGet_OK_JSON(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb1", Name: "Marketing"}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.JSONOptions{}, svc, "kb1"); err != nil {
|
|
t.Fatalf("runGet: %v", err)
|
|
}
|
|
got := out.String()
|
|
if !strings.HasPrefix(strings.TrimSpace(got), `{"id":"kb1"`) {
|
|
t.Errorf("expected bare object starting with id, got %q", got)
|
|
}
|
|
if strings.Contains(got, `"ok":true`) {
|
|
t.Errorf("bare output must not carry envelope keys, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestGet_NotFound(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{err: errors.New("HTTP error 404: not found")}
|
|
err := runView(context.Background(), &ViewOptions{}, nil, svc, "missing")
|
|
if err == nil {
|
|
t.Fatal("expected error")
|
|
}
|
|
if !cmdutil.IsNotFound(err) {
|
|
t.Errorf("expected resource.not_found, got %v", err)
|
|
}
|
|
}
|
|
|
|
// --- expanded human render: badges + extra KV lines ---
|
|
|
|
func TestView_Pinned_RendersPinnedLine(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb1", Name: "Pinned", IsPinned: true}}
|
|
if err := runView(context.Background(), &ViewOptions{}, nil, svc, "kb1"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
if !strings.Contains(out.String(), "PINNED:") {
|
|
t.Errorf("expected PINNED line for IsPinned=true:\n%s", out.String())
|
|
}
|
|
}
|
|
|
|
func TestView_NotPinned_OmitsPinnedLine(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb1", Name: "Plain", IsPinned: false}}
|
|
if err := runView(context.Background(), &ViewOptions{}, nil, svc, "kb1"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
for _, l := range strings.Split(out.String(), "\n") {
|
|
if strings.HasPrefix(l, "PINNED:") {
|
|
t.Errorf("PINNED line should be omitted when IsPinned=false: %q", l)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestView_Temporary_RendersTempLine(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb_t", Name: "Tmp", IsTemporary: true}}
|
|
if err := runView(context.Background(), &ViewOptions{}, nil, svc, "kb_t"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
if !strings.Contains(out.String(), "TEMPORARY:") {
|
|
t.Errorf("expected TEMPORARY line:\n%s", out.String())
|
|
}
|
|
}
|
|
|
|
func TestView_SummaryModel(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb1", Name: "X", SummaryModelID: "summary-model-x"}}
|
|
if err := runView(context.Background(), &ViewOptions{}, nil, svc, "kb1"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
got := out.String()
|
|
if !strings.Contains(got, "SUMMARY MODEL:") || !strings.Contains(got, "summary-model-x") {
|
|
t.Errorf("expected SUMMARY MODEL line:\n%s", got)
|
|
}
|
|
}
|
|
|
|
func TestView_TypeAndSource(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb1", Name: "X", Type: "general", Description: "d"}}
|
|
if err := runView(context.Background(), &ViewOptions{}, nil, svc, "kb1"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
got := out.String()
|
|
if !strings.Contains(got, "TYPE:") || !strings.Contains(got, "general") {
|
|
t.Errorf("expected TYPE line for non-empty Type:\n%s", got)
|
|
}
|
|
}
|
|
|
|
func TestView_Processing(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb_p", Name: "Busy", IsProcessing: true, ProcessingCount: 3}}
|
|
if err := runView(context.Background(), &ViewOptions{}, nil, svc, "kb_p"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
got := out.String()
|
|
if !strings.Contains(got, "PROCESSING:") || !strings.Contains(got, "3") {
|
|
t.Errorf("expected PROCESSING line with count:\n%s", got)
|
|
}
|
|
}
|
|
|
|
func TestView_NotProcessing_OmitsProcessingLine(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb_idle", Name: "Idle", IsProcessing: false}}
|
|
if err := runView(context.Background(), &ViewOptions{}, nil, svc, "kb_idle"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
for _, l := range strings.Split(out.String(), "\n") {
|
|
if strings.HasPrefix(l, "PROCESSING:") {
|
|
t.Errorf("PROCESSING line should be omitted: %q", l)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestView_CreatedAt_AlwaysRendered(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{
|
|
ID: "kb1", Name: "X",
|
|
CreatedAt: time.Date(2026, 1, 1, 0, 0, 0, 0, time.UTC),
|
|
UpdatedAt: time.Date(2026, 1, 2, 0, 0, 0, 0, time.UTC),
|
|
}}
|
|
if err := runView(context.Background(), &ViewOptions{}, nil, svc, "kb1"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
got := out.String()
|
|
if !strings.Contains(got, "CREATED:") || !strings.Contains(got, "2026-01-01") {
|
|
t.Errorf("expected CREATED line:\n%s", got)
|
|
}
|
|
}
|