nullkey
5adcedf170
Cross-cutting findings surfaced by the branch-completion review. Perf bug: - Factory.Client closure was not memoized. Factory.ResolveKB internally calls f.Client() to resolve --kb name → id, then the command's RunE calls f.Client() again. Two SDK clients, two keyring reads, two AuthRetryTransport allocations per name-resolved invocation, with *independent* token state (a refresh in one was invisible to the other). Switched to sync.Once like Secrets already does. Silent bug bait: - cmdutil.NormalizeHost docstring claimed CodeInputMissingFlag for the empty case; code returned CodeInputInvalidArgument. Aligned doc to code (present-but-empty is a bad value, not a missing flag). Agent contract gaps: - Five user-facing subcommands lacked SetAgentHelp: auth login / logout / list / status and chat. Added concise strings with error- code call-outs so agents can branch without parsing human strings. Helper extraction (≥3 callers): - text.KnowledgeDisplayName(fileName, title, id) — byte-identical formatter that was in both cmd/doc/list.go and cmd/search/docs.go. Takes fields directly so internal/text stays SDK-free. - cmdutil.WrapHTTP(cause, fmt, args...) *Error — replaces the `Wrapf(ClassifyHTTPError(err), err, ...)` pattern across 24 SDK call sites. Sed-driven migration; off-pattern shapes in chat.go (used streamErr) and cmdutil/kb.go (in-package) hand-edited. Contract test gains a comment update: post-migration the dominant pattern is WrapHTTP which the AST scanner skips entirely (only NewError/Wrapf selectors inspected); ClassifyHTTPErrorOutputs() bridge still covers the dynamic codes those paths can yield. UX consistency: - cmd/doc/list.go --page-size help now reads "Items per page (1..1000)" matching cmd/session/list.go. The bounds validation already enforced 1..1000; the help text was the last drift. Comment-discipline sweep: - Deleted the WHAT-only "*Options captures `weknora ...` flag state" docstring across 23 files (context, kb, auth, doc, session, search, chat, doctor, link). Where the line carried a real WHY clause (kb/delete, doc/delete, session/delete, kb/edit), kept the WHY and dropped only the leading WHAT phrase. - Stripped third-party project-name attribution from inline comments and one user-visible flag-help string across ~40 files in cli/cmd and cli/internal (plus 4 test-file comments). Removed phrases like "Mirrors `gh X`", "borrowed from lark-cli", "kubectl-style", "gcloud `--project`", "Stripe pattern", and the embedded GitHub URLs pointing at those projects. Behavioral descriptions and the WHY behind each comment are preserved; only the upstream-name attribution is gone. Inspiration / north-star references belong in cli/AGENTS.md (the design doc) and commit messages, not scattered through every file. Triggered by an audit round that surfaced several false / fragile parity claims (e.g. "Mirrors `gh repo edit`" — gh repo edit has no --name flag; "matches gcloud `--project` id-or-name" — gcloud's --project accepts ID only). Rather than fix them one by one, the whole category of in-comment external-project references was stripped uniformly.
45 lines
1.6 KiB
Go
45 lines
1.6 KiB
Go
// Package agent handles AI agent integration: env-based detection (used to
|
|
// trigger AGENT-targeted help text) and per-command help annotations.
|
|
//
|
|
// v0.2 ADR-3: removed the omnibus `--agent` flag + ApplyAgentSugar
|
|
// mode-switch as over-design. Per-command --json + TTY auto-detect cover
|
|
// 95% of cases. See cli/AGENTS.md for the full agent contract.
|
|
//
|
|
// What remains here: a small env-detect for known coding agents, used purely
|
|
// to render the AGENT-targeted help section (no behavior change).
|
|
package agent
|
|
|
|
import "os"
|
|
|
|
// AIAgentName identifies the detected coding agent invoking the CLI. Empty
|
|
// string means no agent detected (or detection is disabled).
|
|
type AIAgentName string
|
|
|
|
// aiAgentEnvs maps environment variable presence to a coding agent name.
|
|
// The earlier 7-entry list (CODEX_*, AIDER_PROMPT, CONTINUE_GLOBAL_DIR,
|
|
// OPENCODE_RUNNING, GEMINICODER_PROFILE) did not have official agent docs
|
|
// backing those env names; removed in v0.2 to avoid maintaining an
|
|
// unverified hardcoded list. New entries should document the source URL.
|
|
var aiAgentEnvs = []struct {
|
|
env string
|
|
name AIAgentName
|
|
}{
|
|
{"CLAUDECODE", "claude-code"},
|
|
{"CURSOR_AGENT", "cursor"},
|
|
}
|
|
|
|
// DetectAIAgent returns the first known agent name whose env var is set to a
|
|
// non-empty value, or "" if none are present. Detection is suppressed when
|
|
// WEKNORA_NO_AGENT_AUTODETECT is truthy. Tests substitute via t.Setenv.
|
|
func DetectAIAgent() AIAgentName {
|
|
if v := os.Getenv("WEKNORA_NO_AGENT_AUTODETECT"); v != "" && v != "0" && v != "false" {
|
|
return ""
|
|
}
|
|
for _, a := range aiAgentEnvs {
|
|
if os.Getenv(a.env) != "" {
|
|
return a.name
|
|
}
|
|
}
|
|
return ""
|
|
}
|