d54a7a5834
Roadmap 3-1. Verb-noun shape borrowed from gh search (gh search repos / code / commits / issues / prs verified against the gh manual). Subcommands: - `search chunks "<q>" --kb X` — hybrid retrieval (RAG search). - `search kb "<q>"` — case-insensitive substring match across KB names and descriptions; sorted by name length (shortest hits first). - `search docs "<q>" --kb X` — pages through ListKnowledge filtering by title / file_name; stops once --limit matches are found. - `search sessions "<q>"` — pages through GetSessionsByTenant filtering by title / description. kb / docs / sessions are client-side filters because the server has no fuzzy search endpoint for any of them. ListKnowledgeBases returns the full tenant catalog in one call; the doc/session walkers chunk at 200 per request and stop early on limit. The parent `search` command is a pure dispatcher — there is no bare- positional form (no `weknora search "<q>"`). Cleanups surfaced by the post-commit reviewer round: - UX consistency: search docs's displayDocName ordered Title → FileName → "-", while doc list's displayName uses FileName → Title → ID. Same Knowledge rendered differently across commands. Aligned search docs on doc list's existing FileName-first convention. - cmdutil.ResolveKBFlag(ctx, lister, raw) — extracted the `IsKBID ? raw : ResolveKBNameToID` block duplicated across chunks and docs. - text.ContainsFold(needle, fields...) — replaces inline `strings.Contains(strings.ToLower(field), needle)` patterns. 37 unit tests across chunks/kb/docs/sessions plus the parent registration smoke-test. Roadmap: 3-1.
55 lines
2.0 KiB
Go
55 lines
2.0 KiB
Go
package cmdutil
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"regexp"
|
|
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// uuidPattern matches the canonical 8-4-4-4-12 UUID form. WeKnora's KB ids
|
|
// are uuid.New().String() output stored as varchar(36); names are arbitrary
|
|
// user-supplied strings, so format-detection is unambiguous.
|
|
var uuidPattern = regexp.MustCompile(`^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$`)
|
|
|
|
// IsKBID reports whether s looks like a KB id. Used by Factory.ResolveKB and
|
|
// any caller that accepts a single id-or-name selector value — same pattern
|
|
// gcloud uses for --project (id vs name auto-detection).
|
|
func IsKBID(s string) bool { return uuidPattern.MatchString(s) }
|
|
|
|
// KBLister is the narrow SDK surface ResolveKBNameToID depends on. The
|
|
// production *sdk.Client satisfies it; tests inject fakes without standing
|
|
// up an HTTP server.
|
|
type KBLister interface {
|
|
ListKnowledgeBases(ctx context.Context) ([]sdk.KnowledgeBase, error)
|
|
}
|
|
|
|
// ResolveKBFlag interprets a raw --kb value (id or name) and returns the
|
|
// canonical id. Pass-through when raw already looks like an id; otherwise
|
|
// list and match by name. Shared by every command that takes a --kb flag
|
|
// directly (search chunks/docs, doc download, link …) so the id-or-name
|
|
// policy never drifts.
|
|
func ResolveKBFlag(ctx context.Context, lister KBLister, raw string) (string, error) {
|
|
if IsKBID(raw) {
|
|
return raw, nil
|
|
}
|
|
return ResolveKBNameToID(ctx, lister, raw)
|
|
}
|
|
|
|
// ResolveKBNameToID looks up a knowledge base by name and returns its ID.
|
|
// Used by `link` and `Factory.ResolveKB` — a single lookup so the match
|
|
// policy (currently exact case-sensitive) lives in one place.
|
|
func ResolveKBNameToID(ctx context.Context, lister KBLister, name string) (string, error) {
|
|
kbs, err := lister.ListKnowledgeBases(ctx)
|
|
if err != nil {
|
|
return "", Wrapf(ClassifyHTTPError(err), err, "list knowledge bases")
|
|
}
|
|
for _, kb := range kbs {
|
|
if kb.Name == name {
|
|
return kb.ID, nil
|
|
}
|
|
}
|
|
return "", NewError(CodeKBNotFound, fmt.Sprintf("knowledge base not found: %s", name))
|
|
}
|