Files
Enterprise-Knowledge-Base/internal/agent/tools/grep_chunks_scope_test.go
T
wizardchen d24e830c85 refactor(agent): fix grep scope loss and consolidate per-turn @mention scoping
- Fix grep_chunks dropping the full-KB scope when a turn mixes @KB with
  @tag/@file: extract scopeClause and OR knowledge-ID and (kb,tenant)
  predicates together, matching knowledge_search's fan-out.
- Consolidate the three scattered per-request @Skill/@MCP scope blocks in
  buildAgentConfig into applyPerRequestSkillScope / applyPerRequestMCPScope,
  each narrowing the whitelist and computing the must_use pin in one place.
- Dedupe the two identical selection-mode normalizers in Input-field.vue.
- Fix knowledge_create_test passing "" for the tagIDs []string parameter,
  which made the whole service test package fail to compile.
- Add unit tests for scopeClause and the per-request scope helpers.
2026-06-29 18:09:44 +08:00

50 lines
1.3 KiB
Go

package tools
import (
"strings"
"testing"
)
func TestScopeClause_KnowledgeAndFullKBOredTogether(t *testing.T) {
sql, args := scopeClause(
[]string{"kb-1"},
[]string{"doc-9"},
map[string]uint64{"kb-1": 7},
)
if !strings.Contains(sql, "chunks.knowledge_id IN ?") {
t.Fatalf("expected knowledge-id predicate, got %q", sql)
}
if !strings.Contains(sql, "chunks.knowledge_base_id = ? AND chunks.tenant_id = ?") {
t.Fatalf("expected kb-tenant predicate, got %q", sql)
}
if !strings.Contains(sql, " OR ") {
t.Fatalf("expected the two scopes to be OR'd, got %q", sql)
}
// args: knowledgeIDs slice + kbID + tenantID
if len(args) != 3 {
t.Fatalf("expected 3 args, got %d: %v", len(args), args)
}
}
func TestScopeClause_SkipsKBWithoutTenant(t *testing.T) {
sql, args := scopeClause(
[]string{"kb-1", "kb-2"},
nil,
map[string]uint64{"kb-1": 7}, // kb-2 has no tenant mapping
)
if strings.Contains(sql, "kb-2") {
t.Fatalf("kb-2 has no tenant and must be skipped, got %q", sql)
}
if len(args) != 2 {
t.Fatalf("expected only kb-1 (2 args), got %d: %v", len(args), args)
}
}
func TestScopeClause_EmptyWhenNoUsableScope(t *testing.T) {
sql, args := scopeClause([]string{"kb-1"}, nil, map[string]uint64{})
if sql != "" || args != nil {
t.Fatalf("expected empty scope, got sql=%q args=%v", sql, args)
}
}