a39805aa89
Empty cli/ Go module with Factory + Options skeleton that all v0.x commands plug into. Foundation packages (10 internal/): - cmdutil: Factory(3 closure: Config/Client/Prompter) + Options + Errors with namespaced ErrorCode + typed predicates (IsAuthError / IsNotFound / IsTransient / IsAuthExpired) + Exporter + AddJSONFlags + ExitCode/PrintError - iostreams: package singleton with TTY detection; ColorEnabled honors NO_COLOR / TERM=dumb on demand - agent: mode + detect + annotations (Stripe pkg/useragent pattern; CLAUDECODE / CURSOR_AGENT / CODEX_* / AIDER_* / CONTINUE_* / OPENCODE_* / GEMINICODER env detection) - build: ldflags-injected version/commit/date - safepaths: separator-aware path-traversal protection - config: yaml.v3 schema + atomic save 0600 (XDG-style) - format: success/failure envelope (code/hint/request_id/risk/retryable/ console_url) with typed RiskLevel - prompt: Prompter interface + AgentPrompter (rejects in agent mode) - secrets: file 0600 store with weknora:<context>:<key> namespace - testutil: XDGTempDir(t) test helper Smoke command: weknora version (-/--json). Build/test/vet matrix in .github/workflows/cli.yml across linux x macos x windows x Go 1.24. Factory.Client returns CodeLocalUnimplemented until PR-3 wires the SDK adapter; PR-1 commands (version) don't need it.
71 lines
2.1 KiB
Go
71 lines
2.1 KiB
Go
package safepaths
|
|
|
|
import (
|
|
"errors"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestValidate(t *testing.T) {
|
|
t.Run("rejects empty", func(t *testing.T) {
|
|
_, err := Validate("")
|
|
require.ErrorIs(t, err, ErrEmptyPath)
|
|
})
|
|
t.Run("rejects bare dot", func(t *testing.T) {
|
|
_, err := Validate(".")
|
|
require.ErrorIs(t, err, ErrSuspiciousPath)
|
|
})
|
|
t.Run("rejects bare double-dot", func(t *testing.T) {
|
|
_, err := Validate("..")
|
|
require.ErrorIs(t, err, ErrSuspiciousPath)
|
|
})
|
|
t.Run("rejects relative path that ascends past start", func(t *testing.T) {
|
|
// "../foo" preserves the ".." after Clean.
|
|
_, err := Validate("../foo")
|
|
require.ErrorIs(t, err, ErrSuspiciousPath)
|
|
})
|
|
t.Run("cleans benign relative", func(t *testing.T) {
|
|
// "a/b/../c" cleans to "a/c" — fine.
|
|
got, err := Validate("a/b/../c")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, filepath.Clean("a/c"), got)
|
|
})
|
|
t.Run("cleans cancelling relative", func(t *testing.T) {
|
|
// "a/../b" cleans to "b" — also fine; the ascent fully resolves.
|
|
got, err := Validate("a/../b")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "b", got)
|
|
})
|
|
}
|
|
|
|
func TestWithinRoot(t *testing.T) {
|
|
t.Run("inside root", func(t *testing.T) {
|
|
err := WithinRoot("/srv/data/file.md", "/srv/data")
|
|
require.NoError(t, err)
|
|
})
|
|
t.Run("equal to root", func(t *testing.T) {
|
|
err := WithinRoot("/srv/data", "/srv/data")
|
|
require.NoError(t, err)
|
|
})
|
|
t.Run("escapes via parent", func(t *testing.T) {
|
|
err := WithinRoot("/srv/data/../../etc/passwd", "/srv/data")
|
|
require.Error(t, err)
|
|
assert.True(t, errors.Is(err, ErrPathEscapes))
|
|
})
|
|
t.Run("sibling outside", func(t *testing.T) {
|
|
err := WithinRoot("/srv/other", "/srv/data")
|
|
require.Error(t, err)
|
|
assert.True(t, errors.Is(err, ErrPathEscapes))
|
|
})
|
|
t.Run("dotdot-prefix sibling is not within", func(t *testing.T) {
|
|
// /srv/data..foo lexically starts with "/srv/data" but is a different dir.
|
|
// Without separator-awareness this would be a false negative.
|
|
err := WithinRoot("/srv/data..foo/x", "/srv/data")
|
|
require.Error(t, err)
|
|
assert.True(t, errors.Is(err, ErrPathEscapes))
|
|
})
|
|
}
|