cc8254f862
Two intertwined mainstream-alignment moves bundled because they share
the migration target (every command's --json path):
1. Drop --dry-run entirely. Survey of comparable API-wrapper CLIs
(gh, aws, stripe, lark): none expose --dry-run. The mainstream that
does (kubectl/git/helm/ansible) operates on declarative manifests
or local state where the preview is materially different from the
executed action. WeKnora's CLI just echoed the same parameters
that would have gone on the wire — the preview added no real
signal over `--help` + reading the call site. Removes:
- root --dry-run persistent flag + cmdutil/dryrun.go
- DryRun fields + EmitDryRun calls in 12 write commands
- format.Envelope.DryRun field
- 8 corresponding *_test.go cases
- --dry-run mention from README.md and CHANGELOG.md
- "dry_run":false from 16 golden envelopes
2. Migrate every --json output to bare data:
- New format.WriteJSON / WriteJSONFiltered helpers
(cli/internal/format/bare.go) share filterArrayItems /
filterObjectKeys / writeJQ with the (still-live for now) envelope
filter helpers.
- Read commands (kb/doc/session list+view, search chunks/docs/
sessions/kb, auth list/status, agent list/view, context list,
doctor) emit bare arrays / objects on stdout.
- Write commands (kb create/edit/delete/pin/empty, doc upload/
upload_recursive/delete, session delete, auth login/logout/
refresh/token, link/unlink, context add/use/remove, agent
invoke, chat, api, version) emit bare result objects. Risk
classification dropped — the resource + exit code already
convey the action.
Per-command shape changes:
list / search → []T (was {ok, data:{items:[…]}})
view → T (was {ok, data:T, _meta:…})
create / edit → T
delete / pin / etc. → {id, …action result…}
doctor → {summary, checks}
api → {status, headers, body}
_meta dropped on the read path:
pagination (page/page_size/total/has_more) — agents iterate with
--all-pages or accept --limit (gh CLI parity);
kb_id / context echo — caller already knows what it asked for.
Acceptance contract goldens regenerated for the new bare shape.
Error envelope on stdout (PrintErrorEnvelope) stays live for now —
the envelope-infra deletion lands in the next commit.
92 lines
3.2 KiB
Go
92 lines
3.2 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/aiclient"
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/format"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/prompt"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// kbEmptyFields enumerates the fields surfaced for `--json` discovery on
|
|
// `kb empty`. The result payload is {id, deleted_count}.
|
|
var kbEmptyFields = []string{"id", "deleted_count"}
|
|
|
|
type EmptyOptions struct {
|
|
Yes bool
|
|
}
|
|
|
|
type EmptyService interface {
|
|
ClearKnowledgeBaseContents(ctx context.Context, id string) (*sdk.ClearKnowledgeBaseContentsResponse, error)
|
|
}
|
|
|
|
// emptyResult is the typed payload emitted under data on success.
|
|
type emptyResult struct {
|
|
ID string `json:"id"`
|
|
DeletedCount int `json:"deleted_count"`
|
|
}
|
|
|
|
// NewCmdEmpty builds `weknora kb empty <id>`. Wipes every document inside
|
|
// the knowledge base; the KB itself is preserved. The server runs the
|
|
// delete asynchronously and reports the count of documents that were
|
|
// enqueued for removal.
|
|
func NewCmdEmpty(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &EmptyOptions{}
|
|
cmd := &cobra.Command{
|
|
Use: "empty <id>",
|
|
Short: "Delete every document in a knowledge base (preserves the KB)",
|
|
Long: `Removes all documents and chunks from a knowledge base while keeping the
|
|
KB record (its name, description, and config) intact. The delete is async;
|
|
the server reports the count of items enqueued for removal.
|
|
|
|
Prompts for confirmation by default; pass -y/--yes to skip in agent / CI /
|
|
piped contexts. Without -y the CLI exits 10 in non-interactive mode.`,
|
|
Example: ` weknora kb empty kb_abc # interactive confirm
|
|
weknora kb empty kb_abc -y --json # agent-friendly`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
jopts, err := cmdutil.CheckJSONFlags(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
opts.Yes, _ = c.Flags().GetBool("yes")
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runEmpty(c.Context(), opts, jopts, cli, f.Prompter(), args[0])
|
|
},
|
|
}
|
|
cmdutil.AddJSONFlags(cmd, kbEmptyFields)
|
|
aiclient.SetAgentHelp(cmd, "Destructively empties a knowledge base (deletes all documents, preserves the KB record + config). ALWAYS pass -y/--yes in agent mode (non-TTY ⇒ confirm fails). Returns data: {id, deleted_count}. Async — items may still be processing server-side after the call returns.")
|
|
return cmd
|
|
}
|
|
|
|
func runEmpty(ctx context.Context, opts *EmptyOptions, jopts *cmdutil.JSONOptions, svc EmptyService, p prompt.Prompter, id string) error {
|
|
if err := cmdutil.ConfirmDestructive(p, opts.Yes, jopts.Enabled(), "all contents of knowledge base", id); err != nil {
|
|
return err
|
|
}
|
|
|
|
resp, err := svc.ClearKnowledgeBaseContents(ctx, id)
|
|
if err != nil {
|
|
return cmdutil.WrapHTTP(err, "empty knowledge base %s", id)
|
|
}
|
|
deleted := 0
|
|
if resp != nil {
|
|
deleted = resp.DeletedCount
|
|
}
|
|
|
|
if jopts.Enabled() {
|
|
return format.WriteJSONFiltered(iostreams.IO.Out,
|
|
emptyResult{ID: id, DeletedCount: deleted}, jopts.Fields, jopts.JQ)
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ Emptied knowledge base %s (%d document(s) cleared)\n", id, deleted)
|
|
return nil
|
|
}
|