ad150c7126
Sweep every CLI output path through the v0.7 envelope contract.
FormatOptions.Emit signature changes to (w, data, meta *output.Meta)
so list commands surface meta.count / has_more in the wire envelope.
TTY indent decision plumbed via FormatOptions.TTY (set by
ResolveDefault). --format and --jq promoted to persistent root flags
so unknown-subcommand paths still reach the typed-envelope guard
(per-command registration would have rejected --format on unknown
commands as cobra-prose exit 2). WEKNORA_FORMAT env-var fallback
honored before TTY-resolved default. AddFormatFlag retained for the
per-command --jq field-hint Long-text addendum.
~55 production Emit call sites swept across cli/cmd/**: list paths
populate meta.count; mutation paths pass nil meta; envelope.profile
threaded via globalProfile. Existing JSON-shape tests migrated to
decode the envelope wrapper.
Multi-target batch operations get a unified shape via new helpers:
- output.BatchItem + output.WriteBatchEnvelope (§4.5 per-item ok
pattern; data:[{id, ok, result?|error?}], meta:{count, successes*,
failures*}; Successes/Failures *int so explicit zero survives
omitempty in all-fail case).
- cmdutil.RunBatch + cmdutil.EmitBatch + cmdutil.DeletedAtNow +
cmdutil.ClassifyContextErr collapse the three previously-duplicated
multi-delete pipelines (doc / chunk / session) into one call site
pattern. doc upload --recursive uses the same helpers with a per-
file resultFn. Summary error sets Silent:true so the stderr
envelope path doesn't duplicate the stdout batch detail (exit 1
preserved via Code → ExitCode).
ConfirmDestructive / ConfirmDestructiveBatch extended with action +
retryCmd parameters. Every destructive command (kb delete, kb edit,
doc delete, doc delete --all, agent delete, agent edit, session
delete, chunk delete, auth logout, api -X DELETE) now attaches
error.risk.{level:"destructive", action:"<noun.verb>"} +
error.retry_command on the exit-10 envelope. kb edit / agent edit
also gain the destructive guard wiring (CHANGELOG listed them as
gated but they were silently executing without -y).
MCP tool handlers' 31 error paths return CallToolResult with
IsError + Content text fallback + StructuredContent (envelope.error
shape via cmdutil.ErrorToDetail). Handler Out type changed from
typed *sdk.X to any so the go-sdk auto-marshal doesn't overwrite
StructuredContent with a zero-struct on error returns. Success path
manually populates CallToolResult.StructuredContent via successResult
helper.
weknora api cleanup:
- -d/--data flag removed; body via --input <file> or --input -
(stdin) only. Aligns with gh / curl convention.
- HTTP method whitelist removed; any non-empty method accepted.
- HTTP Retry-After header → cmdutil.Error.RetryAfterSeconds →
envelope.error.retry_after_seconds.
- runAPIPaginated raw-passthrough fallback now wraps response in
envelope so --paginate never emits bare JSON to stdout.
Test sweep: ~60 cmd/** tests migrated to decode envelope shape.
9 wire-contract goldens updated under cli/acceptance/testdata/wire/.
Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §4 / §5
174 lines
5.9 KiB
Go
174 lines
5.9 KiB
Go
package search
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sort"
|
|
"strings"
|
|
"text/tabwriter"
|
|
"time"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/output"
|
|
"github.com/Tencent/WeKnora/cli/internal/text"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// sessionsPageSize is the default --page-size on `search sessions`: how many
|
|
// entries to pull per GetSessionsByTenant round-trip when paging through to
|
|
// filter client-side. Tunable via --page-size in 1..1000.
|
|
const sessionsPageSize = 200
|
|
|
|
// sessionsMaxPageSize bounds the --page-size flag, matching the session/doc list cap.
|
|
const sessionsMaxPageSize = 1000
|
|
|
|
// sessionsSearchFields enumerates the fields surfaced for `--format json` discovery
|
|
// on `search sessions`. Mirrors sdk.Session json tags.
|
|
var sessionsSearchFields = []string{
|
|
"id", "tenant_id", "title", "description", "created_at", "updated_at",
|
|
}
|
|
|
|
type SessionsSearchOptions struct {
|
|
Query string
|
|
Limit int
|
|
// PageSize is the server batch size per GetSessionsByTenant call
|
|
// (1..1000, default 200). Tunable so a caller searching a small set
|
|
// can fetch everything in one round-trip.
|
|
PageSize int
|
|
// AllPages walks server pages internally until total exhausted or
|
|
// --limit accumulated. Default true; setting false stops after the
|
|
// first page (useful for cheap previews).
|
|
AllPages bool
|
|
}
|
|
|
|
// SessionsSearchService is the narrow SDK surface this command depends on.
|
|
// Server has no session-search endpoint; CLI pages through and filters by
|
|
// Title / Description client-side.
|
|
type SessionsSearchService interface {
|
|
GetSessionsByTenant(ctx context.Context, page, pageSize int) ([]sdk.Session, int, error)
|
|
}
|
|
|
|
// NewCmdSessions builds `weknora search sessions "<query>"`. Finds chat
|
|
// sessions whose title or description contains the query.
|
|
func NewCmdSessions(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &SessionsSearchOptions{}
|
|
cmd := &cobra.Command{
|
|
Use: `sessions "<query>"`,
|
|
Short: "Find chat sessions by title or description (client-side substring match)",
|
|
Long: `Pages through the tenant's chat sessions and surfaces every entry whose
|
|
title or description contains the query (case-insensitive).
|
|
|
|
By default, --all-pages=true walks every server page until --limit is
|
|
reached or the tenant's sessions are exhausted. Pass --all-pages=false
|
|
to stop after one page.`,
|
|
Example: ` weknora search sessions "onboarding"
|
|
weknora search sessions "Q3 review" --limit 3 --format json
|
|
weknora search sessions "Q3 review" --all-pages=false`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
opts.Query = strings.TrimSpace(args[0])
|
|
if opts.Query == "" {
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument, "query argument cannot be empty")
|
|
}
|
|
if opts.Limit < 1 || opts.Limit > 1000 {
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument, "--limit must be between 1 and 1000")
|
|
}
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runSessionsSearch(c.Context(), opts, fopts, cli)
|
|
},
|
|
}
|
|
cmd.Flags().IntVarP(&opts.Limit, "limit", "L", 30, "Maximum results to return")
|
|
cmd.Flags().IntVar(&opts.PageSize, "page-size", sessionsPageSize, "Items per server batch (1..1000)")
|
|
cmd.Flags().BoolVar(&opts.AllPages, "all-pages", true, "Walk every server page until exhausted or --limit hit")
|
|
cmdutil.AddFormatFlag(cmd, sessionsSearchFields...)
|
|
return cmd
|
|
}
|
|
|
|
func runSessionsSearch(ctx context.Context, opts *SessionsSearchOptions, fopts *cmdutil.FormatOptions, svc SessionsSearchService) error {
|
|
if opts.PageSize < 1 || opts.PageSize > sessionsMaxPageSize {
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument,
|
|
fmt.Sprintf("--page-size must be in 1..%d, got %d", sessionsMaxPageSize, opts.PageSize))
|
|
}
|
|
needle := strings.ToLower(opts.Query)
|
|
var matches []sdk.Session
|
|
var received int // count of server-returned items so far (separate from
|
|
// matches, which is client-filtered). Used for termination so a
|
|
// server-capped page_size doesn't cause early break.
|
|
|
|
// --all-pages=true (default) walks every server page; --all-pages=false
|
|
// stops after the first page.
|
|
for page := 1; ; page++ {
|
|
items, total, err := svc.GetSessionsByTenant(ctx, page, opts.PageSize)
|
|
if err != nil {
|
|
return cmdutil.WrapHTTP(err, "list sessions")
|
|
}
|
|
received += len(items)
|
|
for _, s := range items {
|
|
if matchSession(s, needle) {
|
|
matches = append(matches, s)
|
|
if opts.Limit > 0 && len(matches) >= opts.Limit {
|
|
goto done
|
|
}
|
|
}
|
|
}
|
|
if !opts.AllPages {
|
|
break
|
|
}
|
|
if received >= total || len(items) == 0 {
|
|
break
|
|
}
|
|
}
|
|
done:
|
|
sortSessionsByRecency(matches)
|
|
|
|
if fopts.WantsJSON() {
|
|
if matches == nil {
|
|
matches = []sdk.Session{}
|
|
}
|
|
meta := &output.Meta{Count: len(matches)}
|
|
return fopts.Emit(iostreams.IO.Out, matches, meta)
|
|
}
|
|
if len(matches) == 0 {
|
|
fmt.Fprintln(iostreams.IO.Out, "(no matches)")
|
|
return nil
|
|
}
|
|
tw := tabwriter.NewWriter(iostreams.IO.Out, 0, 0, 2, ' ', 0)
|
|
fmt.Fprintln(tw, "ID\tTITLE\tUPDATED")
|
|
now := time.Now()
|
|
for _, s := range matches {
|
|
title := text.Truncate(50, s.Title)
|
|
if title == "" {
|
|
title = "-"
|
|
}
|
|
fmt.Fprintf(tw, "%s\t%s\t%s\n", s.ID, title, text.FuzzyAgoStr(now, s.UpdatedAt))
|
|
}
|
|
return tw.Flush()
|
|
}
|
|
|
|
// matchSession reports whether title or description contains needle (already
|
|
// lowercased by caller).
|
|
func matchSession(s sdk.Session, needle string) bool {
|
|
return text.ContainsFold(needle, s.Title, s.Description)
|
|
}
|
|
|
|
// sortSessionsByRecency sorts in place by UpdatedAt desc. Server returns
|
|
// strings; we compare lexically - RFC3339 timestamps sort correctly that
|
|
// way, and a stable order is enough for output determinism even if a
|
|
// non-conforming string slips through.
|
|
func sortSessionsByRecency(items []sdk.Session) {
|
|
sort.SliceStable(items, func(i, j int) bool {
|
|
return items[i].UpdatedAt > items[j].UpdatedAt
|
|
})
|
|
}
|