2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
102 lines
3.1 KiB
Go
102 lines
3.1 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// kbPinFields enumerates the fields surfaced for `--format json` discovery on
|
|
// `kb pin` / `kb unpin`. The toggle result is the KnowledgeBase; the user-
|
|
// relevant fields here are the id and the new pin state.
|
|
var kbPinFields = []string{"id", "is_pinned"}
|
|
|
|
type PinOptions struct{}
|
|
|
|
// PinService is the narrow SDK surface this command depends on. The CLI
|
|
// reads current state before toggling so `pin`/`unpin` are idempotent -
|
|
// the server endpoint is only a non-idempotent toggle.
|
|
type PinService interface {
|
|
GetKnowledgeBase(ctx context.Context, id string) (*sdk.KnowledgeBase, error)
|
|
TogglePinKnowledgeBase(ctx context.Context, id string) (*sdk.KnowledgeBase, error)
|
|
}
|
|
|
|
// NewCmdPin builds `weknora kb pin <id>`.
|
|
func NewCmdPin(f *cmdutil.Factory) *cobra.Command {
|
|
return newPinCmd(f, "pin", true, "Pin a knowledge base to the top of the list")
|
|
}
|
|
|
|
// NewCmdUnpin builds `weknora kb unpin <id>`.
|
|
func NewCmdUnpin(f *cmdutil.Factory) *cobra.Command {
|
|
return newPinCmd(f, "unpin", false, "Unpin a knowledge base")
|
|
}
|
|
|
|
func newPinCmd(f *cmdutil.Factory, use string, want bool, short string) *cobra.Command {
|
|
opts := &PinOptions{}
|
|
cmd := &cobra.Command{
|
|
Use: use + " <kb-id>",
|
|
Short: short,
|
|
Long: short + ". Idempotent: reads the current pin state and toggles only if different, so re-running on a KB already in the target state is a no-op.",
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runPin(c.Context(), opts, fopts, cli, args[0], want)
|
|
},
|
|
}
|
|
cmdutil.AddFormatFlag(cmd, kbPinFields...)
|
|
return cmd
|
|
}
|
|
|
|
func runPin(ctx context.Context, opts *PinOptions, fopts *cmdutil.FormatOptions, svc PinService, id string, want bool) error {
|
|
verb := "pin"
|
|
if !want {
|
|
verb = "unpin"
|
|
}
|
|
current, err := svc.GetKnowledgeBase(ctx, id)
|
|
if err != nil {
|
|
return cmdutil.WrapHTTP(err, "get knowledge base %s", id)
|
|
}
|
|
if current.IsPinned == want {
|
|
state := "pinned"
|
|
if !want {
|
|
state = "unpinned"
|
|
}
|
|
// No-op path: the resource is already in the requested state. We
|
|
// emit the current resource so callers see the canonical shape on
|
|
// both fresh-toggle and no-op paths. Text path prints a confirming
|
|
// line; agents observe via the unchanged is_pinned field.
|
|
if fopts.WantsJSON() {
|
|
return fopts.Emit(iostreams.IO.Out, current, nil)
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ %s is already %s\n", id, state)
|
|
return nil
|
|
}
|
|
|
|
updated, err := svc.TogglePinKnowledgeBase(ctx, id)
|
|
if err != nil {
|
|
return cmdutil.WrapHTTP(err, "%s knowledge base %s", verb, id)
|
|
}
|
|
if fopts.WantsJSON() {
|
|
return fopts.Emit(iostreams.IO.Out, updated, nil)
|
|
}
|
|
state := "pinned"
|
|
if !updated.IsPinned {
|
|
state = "unpinned"
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ %s %s\n", id, state)
|
|
return nil
|
|
}
|