9afb8b7b68
Lark and Feishu are the same product deployed on two isolated clouds (open.larksuite.com and open.feishu.cn). WeKnora touches both from two places — the IM bot and the Wiki data-source connector — and this brings Lark to parity across both. Neither API surface differs, so rather than duplicate either implementation, each is parametrized by a Region and registered twice. IM (internal/im/feishu): Every API call routes through a.api(), which prefixes the region's host, and the WebSocket client passes larkws.WithDomain — the SDK defaults to open.feishu.cn, so Lark long connections would otherwise fail to authenticate. Data source (internal/datasource/connector/feishu): Lark was half-supported: the client honoured a base_url override and a LarkBaseURL constant existed, but the connector registered only as "feishu" and the UI never exposed base_url, so Lark wikis could not be configured at all. Lark is now its own connector type. base_url is kept as an explicit override so data sources that pointed a "feishu" connector at open.larksuite.com keep working. Bugs found and fixed along the way: - Wiki resource links were hardcoded to https://feishu.cn/wiki/{token} in four places, so a Lark wiki linked into the wrong cloud entirely. - Bot identity is now platform-prefixed (feishu:cli_x vs lark:cli_x). BotIdentity carries a unique index, so without this a Lark channel would be rejected as a duplicate of an unrelated Feishu bot sharing an app_id. - The card image cache is now keyed by app_id. image_keys are issued per app on one cloud; a Feishu key handed to a Lark app fails the card update with code=200570. - The datasource doc claimed Lark "adapts automatically" — it could not, since the UI had no way to reach base_url. Permissions are where the clouds genuinely diverge. Identical APIs do not mean identical permission catalogues: aily:file:read, aily:file:write and corehr:file:download exist on Feishu but not on Lark, so pasting Feishu's scope JSON into Lark fails to import. That JSON is also over-broad (it covers products WeKnora never calls) and simultaneously incomplete (it omits the drive:*/docx:* scopes the connector needs). Lark therefore gets its own list, derived from the 17 endpoints the code actually calls and checked identifier-by-identifier against Lark's own API reference, plus a full Feishu→Lark mapping table marking each scope verified, unverified, or absent. Both features use tenant_access_token only — no user_access_ token exists anywhere in the repo — so the user dimension stays empty. Known limitation: Region.ThinkingText makes Lark's initial card placeholder English, but once streaming starts the think-block headers come from the shared MarkdownThinkStyle and are Chinese on every platform (Lark, Slack, Telegram, Mattermost alike). Fixing that means threading a locale through FormatIMDisplayContent, which has no platform context — a cross-platform change, not a Lark one. Documented as such. The channel-creation 400 message is now derived from validIMPlatforms so the list cannot drift as platforms are added. Tests: region invariants and per-region URL construction on both sides, the Feishu/Lark bot-identity split, platform-to-channel mapping, base_url override precedence, an end-to-end SendReply against a fake Open Platform (token fetch, reply, thread-unsupported fallback, hard-error surfacing), and a ListResources drive asserting wiki links never leak the other cloud's host. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
83 lines
3.1 KiB
Go
83 lines
3.1 KiB
Go
package feishu
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/internal/types"
|
|
)
|
|
|
|
func TestRegions_AreDistinct(t *testing.T) {
|
|
if RegionFeishu.ConnectorType == RegionLark.ConnectorType {
|
|
t.Errorf("regions share ConnectorType %q", RegionFeishu.ConnectorType)
|
|
}
|
|
if RegionFeishu.OpenBaseURL == RegionLark.OpenBaseURL {
|
|
t.Errorf("regions share OpenBaseURL %q", RegionFeishu.OpenBaseURL)
|
|
}
|
|
if RegionFeishu.WebBaseURL == RegionLark.WebBaseURL {
|
|
t.Errorf("regions share WebBaseURL %q", RegionFeishu.WebBaseURL)
|
|
}
|
|
if RegionFeishu.ConnectorType != types.ConnectorTypeFeishu {
|
|
t.Errorf("RegionFeishu.ConnectorType = %q, want %q", RegionFeishu.ConnectorType, types.ConnectorTypeFeishu)
|
|
}
|
|
if RegionLark.ConnectorType != types.ConnectorTypeLark {
|
|
t.Errorf("RegionLark.ConnectorType = %q, want %q", RegionLark.ConnectorType, types.ConnectorTypeLark)
|
|
}
|
|
}
|
|
|
|
func TestConnectorType_FollowsRegion(t *testing.T) {
|
|
if got := NewConnector(RegionFeishu).Type(); got != types.ConnectorTypeFeishu {
|
|
t.Errorf("Feishu connector Type() = %q, want %q", got, types.ConnectorTypeFeishu)
|
|
}
|
|
if got := NewConnector(RegionLark).Type(); got != types.ConnectorTypeLark {
|
|
t.Errorf("Lark connector Type() = %q, want %q", got, types.ConnectorTypeLark)
|
|
}
|
|
}
|
|
|
|
// The wiki link shown in the resource picker must point at the cloud the data
|
|
// actually lives on. Feishu's value is the pre-existing one and must not drift.
|
|
func TestRegion_WikiURL(t *testing.T) {
|
|
if got, want := RegionFeishu.wikiURL("spc123"), "https://feishu.cn/wiki/spc123"; got != want {
|
|
t.Errorf("Feishu wikiURL = %q, want %q", got, want)
|
|
}
|
|
if got, want := RegionLark.wikiURL("spc123"), "https://larksuite.com/wiki/spc123"; got != want {
|
|
t.Errorf("Lark wikiURL = %q, want %q", got, want)
|
|
}
|
|
// A Lark link must never point at the Feishu host — that was the bug.
|
|
if strings.Contains(RegionLark.wikiURL("x"), "feishu") {
|
|
t.Errorf("Lark wikiURL leaks the Feishu host: %q", RegionLark.wikiURL("x"))
|
|
}
|
|
}
|
|
|
|
// base_url stays an override so data sources created before the lark connector
|
|
// existed — a "feishu" connector pointed at open.larksuite.com — keep working.
|
|
func TestParseFeishuConfig_BaseURLDefaultsToRegion(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
region Region
|
|
baseURL string
|
|
want string
|
|
}{
|
|
{"feishu default", RegionFeishu, "", "https://open.feishu.cn"},
|
|
{"lark default", RegionLark, "", "https://open.larksuite.com"},
|
|
{"explicit override wins on feishu", RegionFeishu, "https://open.larksuite.com", "https://open.larksuite.com"},
|
|
{"explicit override wins on lark", RegionLark, "https://open.feishu.cn", "https://open.feishu.cn"},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
creds := map[string]interface{}{"app_id": "cli_x", "app_secret": "s"}
|
|
if c.baseURL != "" {
|
|
creds["base_url"] = c.baseURL
|
|
}
|
|
cfg, err := parseFeishuConfig(&types.DataSourceConfig{Credentials: creds}, c.region)
|
|
if err != nil {
|
|
t.Fatalf("parseFeishuConfig: %v", err)
|
|
}
|
|
if got := cfg.GetBaseURL(); got != c.want {
|
|
t.Errorf("GetBaseURL() = %q, want %q", got, c.want)
|
|
}
|
|
})
|
|
}
|
|
}
|