9afb8b7b68
Lark and Feishu are the same product deployed on two isolated clouds (open.larksuite.com and open.feishu.cn). WeKnora touches both from two places — the IM bot and the Wiki data-source connector — and this brings Lark to parity across both. Neither API surface differs, so rather than duplicate either implementation, each is parametrized by a Region and registered twice. IM (internal/im/feishu): Every API call routes through a.api(), which prefixes the region's host, and the WebSocket client passes larkws.WithDomain — the SDK defaults to open.feishu.cn, so Lark long connections would otherwise fail to authenticate. Data source (internal/datasource/connector/feishu): Lark was half-supported: the client honoured a base_url override and a LarkBaseURL constant existed, but the connector registered only as "feishu" and the UI never exposed base_url, so Lark wikis could not be configured at all. Lark is now its own connector type. base_url is kept as an explicit override so data sources that pointed a "feishu" connector at open.larksuite.com keep working. Bugs found and fixed along the way: - Wiki resource links were hardcoded to https://feishu.cn/wiki/{token} in four places, so a Lark wiki linked into the wrong cloud entirely. - Bot identity is now platform-prefixed (feishu:cli_x vs lark:cli_x). BotIdentity carries a unique index, so without this a Lark channel would be rejected as a duplicate of an unrelated Feishu bot sharing an app_id. - The card image cache is now keyed by app_id. image_keys are issued per app on one cloud; a Feishu key handed to a Lark app fails the card update with code=200570. - The datasource doc claimed Lark "adapts automatically" — it could not, since the UI had no way to reach base_url. Permissions are where the clouds genuinely diverge. Identical APIs do not mean identical permission catalogues: aily:file:read, aily:file:write and corehr:file:download exist on Feishu but not on Lark, so pasting Feishu's scope JSON into Lark fails to import. That JSON is also over-broad (it covers products WeKnora never calls) and simultaneously incomplete (it omits the drive:*/docx:* scopes the connector needs). Lark therefore gets its own list, derived from the 17 endpoints the code actually calls and checked identifier-by-identifier against Lark's own API reference, plus a full Feishu→Lark mapping table marking each scope verified, unverified, or absent. Both features use tenant_access_token only — no user_access_ token exists anywhere in the repo — so the user dimension stays empty. Known limitation: Region.ThinkingText makes Lark's initial card placeholder English, but once streaming starts the think-block headers come from the shared MarkdownThinkStyle and are Chinese on every platform (Lark, Slack, Telegram, Mattermost alike). Fixing that means threading a locale through FormatIMDisplayContent, which has no platform context — a cross-platform change, not a Lark one. Documented as such. The channel-creation 400 message is now derived from validIMPlatforms so the list cannot drift as platforms are added. Tests: region invariants and per-region URL construction on both sides, the Feishu/Lark bot-identity split, platform-to-channel mapping, base_url override precedence, an end-to-end SendReply against a fake Open Platform (token fetch, reply, thread-unsupported fallback, hard-error surfacing), and a ListResources drive asserting wiki links never leak the other cloud's host. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
58 lines
1.9 KiB
Go
58 lines
1.9 KiB
Go
package feishu
|
|
|
|
import "github.com/Tencent/WeKnora/internal/types"
|
|
|
|
// Open Platform API origins. Feishu and Lark are the same product deployed on
|
|
// two isolated clouds; the wiki/docx/drive APIs this connector uses are
|
|
// identical, only the host differs.
|
|
const (
|
|
feishuOpenBaseURL = "https://open.feishu.cn"
|
|
larkOpenBaseURL = "https://open.larksuite.com"
|
|
)
|
|
|
|
// Web origins used to build human-facing links to wiki spaces and nodes. These
|
|
// are the end-user app hosts, not the API hosts.
|
|
const (
|
|
feishuWebBaseURL = "https://feishu.cn"
|
|
larkWebBaseURL = "https://larksuite.com"
|
|
)
|
|
|
|
// Region selects which cloud the connector syncs from. Apps, tenants, tokens
|
|
// and document tokens are scoped to a single cloud and are never valid on the
|
|
// other, so a Region is fixed per connector instance at registration.
|
|
type Region struct {
|
|
// ConnectorType is the types.ConnectorType* identifier this instance serves.
|
|
ConnectorType string
|
|
// OpenBaseURL is the Open Platform API origin, without a trailing slash.
|
|
// It is only the default: a data source may override it via base_url.
|
|
OpenBaseURL string
|
|
// WebBaseURL is the app origin used to build wiki links shown to users.
|
|
WebBaseURL string
|
|
// Label prefixes log lines so operators can tell the clouds apart.
|
|
Label string
|
|
}
|
|
|
|
var (
|
|
// RegionFeishu is the Chinese mainland cloud (飞书).
|
|
RegionFeishu = Region{
|
|
ConnectorType: types.ConnectorTypeFeishu,
|
|
OpenBaseURL: feishuOpenBaseURL,
|
|
WebBaseURL: feishuWebBaseURL,
|
|
Label: "Feishu",
|
|
}
|
|
|
|
// RegionLark is the international cloud (Lark).
|
|
RegionLark = Region{
|
|
ConnectorType: types.ConnectorTypeLark,
|
|
OpenBaseURL: larkOpenBaseURL,
|
|
WebBaseURL: larkWebBaseURL,
|
|
Label: "Lark",
|
|
}
|
|
)
|
|
|
|
// wikiURL builds the user-facing link to a wiki space or node on this cloud.
|
|
// The token is either a space_id or a node_token; both live under /wiki/.
|
|
func (r Region) wikiURL(token string) string {
|
|
return r.WebBaseURL + "/wiki/" + token
|
|
}
|