9afb8b7b68
Lark and Feishu are the same product deployed on two isolated clouds (open.larksuite.com and open.feishu.cn). WeKnora touches both from two places — the IM bot and the Wiki data-source connector — and this brings Lark to parity across both. Neither API surface differs, so rather than duplicate either implementation, each is parametrized by a Region and registered twice. IM (internal/im/feishu): Every API call routes through a.api(), which prefixes the region's host, and the WebSocket client passes larkws.WithDomain — the SDK defaults to open.feishu.cn, so Lark long connections would otherwise fail to authenticate. Data source (internal/datasource/connector/feishu): Lark was half-supported: the client honoured a base_url override and a LarkBaseURL constant existed, but the connector registered only as "feishu" and the UI never exposed base_url, so Lark wikis could not be configured at all. Lark is now its own connector type. base_url is kept as an explicit override so data sources that pointed a "feishu" connector at open.larksuite.com keep working. Bugs found and fixed along the way: - Wiki resource links were hardcoded to https://feishu.cn/wiki/{token} in four places, so a Lark wiki linked into the wrong cloud entirely. - Bot identity is now platform-prefixed (feishu:cli_x vs lark:cli_x). BotIdentity carries a unique index, so without this a Lark channel would be rejected as a duplicate of an unrelated Feishu bot sharing an app_id. - The card image cache is now keyed by app_id. image_keys are issued per app on one cloud; a Feishu key handed to a Lark app fails the card update with code=200570. - The datasource doc claimed Lark "adapts automatically" — it could not, since the UI had no way to reach base_url. Permissions are where the clouds genuinely diverge. Identical APIs do not mean identical permission catalogues: aily:file:read, aily:file:write and corehr:file:download exist on Feishu but not on Lark, so pasting Feishu's scope JSON into Lark fails to import. That JSON is also over-broad (it covers products WeKnora never calls) and simultaneously incomplete (it omits the drive:*/docx:* scopes the connector needs). Lark therefore gets its own list, derived from the 17 endpoints the code actually calls and checked identifier-by-identifier against Lark's own API reference, plus a full Feishu→Lark mapping table marking each scope verified, unverified, or absent. Both features use tenant_access_token only — no user_access_ token exists anywhere in the repo — so the user dimension stays empty. Known limitation: Region.ThinkingText makes Lark's initial card placeholder English, but once streaming starts the think-block headers come from the shared MarkdownThinkStyle and are Chinese on every platform (Lark, Slack, Telegram, Mattermost alike). Fixing that means threading a locale through FormatIMDisplayContent, which has no platform context — a cross-platform change, not a Lark one. Documented as such. The channel-creation 400 message is now derived from validIMPlatforms so the list cannot drift as platforms are added. Tests: region invariants and per-region URL construction on both sides, the Feishu/Lark bot-identity split, platform-to-channel mapping, base_url override precedence, an end-to-end SendReply against a fake Open Platform (token fetch, reply, thread-unsupported fallback, hard-error surfacing), and a ListResources drive asserting wiki links never leak the other cloud's host. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
87 lines
2.6 KiB
Go
87 lines
2.6 KiB
Go
package feishu
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/internal/types"
|
|
)
|
|
|
|
// A Lark connector must surface wiki links on the Lark host. Before Lark became
|
|
// its own connector type, every resource URL was hardcoded to feishu.cn, so Lark
|
|
// users got links into a cloud their content does not live on.
|
|
//
|
|
// The fake server stands in for the Open Platform (base_url points at it), but
|
|
// the resource URL is built from the region's web host, so this exercises the
|
|
// real ListResources → wikiNodeToResource → region.wikiURL path.
|
|
func TestListResources_ResourceURLFollowsRegion(t *testing.T) {
|
|
cases := []struct {
|
|
region Region
|
|
wantURL string
|
|
forbiddenIn string
|
|
}{
|
|
{RegionFeishu, "https://feishu.cn/wiki/space1", "larksuite"},
|
|
{RegionLark, "https://larksuite.com/wiki/space1", "feishu"},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.region.Label, func(t *testing.T) {
|
|
ts, cfg := fakeFeishu(nil)
|
|
defer ts.Close()
|
|
|
|
conn := NewConnector(c.region)
|
|
resources, err := conn.ListResources(context.Background(), makeConfig(cfg, nil), "")
|
|
if err != nil {
|
|
t.Fatalf("ListResources: %v", err)
|
|
}
|
|
if len(resources) != 1 {
|
|
t.Fatalf("got %d resources, want 1", len(resources))
|
|
}
|
|
if got := resources[0].URL; got != c.wantURL {
|
|
t.Errorf("resource URL = %q, want %q", got, c.wantURL)
|
|
}
|
|
if strings.Contains(resources[0].URL, c.forbiddenIn) {
|
|
t.Errorf("%s resource URL leaks the other cloud's host: %q", c.region.Label, resources[0].URL)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// A Lark connector with no base_url override must reach open.larksuite.com,
|
|
// never open.feishu.cn — the SDK-less client has no default of its own, so the
|
|
// region is the only thing standing between a Lark app and the wrong cloud.
|
|
func TestClient_ResolvesRegionHostWithoutOverride(t *testing.T) {
|
|
cases := []struct {
|
|
region Region
|
|
want string
|
|
}{
|
|
{RegionFeishu, "https://open.feishu.cn"},
|
|
{RegionLark, "https://open.larksuite.com"},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.region.Label, func(t *testing.T) {
|
|
cfg, err := parseFeishuConfig(makeConfigNoBaseURL(), c.region)
|
|
if err != nil {
|
|
t.Fatalf("parseFeishuConfig: %v", err)
|
|
}
|
|
client := NewClient(cfg)
|
|
if client.baseURL != c.want {
|
|
t.Errorf("client baseURL = %q, want %q", client.baseURL, c.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// makeConfigNoBaseURL builds credentials without base_url, so the region default
|
|
// is what resolves.
|
|
func makeConfigNoBaseURL() *types.DataSourceConfig {
|
|
return &types.DataSourceConfig{
|
|
Credentials: map[string]interface{}{
|
|
"app_id": "cli_x",
|
|
"app_secret": "s",
|
|
},
|
|
}
|
|
}
|