9cce0c8e5e
Replace the standalone /platform/system/* routes with a single
"系统设置" section inside the canonical Settings modal. The previous
SystemLayout.vue / SystemAdmins.vue surfaces are removed and their
functionality (system admin roster, global settings) is hosted directly
in SystemSettings.vue under the standard `.section-header` /
`.settings-group` skeleton. Legacy URLs redirect to the modal section
so external bookmarks don't 404.
Backend:
- SystemSettingService.Reset + repo.Delete: drop the DB override for a
key so the 3-tier resolver falls back to ENV / built-in default.
Idempotent (resetting a never-persisted key returns nil); emits an
audit row only on real deletions, invalidates the local cache, and
publishes to peers via the existing pubsub channel.
- TenantService.BulkSetStorageQuota: overwrite every tenant's
storage_quota in one statement. Powers POST /system/admin/tenants/
apply-default-storage-quota; bypasses the per-tenant whitelist on
PUT /tenants/:id which intentionally forbids storage_quota edits.
- AuditAction{SystemAdminPromoted,SystemAdminRevoked} constants and
emitAdminAudit() in SystemHandler — promote / revoke now leave an
audit trail with TenantID=0 and {target_email,target_username,
idempotent|changed} in details.
- SystemSetting.LastModifiedByName: derived per-request display label
(username, email fallback) so the UI shows "wizardchen" instead of
a UUID prefix without storing a denormalised column.
Frontend:
- SystemSettings.vue rewritten against the Settings modal skeleton with
auto-persisting controls (switch/select @change, input/inputnumber
@blur, tag-input + per-delta popconfirm for SSRF whitelist and admin
roster). auth.registration_mode change goes through an inline
popconfirm; cancel rolls back. Reset / bulk-apply also inline
popconfirms — no dialog modal for these per-row affordances.
- Priority hint panel surfaces the DB > ENV > default resolver order
so operators can reason about "I set the env but it doesn't show up".
- Router: /platform/system, /platform/system/settings, /platform/system/
admins are now compatibility redirects to /platform/settings?section=
system-global.
- Settings modal sized 900x700 → 1080x780 and content-wrapper 600 → 760
so the wider tables (members, system settings) breathe; <1100px
viewport still flexes to the screen.
- i18n: system.globalSettings.* keys for title / description / loading /
empty / badges / priority hint / per-key labels / reset / bulkApply /
admins (label, placeholder, save messages, popconfirm copy) across
zh-CN, en-US, ko-KR, ru-RU.
Misc:
- internal/utils/filesize.go doc: clarify MAX_FILE_SIZE_MB is a
deploy-time-only knob (nginx + docreader + frontend each cache the
env at startup); a SystemAdmin UI override would mislead operators
because nginx would still 413. Until all four layers can hot-reload
the limit in lockstep, this stays env-only.
- internal/utils/security.go: SSRF whitelist parser/runtime now drives
off SystemSettingService for live updates; ENV remains the fallback
for never-overridden deployments.
91 lines
3.2 KiB
Go
91 lines
3.2 KiB
Go
package repository
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
"github.com/Tencent/WeKnora/internal/types"
|
|
"github.com/Tencent/WeKnora/internal/types/interfaces"
|
|
"gorm.io/gorm"
|
|
"gorm.io/gorm/clause"
|
|
)
|
|
|
|
// systemSettingRepository implements interfaces.SystemSettingRepository
|
|
// against the system_settings table (migration 000053). The table is
|
|
// system-scoped (no tenant_id column) and intentionally tiny — single-
|
|
// digit rows in P1 — so List does not paginate.
|
|
type systemSettingRepository struct {
|
|
db *gorm.DB
|
|
}
|
|
|
|
// NewSystemSettingRepository wires the repo into the dig container.
|
|
// Receives the shared *gorm.DB; no other deps.
|
|
func NewSystemSettingRepository(db *gorm.DB) interfaces.SystemSettingRepository {
|
|
return &systemSettingRepository{db: db}
|
|
}
|
|
|
|
// Get fetches a system setting by key. Returns (nil, nil) when the row
|
|
// does not exist — the resolver service treats "missing" as "fall back
|
|
// to ENV / default", so a 404 here is a normal control-flow signal,
|
|
// not an error. Real DB errors (connection lost, etc.) surface up.
|
|
func (r *systemSettingRepository) Get(ctx context.Context, key string) (*types.SystemSetting, error) {
|
|
var s types.SystemSetting
|
|
err := r.db.WithContext(ctx).Where("key = ?", key).First(&s).Error
|
|
if err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return nil, nil
|
|
}
|
|
return nil, err
|
|
}
|
|
return &s, nil
|
|
}
|
|
|
|
// List returns every system_settings row, ordered by category then key
|
|
// for stable management-UI rendering. No pagination — see type comment.
|
|
func (r *systemSettingRepository) List(ctx context.Context) ([]*types.SystemSetting, error) {
|
|
var rows []*types.SystemSetting
|
|
err := r.db.WithContext(ctx).Order("category ASC, key ASC").Find(&rows).Error
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return rows, nil
|
|
}
|
|
|
|
// Upsert writes the row keyed by Key. We use ON CONFLICT (key) DO UPDATE
|
|
// rather than the naive Save() because (a) the natural key is `key`, not
|
|
// `id`, and (b) the seeded migration row already has an id; a Save with
|
|
// id=0 would re-insert and trip the UNIQUE constraint. Updating only
|
|
// the mutable columns prevents the migration's seeded id/created_at
|
|
// from being overwritten.
|
|
func (r *systemSettingRepository) Upsert(ctx context.Context, s *types.SystemSetting) error {
|
|
return r.db.WithContext(ctx).
|
|
Clauses(clause.OnConflict{
|
|
Columns: []clause.Column{{Name: "key"}},
|
|
DoUpdates: clause.AssignmentColumns([]string{
|
|
"value",
|
|
"value_type",
|
|
"category",
|
|
"description",
|
|
"is_secret",
|
|
"requires_restart",
|
|
"last_modified_by",
|
|
"updated_at",
|
|
}),
|
|
}).
|
|
Create(s).Error
|
|
}
|
|
|
|
// Delete removes the row by key. The boolean return indicates whether
|
|
// a row was actually deleted, so the service layer can audit only real
|
|
// deletions (vs the idempotent no-op when the key was already absent).
|
|
// gorm's RowsAffected is 0 for "no match" — we keep that as (false, nil)
|
|
// rather than translating to gorm.ErrRecordNotFound so the caller's
|
|
// happy path is a single nil check on err.
|
|
func (r *systemSettingRepository) Delete(ctx context.Context, key string) (bool, error) {
|
|
res := r.db.WithContext(ctx).Where("key = ?", key).Delete(&types.SystemSetting{})
|
|
if res.Error != nil {
|
|
return false, res.Error
|
|
}
|
|
return res.RowsAffected > 0, nil
|
|
}
|