d3c03b2f34
A hardening + finalization pass over the agent-first CLI: correctness fixes,
richer machine-readable signals, flag/naming consistency, and a symmetric
config surface. Pre-1.0, so it includes breaking renames.
Correctness:
- agent update: resolve/validate --model/--rerank-model (was storing a bogus
name verbatim, corrupting config.model_id).
- doctor: honor WEKNORA_HOST / WEKNORA_API_KEY (headless path no longer reports
"no host configured").
- session ask / MCP session_ask: text answer was empty on non-TTY — the agent
stream sets Done=true on an intermediate agent_query frame before the answer,
and AgentAccumulator treated the first Done as terminal. Terminate on the
`complete` event (new sdk.AgentResponseTypeComplete), not a per-frame Done.
- batch exit codes: any per-item failure collapses to operation.failed (exit 1),
including `doc upload --recursive` partial failures — a permanent per-file
failure (e.g. a duplicate) no longer surfaces as a retryable exit 7 an agent
would loop on; per-item typed errors stay in the envelope.
Agent-first signals & discovery:
- error.exit_code in the envelope (type + exit_code disambiguate the
input.invalid_argument exit-2-vs-5 split in one JSON read).
- meta.hint on empty content search and on draft doc create; doc wait fails fast
on a never-parsing draft instead of hanging to --timeout.
- retrieval-readiness is visible in the natural flow: kb status / kb check emit
retrieval_ready, and kb create hints the fix when no embedding model is bound
— an unconfigured KB no longer looks silently healthy.
- schema contract completeness: every leaf declares output + >=1 example
(drift-guarded); output strings match the meta actually emitted; chunk list
and search docs now emit meta.total_count (both previously dropped it).
- schema tolerates a quoted multi-word command label; zero-state auth — and
`link` with no profile — point at profile setup / the headless WEKNORA_KB_ID
path instead of looping on `auth login`.
- id-addressed reads tolerate a redundant --kb (doc view/wait, chunk list/view
accept and ignore it, declared in schema) so a carried-over --kb doesn't
exit 2; streaming commands warn that --jq does not apply to an NDJSON stream.
- keep JSON-always as the default; --jq hints spell out the .data path.
Consistency & gating:
- doc create: drop the deprecated --name alias (--title only; pre-1.0 break).
- chunk list --limit aligned to 1..10000; model list --limit/-L with
has_more/total_count; api write-gates -X PUT/PATCH (exit 10); skills install
expands a leading ~.
- docs corrected: search docs / doc list --keyword help is case-insensitive
(server does LOWER LIKE); AGENTS.md risk-action list (no phantom kb.init; add
model.update / kb.config.set) and batch example (failed item carries `error`);
session resume --message id comes from `message list`, not the stream.
- auth/profile ergonomics: env credentials are now first-class — `auth token`
prints the active WEKNORA_API_KEY / WEKNORA_TOKEN, and auth login/logout/refresh
give an env-aware message instead of looping on "run auth login". `auth logout`
clears credentials but keeps the profile registered (host preserved for
re-login); deleting a profile is `profile remove`'s job (clean logout/remove
separation, matching gh / lark).
Config surface (symmetric read/write, in-place model edits):
- kb config now returns a secret-free KBModelConfigView (was {}); `kb config`
reads, new `kb config set` writes; `kb init` removed (misnomer).
- kb create --chat-model: retrieval-ready in one step.
- model update: edit a model in place (id preserved, references survive) —
rotate --api-key-stdin, change base-url / display-name / etc.
- session continue-stream renamed to session resume.
Docs: AGENTS.md is the single wire-contract source; CHANGELOG slimmed; stale
kb-init / continue-stream references removed; skill wire-vocab guard extended.
AGENTS.md / weknora-shared SKILL document retrieval_ready (a KB needs an
embedding model to be searchable), that --jq does not apply to NDJSON
streams, and the env-credential-first auth path; the KB quickstart example
now creates a retrieval-ready KB.
162 lines
5.7 KiB
Go
162 lines
5.7 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// CheckResult is the deep-verification response for `kb check <id>`.
|
|
// Superset of StatusResult: includes all status fields plus FailedCount
|
|
// aggregated by paging the doc list. Verb split with `kb status`:
|
|
// status reads existing state cheaply, check actively verifies.
|
|
type CheckResult struct {
|
|
ID string `json:"id"`
|
|
Reachable bool `json:"reachable"`
|
|
// RetrievalReady is false when no embedding model is bound — the KB can never
|
|
// index/retrieve regardless of failed_count. Always emitted (no omitempty) so
|
|
// an unconfigured KB is not reported as silently healthy.
|
|
RetrievalReady bool `json:"retrieval_ready"`
|
|
KnowledgeCount int64 `json:"knowledge_count,omitempty"`
|
|
ChunkCount int64 `json:"chunk_count,omitempty"`
|
|
IsProcessing bool `json:"is_processing,omitempty"`
|
|
ProcessingCount int64 `json:"processing_count,omitempty"`
|
|
FailedCount int64 `json:"failed_count"` // always populated (no omitempty)
|
|
}
|
|
|
|
// CheckService is the narrow SDK surface needed for kb check.
|
|
type CheckService interface {
|
|
GetKnowledgeBase(ctx context.Context, id string) (*sdk.KnowledgeBase, error)
|
|
ListKnowledgeWithFilter(ctx context.Context, kbID string, page, pageSize int, filter sdk.KnowledgeListFilter) ([]sdk.Knowledge, int64, error)
|
|
}
|
|
|
|
var kbCheckFields = []string{
|
|
"id", "reachable", "retrieval_ready", "knowledge_count", "chunk_count",
|
|
"is_processing", "processing_count", "failed_count",
|
|
}
|
|
|
|
// NewCmdCheck builds `weknora kb check <id>`.
|
|
func NewCmdCheck(f *cmdutil.Factory) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "check <kb-id>",
|
|
Short: "Verify a knowledge base end-to-end (status + failed-doc aggregation)",
|
|
Long: `Active verification of a knowledge base.
|
|
|
|
Performs 1 + N HTTP calls:
|
|
1 GET /kb/{id} — reachable + counts + processing state
|
|
N page-walk doc list with parse_status=failed — failed_count
|
|
|
|
Use 'weknora kb status <id>' for a fast read-only health snapshot
|
|
(1 HTTP call, no failed_count). Use 'kb check' when you need
|
|
verification including failed-doc aggregation.`,
|
|
Example: ` weknora kb check kb_abc
|
|
weknora kb check kb_abc --format json`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
res, err := runCheck(c.Context(), cli, args[0])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return emitCheck(res, fopts, iostreams.IO.Out)
|
|
},
|
|
}
|
|
cmdutil.AddFormatFlag(cmd, kbCheckFields...)
|
|
cmdutil.SetAgentHelp(cmd, cmdutil.AgentHelp{
|
|
UsedFor: "verify a knowledge base end-to-end: status plus failed-doc aggregation",
|
|
RequiredFlags: []string{"<kb-id> (positional)"},
|
|
Examples: []string{"weknora kb check kb_abc"},
|
|
Output: "envelope.data is {id, reachable, retrieval_ready, failed_count, ...}; retrieval_ready=false means no embedding model is bound (run `kb config set`); deeper than `kb status`",
|
|
})
|
|
return cmd
|
|
}
|
|
|
|
// runCheck is the testable core: status fields + failed-doc aggregation.
|
|
// Never returns an error for "kb not reachable" (Reachable=false carries
|
|
// the signal).
|
|
func runCheck(ctx context.Context, svc CheckService, id string) (*CheckResult, error) {
|
|
kb, err := svc.GetKnowledgeBase(ctx, id)
|
|
if err != nil {
|
|
return &CheckResult{ID: id, Reachable: false}, nil
|
|
}
|
|
res := &CheckResult{
|
|
ID: kb.ID,
|
|
Reachable: true,
|
|
RetrievalReady: kb.EmbeddingModelID != "",
|
|
KnowledgeCount: kb.KnowledgeCount,
|
|
ChunkCount: kb.ChunkCount,
|
|
IsProcessing: kb.IsProcessing,
|
|
ProcessingCount: kb.ProcessingCount,
|
|
}
|
|
failed, err := aggregateFailedCount(ctx, svc, id)
|
|
if err != nil {
|
|
return res, fmt.Errorf("aggregate failed_count: %w", err)
|
|
}
|
|
res.FailedCount = failed
|
|
return res, nil
|
|
}
|
|
|
|
// aggregateFailedCount pages the doc list with parse_status=failed and
|
|
// returns the total count. Termination uses accumulated total (not
|
|
// page*pageSize) so server-capped page sizes don't truncate.
|
|
func aggregateFailedCount(ctx context.Context, svc CheckService, kbID string) (int64, error) {
|
|
const pageSize = 100
|
|
var total int64
|
|
page := 1
|
|
for {
|
|
docs, totalAvailable, err := svc.ListKnowledgeWithFilter(ctx, kbID, page, pageSize, sdk.KnowledgeListFilter{ParseStatus: "failed"})
|
|
if err != nil {
|
|
return total, err
|
|
}
|
|
total += int64(len(docs))
|
|
if total >= totalAvailable || len(docs) == 0 {
|
|
break
|
|
}
|
|
page++
|
|
}
|
|
return total, nil
|
|
}
|
|
|
|
// emitCheck renders res. Same dispatch as emitStatus.
|
|
func emitCheck(res *CheckResult, fopts *cmdutil.FormatOptions, w io.Writer) error {
|
|
switch fopts.Mode {
|
|
case cmdutil.FormatJSON, cmdutil.FormatNDJSON:
|
|
return fopts.Emit(w, res, nil)
|
|
case cmdutil.FormatText, "":
|
|
return writeCheckText(w, res)
|
|
default:
|
|
return fmt.Errorf("unsupported --format %q for kb check", fopts.Mode)
|
|
}
|
|
}
|
|
|
|
func writeCheckText(w io.Writer, res *CheckResult) error {
|
|
fmt.Fprintf(w, "ID: %s\n", res.ID)
|
|
fmt.Fprintf(w, "Reachable: %v\n", res.Reachable)
|
|
if !res.Reachable {
|
|
return nil
|
|
}
|
|
fmt.Fprintf(w, "Retrieval: %v%s\n", res.RetrievalReady, retrievalHint(res.RetrievalReady))
|
|
fmt.Fprintf(w, "Knowledge: %d\n", res.KnowledgeCount)
|
|
fmt.Fprintf(w, "Chunks: %d\n", res.ChunkCount)
|
|
fmt.Fprintf(w, "Processing: %v (%d active)\n", res.IsProcessing, res.ProcessingCount)
|
|
fmt.Fprintf(w, "Failed: %d\n", res.FailedCount)
|
|
return nil
|
|
}
|
|
|
|
// compile-time check: SDK client satisfies CheckService.
|
|
var _ CheckService = (*sdk.Client)(nil)
|