7f7a48880f
Lay the foundation for tenant-level RBAC without enforcing it yet. Schema, types, middleware lookup, and login-flow shape changes ship now; RequireRole/route annotations and member-management endpoints follow in PR 2 and PR 3. Highlights: - New tenant_members table (Postgres + SQLite) with (user_id, tenant_id) unique key and (owner|admin|contributor|viewer) role values. Migration 000043 backfills one row per existing user, marking the earliest-created active user in each tenant as Owner and the rest as Contributor. - KnowledgeBase.creator_id and CustomAgent.runnable_by_viewer added so PR 2 can wire ownership-based and Viewer-runtime checks. - Auth middleware loads the active TenantMember row, sets a new TenantRoleContextKey, and falls back via three escape hatches: cross-tenant superusers (CanAccessAllTenants) get Admin in the target tenant; orphan tenants (zero members) auto-promote the first authenticating human to Owner; and when tenant.enable_rbac is false (the v1 default) unmatched lookups fail open with Admin to preserve current behaviour. - Register / OIDC provisioning now insert an Owner membership for the registrant via TenantMemberService.EnsureOwner. - LoginResponse renamed tenant -> active_tenant and gained a memberships array. POST /auth/switch-tenant issues a fresh token pair scoped to a target membership; GET /auth/config exposes auth.registration_mode for the frontend register-tab gating. - New config keys: auth.registration_mode (self_serve | invite_only, defaults to self_serve) and tenant.enable_rbac (defaults to false). Both have WEKNORA_* env overrides. - Frontend store persists memberships and exposes currentTenantRole; Login.vue calls /auth/config and hides the Register tab in invite_only mode. Go SDK types updated to match the new LoginResponse shape.
189 lines
5.7 KiB
Go
189 lines
5.7 KiB
Go
package service
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"time"
|
|
|
|
"github.com/Tencent/WeKnora/internal/logger"
|
|
"github.com/Tencent/WeKnora/internal/types"
|
|
"github.com/Tencent/WeKnora/internal/types/interfaces"
|
|
)
|
|
|
|
// Sentinel errors returned by tenantMemberService. Callers compare with
|
|
// errors.Is to render appropriate HTTP responses (404 / 409 / 403).
|
|
var (
|
|
// ErrMembershipNotFound is returned when no active membership row
|
|
// matches the (user, tenant) pair the caller requested.
|
|
ErrMembershipNotFound = errors.New("tenant membership not found")
|
|
|
|
// ErrMembershipAlreadyExists is returned by AddMember when the
|
|
// (user, tenant) pair already has an active membership.
|
|
ErrMembershipAlreadyExists = errors.New("tenant membership already exists")
|
|
|
|
// ErrInvalidTenantRole is returned when the caller passes a role
|
|
// value that is not one of the four defined TenantRole constants.
|
|
ErrInvalidTenantRole = errors.New("invalid tenant role")
|
|
|
|
// ErrLastOwner is returned when an operation would leave the tenant
|
|
// without an active Owner. Demoting the last Owner or removing them
|
|
// is forbidden; an explicit ownership transfer must happen first.
|
|
ErrLastOwner = errors.New("cannot demote or remove the last active owner of the tenant")
|
|
)
|
|
|
|
// tenantMemberService implements interfaces.TenantMemberService.
|
|
type tenantMemberService struct {
|
|
repo interfaces.TenantMemberRepository
|
|
}
|
|
|
|
// NewTenantMemberService constructs the service. Wired up via the DI
|
|
// container alongside the other application services.
|
|
func NewTenantMemberService(repo interfaces.TenantMemberRepository) interfaces.TenantMemberService {
|
|
return &tenantMemberService{repo: repo}
|
|
}
|
|
|
|
// AddMember inserts a new active membership row. Returns
|
|
// ErrMembershipAlreadyExists if the user is already an active member of
|
|
// the tenant, and ErrInvalidTenantRole for unknown roles.
|
|
func (s *tenantMemberService) AddMember(
|
|
ctx context.Context,
|
|
userID string,
|
|
tenantID uint64,
|
|
role types.TenantRole,
|
|
invitedBy *string,
|
|
) (*types.TenantMember, error) {
|
|
if !role.IsValid() {
|
|
return nil, ErrInvalidTenantRole
|
|
}
|
|
existing, err := s.repo.Get(ctx, userID, tenantID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if existing != nil {
|
|
return nil, ErrMembershipAlreadyExists
|
|
}
|
|
member := &types.TenantMember{
|
|
UserID: userID,
|
|
TenantID: tenantID,
|
|
Role: role,
|
|
Status: types.TenantMemberStatusActive,
|
|
InvitedBy: invitedBy,
|
|
JoinedAt: time.Now(),
|
|
}
|
|
if err := s.repo.Create(ctx, member); err != nil {
|
|
return nil, err
|
|
}
|
|
return member, nil
|
|
}
|
|
|
|
// EnsureOwner is idempotent: if the user already has an active membership
|
|
// in the tenant it is returned unchanged; otherwise a new owner row is
|
|
// created. Used by Register/OIDC paths so re-running Register on an
|
|
// existing user (e.g. after a partial failure) does not double-insert.
|
|
func (s *tenantMemberService) EnsureOwner(
|
|
ctx context.Context,
|
|
userID string,
|
|
tenantID uint64,
|
|
) (*types.TenantMember, error) {
|
|
existing, err := s.repo.Get(ctx, userID, tenantID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if existing != nil {
|
|
return existing, nil
|
|
}
|
|
member := &types.TenantMember{
|
|
UserID: userID,
|
|
TenantID: tenantID,
|
|
Role: types.TenantRoleOwner,
|
|
Status: types.TenantMemberStatusActive,
|
|
JoinedAt: time.Now(),
|
|
}
|
|
if err := s.repo.Create(ctx, member); err != nil {
|
|
return nil, err
|
|
}
|
|
logger.Infof(ctx, "Bootstrapped owner membership for user=%s tenant=%d", userID, tenantID)
|
|
return member, nil
|
|
}
|
|
|
|
// GetMembership returns the active membership or (nil, nil) when absent.
|
|
func (s *tenantMemberService) GetMembership(
|
|
ctx context.Context,
|
|
userID string,
|
|
tenantID uint64,
|
|
) (*types.TenantMember, error) {
|
|
return s.repo.Get(ctx, userID, tenantID)
|
|
}
|
|
|
|
// ListByUser proxies to the repository; included on the service so HTTP
|
|
// handlers depend only on the service interface.
|
|
func (s *tenantMemberService) ListByUser(ctx context.Context, userID string) ([]*types.TenantMember, error) {
|
|
return s.repo.ListByUser(ctx, userID)
|
|
}
|
|
|
|
// ListByTenant proxies to the repository.
|
|
func (s *tenantMemberService) ListByTenant(ctx context.Context, tenantID uint64) ([]*types.TenantMember, error) {
|
|
return s.repo.ListByTenant(ctx, tenantID)
|
|
}
|
|
|
|
// HasAnyMembers proxies to the repository.
|
|
func (s *tenantMemberService) HasAnyMembers(ctx context.Context, tenantID uint64) (bool, error) {
|
|
return s.repo.HasAnyMembers(ctx, tenantID)
|
|
}
|
|
|
|
// UpdateRole enforces the "cannot demote the last Owner" invariant before
|
|
// delegating to the repository. Re-promoting an existing Owner is a no-op
|
|
// from the invariant's perspective.
|
|
func (s *tenantMemberService) UpdateRole(
|
|
ctx context.Context,
|
|
userID string,
|
|
tenantID uint64,
|
|
newRole types.TenantRole,
|
|
) error {
|
|
if !newRole.IsValid() {
|
|
return ErrInvalidTenantRole
|
|
}
|
|
current, err := s.repo.Get(ctx, userID, tenantID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if current == nil {
|
|
return ErrMembershipNotFound
|
|
}
|
|
if current.Role == newRole {
|
|
return nil
|
|
}
|
|
if current.Role == types.TenantRoleOwner && newRole != types.TenantRoleOwner {
|
|
owners, err := s.repo.CountActiveOwners(ctx, tenantID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if owners <= 1 {
|
|
return ErrLastOwner
|
|
}
|
|
}
|
|
return s.repo.UpdateRole(ctx, userID, tenantID, newRole)
|
|
}
|
|
|
|
// RemoveMember enforces the "cannot remove the last Owner" invariant
|
|
// before soft-deleting the membership.
|
|
func (s *tenantMemberService) RemoveMember(ctx context.Context, userID string, tenantID uint64) error {
|
|
current, err := s.repo.Get(ctx, userID, tenantID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if current == nil {
|
|
return ErrMembershipNotFound
|
|
}
|
|
if current.Role == types.TenantRoleOwner {
|
|
owners, err := s.repo.CountActiveOwners(ctx, tenantID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if owners <= 1 {
|
|
return ErrLastOwner
|
|
}
|
|
}
|
|
return s.repo.SoftDelete(ctx, userID, tenantID)
|
|
}
|