adawang
ec66a3dac7
ParseLLMJsonResponse recompiled its ```json fence-extraction regexp on every call that fell through the direct-unmarshal fast path — i.e. every fenced LLM response on the graph-extraction path. Hoist it to a package-level var. Adds a test (none existed) covering direct, fenced, no-lang and prose-wrapped inputs, plus a benchmark. Benchmark, fenced payload (-benchmem): before: 3205 ns/op, 5712 B/op, 54 allocs/op after: 1315 ns/op, 693 B/op, 15 allocs/op Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
48 lines
1.2 KiB
Go
48 lines
1.2 KiB
Go
package common
|
|
|
|
import "testing"
|
|
|
|
func TestParseLLMJsonResponse(t *testing.T) {
|
|
type payload struct {
|
|
Key string `json:"key"`
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
content string
|
|
want string
|
|
wantErr bool
|
|
}{
|
|
{"direct json", `{"key":"value"}`, "value", false},
|
|
{"fenced json", "```json\n{\"key\":\"fenced\"}\n```", "fenced", false},
|
|
{"fenced no lang", "```\n{\"key\":\"plain\"}\n```", "plain", false},
|
|
{"prose around fence", "Here you go:\n```json\n{\"key\":\"wrapped\"}\n```\nThanks", "wrapped", false},
|
|
{"not json", "just some text", "", true},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
var got payload
|
|
err := ParseLLMJsonResponse(tt.content, &got)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Fatalf("err = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if !tt.wantErr && got.Key != tt.want {
|
|
t.Errorf("Key = %q, want %q", got.Key, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func BenchmarkParseLLMJsonResponse_Fenced(b *testing.B) {
|
|
const content = "```json\n{\"name\":\"Acme\",\"slug\":\"entity/acme\",\"aliases\":[\"A\",\"B\"]}\n```"
|
|
type payload struct {
|
|
Name string `json:"name"`
|
|
}
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
var p payload
|
|
_ = ParseLLMJsonResponse(content, &p)
|
|
}
|
|
}
|