nullkey
ad150c7126
Sweep every CLI output path through the v0.7 envelope contract.
FormatOptions.Emit signature changes to (w, data, meta *output.Meta)
so list commands surface meta.count / has_more in the wire envelope.
TTY indent decision plumbed via FormatOptions.TTY (set by
ResolveDefault). --format and --jq promoted to persistent root flags
so unknown-subcommand paths still reach the typed-envelope guard
(per-command registration would have rejected --format on unknown
commands as cobra-prose exit 2). WEKNORA_FORMAT env-var fallback
honored before TTY-resolved default. AddFormatFlag retained for the
per-command --jq field-hint Long-text addendum.
~55 production Emit call sites swept across cli/cmd/**: list paths
populate meta.count; mutation paths pass nil meta; envelope.profile
threaded via globalProfile. Existing JSON-shape tests migrated to
decode the envelope wrapper.
Multi-target batch operations get a unified shape via new helpers:
- output.BatchItem + output.WriteBatchEnvelope (§4.5 per-item ok
pattern; data:[{id, ok, result?|error?}], meta:{count, successes*,
failures*}; Successes/Failures *int so explicit zero survives
omitempty in all-fail case).
- cmdutil.RunBatch + cmdutil.EmitBatch + cmdutil.DeletedAtNow +
cmdutil.ClassifyContextErr collapse the three previously-duplicated
multi-delete pipelines (doc / chunk / session) into one call site
pattern. doc upload --recursive uses the same helpers with a per-
file resultFn. Summary error sets Silent:true so the stderr
envelope path doesn't duplicate the stdout batch detail (exit 1
preserved via Code → ExitCode).
ConfirmDestructive / ConfirmDestructiveBatch extended with action +
retryCmd parameters. Every destructive command (kb delete, kb edit,
doc delete, doc delete --all, agent delete, agent edit, session
delete, chunk delete, auth logout, api -X DELETE) now attaches
error.risk.{level:"destructive", action:"<noun.verb>"} +
error.retry_command on the exit-10 envelope. kb edit / agent edit
also gain the destructive guard wiring (CHANGELOG listed them as
gated but they were silently executing without -y).
MCP tool handlers' 31 error paths return CallToolResult with
IsError + Content text fallback + StructuredContent (envelope.error
shape via cmdutil.ErrorToDetail). Handler Out type changed from
typed *sdk.X to any so the go-sdk auto-marshal doesn't overwrite
StructuredContent with a zero-struct on error returns. Success path
manually populates CallToolResult.StructuredContent via successResult
helper.
weknora api cleanup:
- -d/--data flag removed; body via --input <file> or --input -
(stdin) only. Aligns with gh / curl convention.
- HTTP method whitelist removed; any non-empty method accepted.
- HTTP Retry-After header → cmdutil.Error.RetryAfterSeconds →
envelope.error.retry_after_seconds.
- runAPIPaginated raw-passthrough fallback now wraps response in
envelope so --paginate never emits bare JSON to stdout.
Test sweep: ~60 cmd/** tests migrated to decode envelope shape.
9 wire-contract goldens updated under cli/acceptance/testdata/wire/.
Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §4 / §5
94 lines
2.4 KiB
Go
94 lines
2.4 KiB
Go
package kb
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
type fakeStatusSvc struct {
|
|
kb *sdk.KnowledgeBase
|
|
getErr error
|
|
}
|
|
|
|
func (f *fakeStatusSvc) GetKnowledgeBase(_ context.Context, id string) (*sdk.KnowledgeBase, error) {
|
|
if f.getErr != nil {
|
|
return nil, f.getErr
|
|
}
|
|
return f.kb, nil
|
|
}
|
|
|
|
func TestRunStatus_ShallowFields(t *testing.T) {
|
|
svc := &fakeStatusSvc{kb: &sdk.KnowledgeBase{
|
|
ID: "kb_x",
|
|
KnowledgeCount: 42,
|
|
ChunkCount: 100,
|
|
IsProcessing: true,
|
|
ProcessingCount: 3,
|
|
}}
|
|
res, err := runStatus(context.Background(), svc, "kb_x")
|
|
if err != nil {
|
|
t.Fatalf("runStatus: %v", err)
|
|
}
|
|
if !res.Reachable {
|
|
t.Error("Reachable=false, want true")
|
|
}
|
|
if res.KnowledgeCount != 42 || res.ChunkCount != 100 || res.ProcessingCount != 3 || !res.IsProcessing {
|
|
t.Errorf("got %+v", res)
|
|
}
|
|
}
|
|
|
|
func TestRunStatus_Unreachable(t *testing.T) {
|
|
svc := &fakeStatusSvc{getErr: fmt.Errorf("404 not found")}
|
|
res, err := runStatus(context.Background(), svc, "kb_x")
|
|
if err != nil {
|
|
t.Fatalf("runStatus should not return err on unreachable; got %v", err)
|
|
}
|
|
if res.Reachable {
|
|
t.Error("Reachable=true, want false")
|
|
}
|
|
if res.ID != "kb_x" {
|
|
t.Errorf("ID=%q, want kb_x (echoed even when unreachable)", res.ID)
|
|
}
|
|
}
|
|
|
|
func TestEmitStatus_JSON(t *testing.T) {
|
|
var buf bytes.Buffer
|
|
res := &StatusResult{ID: "kb_x", Reachable: true, KnowledgeCount: 5}
|
|
fopts := &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}
|
|
if err := emitStatus(res, fopts, &buf); err != nil {
|
|
t.Fatalf("emitStatus: %v", err)
|
|
}
|
|
var env struct {
|
|
OK bool `json:"ok"`
|
|
Data StatusResult `json:"data"`
|
|
}
|
|
if err := json.Unmarshal(buf.Bytes(), &env); err != nil {
|
|
t.Fatalf("not JSON: %v\n%s", err, buf.String())
|
|
}
|
|
got := env.Data
|
|
if got.ID != "kb_x" || got.KnowledgeCount != 5 {
|
|
t.Errorf("got %+v", got)
|
|
}
|
|
}
|
|
|
|
func TestEmitStatus_TextHuman(t *testing.T) {
|
|
var buf bytes.Buffer
|
|
res := &StatusResult{ID: "kb_x", Reachable: true, KnowledgeCount: 5, ChunkCount: 20, IsProcessing: true, ProcessingCount: 1}
|
|
fopts := &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}
|
|
if err := emitStatus(res, fopts, &buf); err != nil {
|
|
t.Fatalf("emitStatus: %v", err)
|
|
}
|
|
for _, want := range []string{"kb_x", "5", "20", "true"} {
|
|
if !strings.Contains(buf.String(), want) {
|
|
t.Errorf("output missing %q:\n%s", want, buf.String())
|
|
}
|
|
}
|
|
}
|