ad150c7126
Sweep every CLI output path through the v0.7 envelope contract.
FormatOptions.Emit signature changes to (w, data, meta *output.Meta)
so list commands surface meta.count / has_more in the wire envelope.
TTY indent decision plumbed via FormatOptions.TTY (set by
ResolveDefault). --format and --jq promoted to persistent root flags
so unknown-subcommand paths still reach the typed-envelope guard
(per-command registration would have rejected --format on unknown
commands as cobra-prose exit 2). WEKNORA_FORMAT env-var fallback
honored before TTY-resolved default. AddFormatFlag retained for the
per-command --jq field-hint Long-text addendum.
~55 production Emit call sites swept across cli/cmd/**: list paths
populate meta.count; mutation paths pass nil meta; envelope.profile
threaded via globalProfile. Existing JSON-shape tests migrated to
decode the envelope wrapper.
Multi-target batch operations get a unified shape via new helpers:
- output.BatchItem + output.WriteBatchEnvelope (§4.5 per-item ok
pattern; data:[{id, ok, result?|error?}], meta:{count, successes*,
failures*}; Successes/Failures *int so explicit zero survives
omitempty in all-fail case).
- cmdutil.RunBatch + cmdutil.EmitBatch + cmdutil.DeletedAtNow +
cmdutil.ClassifyContextErr collapse the three previously-duplicated
multi-delete pipelines (doc / chunk / session) into one call site
pattern. doc upload --recursive uses the same helpers with a per-
file resultFn. Summary error sets Silent:true so the stderr
envelope path doesn't duplicate the stdout batch detail (exit 1
preserved via Code → ExitCode).
ConfirmDestructive / ConfirmDestructiveBatch extended with action +
retryCmd parameters. Every destructive command (kb delete, kb edit,
doc delete, doc delete --all, agent delete, agent edit, session
delete, chunk delete, auth logout, api -X DELETE) now attaches
error.risk.{level:"destructive", action:"<noun.verb>"} +
error.retry_command on the exit-10 envelope. kb edit / agent edit
also gain the destructive guard wiring (CHANGELOG listed them as
gated but they were silently executing without -y).
MCP tool handlers' 31 error paths return CallToolResult with
IsError + Content text fallback + StructuredContent (envelope.error
shape via cmdutil.ErrorToDetail). Handler Out type changed from
typed *sdk.X to any so the go-sdk auto-marshal doesn't overwrite
StructuredContent with a zero-struct on error returns. Success path
manually populates CallToolResult.StructuredContent via successResult
helper.
weknora api cleanup:
- -d/--data flag removed; body via --input <file> or --input -
(stdin) only. Aligns with gh / curl convention.
- HTTP method whitelist removed; any non-empty method accepted.
- HTTP Retry-After header → cmdutil.Error.RetryAfterSeconds →
envelope.error.retry_after_seconds.
- runAPIPaginated raw-passthrough fallback now wraps response in
envelope so --paginate never emits bare JSON to stdout.
Test sweep: ~60 cmd/** tests migrated to decode envelope shape.
9 wire-contract goldens updated under cli/acceptance/testdata/wire/.
Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §4 / §5
120 lines
3.7 KiB
Go
120 lines
3.7 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// StatusResult is the health-oriented response for `kb status <id>`.
|
|
// Shallow read only: 1 HTTP call, no failed-doc aggregation.
|
|
// For deep verification including failed_count, use `kb check <id>`.
|
|
type StatusResult struct {
|
|
ID string `json:"id"`
|
|
Reachable bool `json:"reachable"`
|
|
KnowledgeCount int64 `json:"knowledge_count,omitempty"`
|
|
ChunkCount int64 `json:"chunk_count,omitempty"`
|
|
IsProcessing bool `json:"is_processing,omitempty"`
|
|
ProcessingCount int64 `json:"processing_count,omitempty"`
|
|
}
|
|
|
|
// StatusService is the narrow SDK surface needed for kb status.
|
|
type StatusService interface {
|
|
GetKnowledgeBase(ctx context.Context, id string) (*sdk.KnowledgeBase, error)
|
|
}
|
|
|
|
var kbStatusFields = []string{
|
|
"id", "reachable", "knowledge_count", "chunk_count",
|
|
"is_processing", "processing_count",
|
|
}
|
|
|
|
// NewCmdStatus builds `weknora kb status <id>`.
|
|
func NewCmdStatus(f *cmdutil.Factory) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "status <kb-id>",
|
|
Short: "Show health status of a knowledge base (shallow, 1 HTTP)",
|
|
Long: `Show health-oriented fields for a KB.
|
|
|
|
1 HTTP call:
|
|
reachable / knowledge_count / chunk_count / is_processing / processing_count
|
|
|
|
For deep verification including failed_count, use 'weknora kb check <id>'
|
|
(1 + N HTTP, pages the doc list with parse_status=failed).
|
|
|
|
For full metadata (config / pinned / tenant), use 'weknora kb view <id>'.`,
|
|
Example: ` weknora kb status kb_abc
|
|
weknora kb status kb_abc --format json`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
res, err := runStatus(c.Context(), cli, args[0])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return emitStatus(res, fopts, iostreams.IO.Out)
|
|
},
|
|
}
|
|
cmdutil.AddFormatFlag(cmd, kbStatusFields...)
|
|
return cmd
|
|
}
|
|
|
|
// runStatus is the testable core: fetch KB metadata and return a StatusResult.
|
|
// Never returns an error for "kb not reachable" (Reachable=false carries
|
|
// that signal).
|
|
func runStatus(ctx context.Context, svc StatusService, id string) (*StatusResult, error) {
|
|
kb, err := svc.GetKnowledgeBase(ctx, id)
|
|
if err != nil {
|
|
return &StatusResult{ID: id, Reachable: false}, nil
|
|
}
|
|
return &StatusResult{
|
|
ID: kb.ID,
|
|
Reachable: true,
|
|
KnowledgeCount: kb.KnowledgeCount,
|
|
ChunkCount: kb.ChunkCount,
|
|
IsProcessing: kb.IsProcessing,
|
|
ProcessingCount: kb.ProcessingCount,
|
|
}, nil
|
|
}
|
|
|
|
// emitStatus renders res using --format options. Mirrors emitWaitResult
|
|
// pattern from cli/cmd/doc/wait.go for consistency.
|
|
func emitStatus(res *StatusResult, fopts *cmdutil.FormatOptions, w io.Writer) error {
|
|
switch fopts.Mode {
|
|
case cmdutil.FormatJSON, cmdutil.FormatNDJSON:
|
|
return fopts.Emit(w, res, nil)
|
|
case cmdutil.FormatHuman, "":
|
|
return writeStatusText(w, res)
|
|
default:
|
|
return fmt.Errorf("unsupported --format %q for kb status", fopts.Mode)
|
|
}
|
|
}
|
|
|
|
func writeStatusText(w io.Writer, res *StatusResult) error {
|
|
fmt.Fprintf(w, "ID: %s\n", res.ID)
|
|
fmt.Fprintf(w, "Reachable: %v\n", res.Reachable)
|
|
if !res.Reachable {
|
|
return nil
|
|
}
|
|
fmt.Fprintf(w, "Knowledge: %d\n", res.KnowledgeCount)
|
|
fmt.Fprintf(w, "Chunks: %d\n", res.ChunkCount)
|
|
fmt.Fprintf(w, "Processing: %v (%d active)\n", res.IsProcessing, res.ProcessingCount)
|
|
return nil
|
|
}
|
|
|
|
// compile-time check: SDK client satisfies StatusService.
|
|
var _ StatusService = (*sdk.Client)(nil)
|