ad150c7126
Sweep every CLI output path through the v0.7 envelope contract.
FormatOptions.Emit signature changes to (w, data, meta *output.Meta)
so list commands surface meta.count / has_more in the wire envelope.
TTY indent decision plumbed via FormatOptions.TTY (set by
ResolveDefault). --format and --jq promoted to persistent root flags
so unknown-subcommand paths still reach the typed-envelope guard
(per-command registration would have rejected --format on unknown
commands as cobra-prose exit 2). WEKNORA_FORMAT env-var fallback
honored before TTY-resolved default. AddFormatFlag retained for the
per-command --jq field-hint Long-text addendum.
~55 production Emit call sites swept across cli/cmd/**: list paths
populate meta.count; mutation paths pass nil meta; envelope.profile
threaded via globalProfile. Existing JSON-shape tests migrated to
decode the envelope wrapper.
Multi-target batch operations get a unified shape via new helpers:
- output.BatchItem + output.WriteBatchEnvelope (§4.5 per-item ok
pattern; data:[{id, ok, result?|error?}], meta:{count, successes*,
failures*}; Successes/Failures *int so explicit zero survives
omitempty in all-fail case).
- cmdutil.RunBatch + cmdutil.EmitBatch + cmdutil.DeletedAtNow +
cmdutil.ClassifyContextErr collapse the three previously-duplicated
multi-delete pipelines (doc / chunk / session) into one call site
pattern. doc upload --recursive uses the same helpers with a per-
file resultFn. Summary error sets Silent:true so the stderr
envelope path doesn't duplicate the stdout batch detail (exit 1
preserved via Code → ExitCode).
ConfirmDestructive / ConfirmDestructiveBatch extended with action +
retryCmd parameters. Every destructive command (kb delete, kb edit,
doc delete, doc delete --all, agent delete, agent edit, session
delete, chunk delete, auth logout, api -X DELETE) now attaches
error.risk.{level:"destructive", action:"<noun.verb>"} +
error.retry_command on the exit-10 envelope. kb edit / agent edit
also gain the destructive guard wiring (CHANGELOG listed them as
gated but they were silently executing without -y).
MCP tool handlers' 31 error paths return CallToolResult with
IsError + Content text fallback + StructuredContent (envelope.error
shape via cmdutil.ErrorToDetail). Handler Out type changed from
typed *sdk.X to any so the go-sdk auto-marshal doesn't overwrite
StructuredContent with a zero-struct on error returns. Success path
manually populates CallToolResult.StructuredContent via successResult
helper.
weknora api cleanup:
- -d/--data flag removed; body via --input <file> or --input -
(stdin) only. Aligns with gh / curl convention.
- HTTP method whitelist removed; any non-empty method accepted.
- HTTP Retry-After header → cmdutil.Error.RetryAfterSeconds →
envelope.error.retry_after_seconds.
- runAPIPaginated raw-passthrough fallback now wraps response in
envelope so --paginate never emits bare JSON to stdout.
Test sweep: ~60 cmd/** tests migrated to decode envelope shape.
9 wire-contract goldens updated under cli/acceptance/testdata/wire/.
Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §4 / §5
150 lines
4.8 KiB
Go
150 lines
4.8 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// CheckResult is the deep-verification response for `kb check <id>`.
|
|
// Superset of StatusResult: includes all status fields plus FailedCount
|
|
// aggregated by paging the doc list. Verb split with `kb status`:
|
|
// status reads existing state cheaply, check actively verifies.
|
|
type CheckResult struct {
|
|
ID string `json:"id"`
|
|
Reachable bool `json:"reachable"`
|
|
KnowledgeCount int64 `json:"knowledge_count,omitempty"`
|
|
ChunkCount int64 `json:"chunk_count,omitempty"`
|
|
IsProcessing bool `json:"is_processing,omitempty"`
|
|
ProcessingCount int64 `json:"processing_count,omitempty"`
|
|
FailedCount int64 `json:"failed_count"` // always populated (no omitempty)
|
|
}
|
|
|
|
// CheckService is the narrow SDK surface needed for kb check.
|
|
type CheckService interface {
|
|
GetKnowledgeBase(ctx context.Context, id string) (*sdk.KnowledgeBase, error)
|
|
ListKnowledgeWithFilter(ctx context.Context, kbID string, page, pageSize int, filter sdk.KnowledgeListFilter) ([]sdk.Knowledge, int64, error)
|
|
}
|
|
|
|
var kbCheckFields = []string{
|
|
"id", "reachable", "knowledge_count", "chunk_count",
|
|
"is_processing", "processing_count", "failed_count",
|
|
}
|
|
|
|
// NewCmdCheck builds `weknora kb check <id>`.
|
|
func NewCmdCheck(f *cmdutil.Factory) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "check <kb-id>",
|
|
Short: "Verify a knowledge base end-to-end (status + failed-doc aggregation)",
|
|
Long: `Active verification of a knowledge base.
|
|
|
|
Performs 1 + N HTTP calls:
|
|
1 GET /kb/{id} — reachable + counts + processing state
|
|
N page-walk doc list with parse_status=failed — failed_count
|
|
|
|
Use 'weknora kb status <id>' for a fast read-only health snapshot
|
|
(1 HTTP call, no failed_count). Use 'kb check' when you need
|
|
verification including failed-doc aggregation.`,
|
|
Example: ` weknora kb check kb_abc
|
|
weknora kb check kb_abc --format json`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
res, err := runCheck(c.Context(), cli, args[0])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return emitCheck(res, fopts, iostreams.IO.Out)
|
|
},
|
|
}
|
|
cmdutil.AddFormatFlag(cmd, kbCheckFields...)
|
|
return cmd
|
|
}
|
|
|
|
// runCheck is the testable core: status fields + failed-doc aggregation.
|
|
// Never returns an error for "kb not reachable" (Reachable=false carries
|
|
// the signal).
|
|
func runCheck(ctx context.Context, svc CheckService, id string) (*CheckResult, error) {
|
|
kb, err := svc.GetKnowledgeBase(ctx, id)
|
|
if err != nil {
|
|
return &CheckResult{ID: id, Reachable: false}, nil
|
|
}
|
|
res := &CheckResult{
|
|
ID: kb.ID,
|
|
Reachable: true,
|
|
KnowledgeCount: kb.KnowledgeCount,
|
|
ChunkCount: kb.ChunkCount,
|
|
IsProcessing: kb.IsProcessing,
|
|
ProcessingCount: kb.ProcessingCount,
|
|
}
|
|
failed, err := aggregateFailedCount(ctx, svc, id)
|
|
if err != nil {
|
|
return res, fmt.Errorf("aggregate failed_count: %w", err)
|
|
}
|
|
res.FailedCount = failed
|
|
return res, nil
|
|
}
|
|
|
|
// aggregateFailedCount pages the doc list with parse_status=failed and
|
|
// returns the total count. Termination uses accumulated total (not
|
|
// page*pageSize) so server-capped page sizes don't truncate.
|
|
func aggregateFailedCount(ctx context.Context, svc CheckService, kbID string) (int64, error) {
|
|
const pageSize = 100
|
|
var total int64
|
|
page := 1
|
|
for {
|
|
docs, totalAvailable, err := svc.ListKnowledgeWithFilter(ctx, kbID, page, pageSize, sdk.KnowledgeListFilter{ParseStatus: "failed"})
|
|
if err != nil {
|
|
return total, err
|
|
}
|
|
total += int64(len(docs))
|
|
if total >= totalAvailable || len(docs) == 0 {
|
|
break
|
|
}
|
|
page++
|
|
}
|
|
return total, nil
|
|
}
|
|
|
|
// emitCheck renders res. Same dispatch as emitStatus.
|
|
func emitCheck(res *CheckResult, fopts *cmdutil.FormatOptions, w io.Writer) error {
|
|
switch fopts.Mode {
|
|
case cmdutil.FormatJSON, cmdutil.FormatNDJSON:
|
|
return fopts.Emit(w, res, nil)
|
|
case cmdutil.FormatHuman, "":
|
|
return writeCheckText(w, res)
|
|
default:
|
|
return fmt.Errorf("unsupported --format %q for kb check", fopts.Mode)
|
|
}
|
|
}
|
|
|
|
func writeCheckText(w io.Writer, res *CheckResult) error {
|
|
fmt.Fprintf(w, "ID: %s\n", res.ID)
|
|
fmt.Fprintf(w, "Reachable: %v\n", res.Reachable)
|
|
if !res.Reachable {
|
|
return nil
|
|
}
|
|
fmt.Fprintf(w, "Knowledge: %d\n", res.KnowledgeCount)
|
|
fmt.Fprintf(w, "Chunks: %d\n", res.ChunkCount)
|
|
fmt.Fprintf(w, "Processing: %v (%d active)\n", res.IsProcessing, res.ProcessingCount)
|
|
fmt.Fprintf(w, "Failed: %d\n", res.FailedCount)
|
|
return nil
|
|
}
|
|
|
|
// compile-time check: SDK client satisfies CheckService.
|
|
var _ CheckService = (*sdk.Client)(nil)
|