a2e368b1e8
Three command renames consolidate the v0.7 verb table:
- `weknora agent invoke` → `weknora session ask --agent <id>`.
Server route POST /sessions/{session_id}/agent-qa is session-
anchored, so the verb moves with it. `weknora agent` subtree keeps
CRUD only (list / view / create / edit / delete / status / check).
SDK call (AgentQAStreamWithRequest) preserved verbatim; only the
command surface + flag layout move.
- `weknora doc upload` split into three commands:
- `weknora doc upload <file>` — local file (only).
- `weknora doc fetch <url>` — server-side remote fetch (was
`upload --from-url`). URL-only flags (--title / --file-type /
--tag-id) move with the verb.
- `weknora doc create --text` — direct text knowledge entry via
server CreateManualKnowledge.
- `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`.
Atomic server ClearKnowledgeBaseContents (no list-then-delete
race). Same exit-10 -y/--yes guard as other destructive verbs;
unified through the extended ConfirmDestructive helper.
Parent commands (agent, kb, doc, chunk, session, auth, profile,
search) lose their explicit Args:NoArgs + Run:cmd.Help so the
unknown-subcommand guard fires correctly — `weknora agent invoke
ag_x q` now emits the typed input.unknown_subcommand envelope with
detail.available[] instead of cobra's free-form exit-2 prose.
Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
141 lines
5.4 KiB
Go
141 lines
5.4 KiB
Go
package doc
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// fakeCreateSvc captures call arguments and returns canned responses.
|
|
type fakeCreateSvc struct {
|
|
resp *sdk.Knowledge
|
|
err error
|
|
got struct {
|
|
kbID string
|
|
req *sdk.CreateManualKnowledgeRequest
|
|
}
|
|
}
|
|
|
|
func (f *fakeCreateSvc) CreateManualKnowledge(
|
|
_ context.Context,
|
|
kbID string,
|
|
req *sdk.CreateManualKnowledgeRequest,
|
|
) (*sdk.Knowledge, error) {
|
|
f.got.kbID = kbID
|
|
f.got.req = req
|
|
return f.resp, f.err
|
|
}
|
|
|
|
func TestCreate_Success_Human(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeCreateSvc{resp: &sdk.Knowledge{ID: "doc_manual_1", Title: "Sprint Notes"}}
|
|
opts := &CreateOptions{Text: "# Sprint Notes\n\nAction items: ...", Name: "Sprint Notes"}
|
|
require.NoError(t, runCreate(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc, "kb_xxx"))
|
|
|
|
assert.Equal(t, "kb_xxx", svc.got.kbID)
|
|
assert.Equal(t, "# Sprint Notes\n\nAction items: ...", svc.got.req.Content)
|
|
assert.Equal(t, "Sprint Notes", svc.got.req.Title)
|
|
assert.Contains(t, out.String(), "Created")
|
|
assert.Contains(t, out.String(), "doc_manual_1")
|
|
}
|
|
|
|
func TestCreate_Success_NoName_FallsBackToTitle(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeCreateSvc{resp: &sdk.Knowledge{ID: "doc_manual_2", Title: "Server Title"}}
|
|
opts := &CreateOptions{Text: "Some content"}
|
|
require.NoError(t, runCreate(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc, "kb_xxx"))
|
|
// When --name is omitted the display falls back to k.Title from the server response.
|
|
assert.Contains(t, out.String(), "Server Title")
|
|
}
|
|
|
|
func TestCreate_Success_NoName_NoTitle_FallsBackToID(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeCreateSvc{resp: &sdk.Knowledge{ID: "doc_manual_3"}}
|
|
opts := &CreateOptions{Text: "Some content"}
|
|
require.NoError(t, runCreate(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc, "kb_xxx"))
|
|
assert.Contains(t, out.String(), "doc_manual_3")
|
|
}
|
|
|
|
func TestCreate_TagID_Forwarded(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeCreateSvc{resp: &sdk.Knowledge{ID: "doc_t"}}
|
|
opts := &CreateOptions{Text: "content", TagID: "tag_42"}
|
|
require.NoError(t, runCreate(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc, "kb_xxx"))
|
|
assert.Equal(t, "tag_42", svc.got.req.TagID)
|
|
}
|
|
|
|
func TestCreate_Channel_Override(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeCreateSvc{resp: &sdk.Knowledge{ID: "doc_ch"}}
|
|
opts := &CreateOptions{Text: "content", Channel: "browser_extension"}
|
|
require.NoError(t, runCreate(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc, "kb_xxx"))
|
|
assert.Equal(t, "browser_extension", svc.got.req.Channel)
|
|
}
|
|
|
|
func TestCreate_Channel_DefaultIsAPI(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeCreateSvc{resp: &sdk.Knowledge{ID: "doc_ch"}}
|
|
opts := &CreateOptions{Text: "content"}
|
|
require.NoError(t, runCreate(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc, "kb_xxx"))
|
|
assert.Equal(t, uploadChannel, svc.got.req.Channel)
|
|
}
|
|
|
|
func TestCreate_JSON_Envelope(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeCreateSvc{resp: &sdk.Knowledge{ID: "doc_manual_json", Title: "My Note"}}
|
|
opts := &CreateOptions{Text: "# My Note", Name: "My Note"}
|
|
fopts := &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}
|
|
require.NoError(t, runCreate(context.Background(), opts, fopts, svc, "kb_xxx"))
|
|
|
|
got := out.String()
|
|
var env struct {
|
|
OK bool `json:"ok"`
|
|
Data sdk.Knowledge `json:"data"`
|
|
}
|
|
require.NoError(t, json.Unmarshal([]byte(got), &env), "expected valid JSON envelope, got %q", got)
|
|
assert.True(t, env.OK, "envelope.ok must be true")
|
|
assert.Equal(t, "doc_manual_json", env.Data.ID, "envelope.data.id must match")
|
|
}
|
|
|
|
func TestCreate_ServerError_Wraps(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeCreateSvc{err: errors.New("HTTP error 500: internal server error")}
|
|
err := runCreate(context.Background(),
|
|
&CreateOptions{Text: "content"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc, "kb_xxx")
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeServerError, typed.Code)
|
|
}
|
|
|
|
func TestCreate_HTTPError_400_Wraps(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeCreateSvc{err: errors.New("HTTP error 400: bad request")}
|
|
err := runCreate(context.Background(),
|
|
&CreateOptions{Text: "content"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc, "kb_xxx")
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeInputInvalidArgument, typed.Code)
|
|
}
|
|
|
|
func TestCreate_EmptyText_RejectsBeforeSDK(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
// The SDK should never be called when --text is empty (runCreate has a
|
|
// defensive guard; cobra's MarkFlagRequired catches it earlier in RunE).
|
|
svc := &fakeCreateSvc{resp: &sdk.Knowledge{ID: "should-not-reach"}}
|
|
err := runCreate(context.Background(),
|
|
&CreateOptions{Text: ""}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc, "kb_xxx")
|
|
require.Error(t, err)
|
|
// Verify the SDK was NOT called.
|
|
assert.Nil(t, svc.got.req, "SDK must not be called when --text is empty")
|
|
}
|